[Forum] After Upgraded from 4.0.3 PL 1 to 4.0.5 Two Ads Positions Disappeared

[trankin]

I was surprised that after I upgraded to 4.0.5 two of my ads positions are gone from my board.

ad_footer_end
ad_showthread_firstpost

I checked my templates: SHOWTHREAD, header, headinclude, footer, and other customized templates. Everything is intact. So I went and skimmed through the vb 4.0.5 code, and found the following:

The code below was in vb 4.0.3 PL 1 and missing in 4.0.5

    File: showthread.php, Line 1048
        // Only show after the first post, counter isn't incremented for deleted/moderated posts
        if ($post['isfirstshown'])
        {
            $postbits .= vB_Template::create('ad_showthread_firstpost')->render();
        } 

Similarly the code below was in vb 4.0.3 PL 1 and missing in 4.0.5

    File: includes/class_bootstrap.php, Line 416
$ad_location['ad_footer_end'] = vB_Template::create('ad_footer_end')->render(); 

Although I acknowledge that I should not change the original vb code, just for testing, I placed the code I mentioned above to 4.0.5 code and my ads are displaying correctly on my board again. Could anyone explain me why these code are removed in vb 4.0.5 and what is the alternative feature I could use in this new version to show my ads?

-Nay

[audiokid]

I'm concerned over this. I am using all the ad positions and don't want those ad slots changed. I have clients in these positions and don't need more vbulletin surprises that cost me. I haven't upgraded to 4.0.5 because of all the past bugs, looks like I'm waiting again.

Could someone confirm why this is happening?

[Trevor Hannant]

Not sure why this has happened but there is a confirmed Bug for it here:

http://tracker.vbulletin.com/browse/VBIV-7586

[trankin]

I hope vb4.0.6 will fix this issue. I have a few more vb 3.* forum to upgrade.
-Nay

[audiokid]

I didn't see it in the list? Anyone see it as fixed in 4.0.6?

[stwan]

Please fixed in 4.0.8!

[ecky]

I was surprised that after I upgraded to 4.0.5 two of my ads positions are gone from my board.

ad_footer_end
ad_showthread_firstpost

I checked my templates: SHOWTHREAD, header, headinclude, footer, and other customized templates. Everything is intact. So I went and skimmed through the vb 4.0.5 code, and found the following:

The code below was in vb 4.0.3 PL 1 and missing in 4.0.5

    File: showthread.php, Line 1048
        // Only show after the first post, counter isn't incremented for deleted/moderated posts
        if ($post['isfirstshown'])
        {
            $postbits .= vB_Template::create('ad_showthread_firstpost')->render();
        } 

Similarly the code below was in vb 4.0.3 PL 1 and missing in 4.0.5

    File: includes/class_bootstrap.php, Line 416
$ad_location['ad_footer_end'] = vB_Template::create('ad_footer_end')->render(); 

Although I acknowledge that I should not change the original vb code, just for testing, I placed the code I mentioned above to 4.0.5 code and my ads are displaying correctly on my board again. Could anyone explain me why these code are removed in vb 4.0.5 and what is the alternative feature I could use in this new version to show my ads?

-Nay

I did get your message here http://tracker.vbulletin.com/browse/VBIV-7586 but the comments were closed before I had time to thank you. I was also left behind on vb 4.0.3 because I've got advertisers in both these spaces.

I edited the files as shown before upgrading to 4.0.7. Although the line numbers were out slightly for editing, the code was easy to find and the upgrade seems to have been a success with all the ad slots still intact.

Thanks again my friend.