In import.php, we have two occurences of the following logic:
if ($timeregs[3]=="PM") {
$timeregs[1]+=12;
if ($timeregs[1]==24) {
$timeregs[1]=0;
This is incorrect, as it converts the time stamp for every post made during the noon hour to the midnight hour....and improperly arranges the post order as a result. This seriously affects any thread in which the originating post was during the noon hour.
The fix:
Change all occurences of
if ($timeregs[3]=="PM") {
to read
if ($timeregs[3]=="PM" and $timeregs[1] != 12){
______________________________________________
Additional bug:
In the line:
// $day++; THIS LINE SHOULD BE USED, BUT IT WAS CAUSING INCORRECT
The creator is correct to comment this out, but his reason is faulty....we've already grabbed the correct date from the UBB files...why would one wish to roll it forward? In any case, since it's commented out, it should make no difference, except that it appears further down like this:
$day++;
The statement above should also be commented out.
Rich
[Edited by TheFiringLine.com on 09-30-2000 at 09:19 AM]
if ($timeregs[3]=="PM") {
$timeregs[1]+=12;
if ($timeregs[1]==24) {
$timeregs[1]=0;
This is incorrect, as it converts the time stamp for every post made during the noon hour to the midnight hour....and improperly arranges the post order as a result. This seriously affects any thread in which the originating post was during the noon hour.
The fix:
Change all occurences of
if ($timeregs[3]=="PM") {
to read
if ($timeregs[3]=="PM" and $timeregs[1] != 12){
______________________________________________
Additional bug:
In the line:
// $day++; THIS LINE SHOULD BE USED, BUT IT WAS CAUSING INCORRECT
The creator is correct to comment this out, but his reason is faulty....we've already grabbed the correct date from the UBB files...why would one wish to roll it forward? In any case, since it's commented out, it should make no difference, except that it appears further down like this:
$day++;
The statement above should also be commented out.
Rich
[Edited by TheFiringLine.com on 09-30-2000 at 09:19 AM]