I sincerely want to thank the developers for releasing a code style guide and (mostly) complying by it...it's a far cry over vB2 and the code infinitely easier to read and modify now. Thanks.
Now the obligitory objections:
(coincidental bug: URLs directly proceeding a list element are not parsed)
Now the obligitory objections:
- http://www.vbulletin.com/docs/html/main/codestandards_indenting ; clarification: use a tab character or the more traditional and portable four spaces?
- "SQL Queries should always be double-quoted.": why, as it contradicts "Strings should be quoted with single quotes if they contain no variables or control characters, otherwise use double quotes"?
- Code:
$a = $userinfo["$var[12]"]; $b = $userinfo["$var[username]"]; $c = $userinfo["$var[$field]"];
- http://www.vbulletin.com/docs/html/main/codestandards_and_or : I feel that they should be the lowercase form as they more closely represent keywords (which are always lowercase) rather than constants (which are always uppercase)
- http://www.vbulletin.com/docs/html/main/codestandards_comments : I would buy 50 more licenses if functions also included PHPDoc-style documentation as it is downright torturous to determine what certain arguments mean sometimes (and yes, I will not buy 50 more licenses )
- For checking for an empty string, a question: why use "== ''" rather than "empty($var)", or is this just a personal preference that stuck through development?
(coincidental bug: URLs directly proceeding a list element are not parsed)