Missing CSS classes since 5.5.1 update

Collapse
X
 
  • Time
  • Show
Clear All
new posts
  • Carrfixr
    Senior Member
    • May 2017
    • 1364
    • 5.5.x

    Missing CSS classes since 5.5.1 update

    Missing these CSS classes for the following moderation submenus:

    - "Select All" (moderation-select-all)
    - "Select None" (moderation-select-none)
    - "Invert Selection" (moderation-select-invert)
    - "Select Unapproved Posts" (moderation-select-unapproved)
    - "Select Deleted Posts" (moderation-select-deleted)
    - "Select Posts with Attachments" (moderation-select-attachments)

  • Wayne Luke
    vBulletin Technical Support Lead
    • Aug 2000
    • 73976

    #2
    It appears those classes were used for Javascript purposes and not CSS purposes in the default code. Their functionality appears to have been moved to the data attributes of data-action and data-params in the code.
    Translations provided by Google.

    Wayne Luke
    The Rabid Badger - a vBulletin Cloud demonstration site.
    vBulletin 5 API

    Comment

    • glennrocksvb
      Former vBulletin Developer
      • Mar 2011
      • 4011
      • 5.7.X

      #3
      Originally posted by Wayne Luke
      It appears those classes were used for Javascript purposes and not CSS purposes in the default code. Their functionality appears to have been moved to the data attributes of data-action and data-params in the code.
      The data-action and data-params attributes in the <a> tag had been there for a long time (might have been since 5.0.0). And besides, only those listed have the missing classes while the rest have them intact. And the classes were in the <li> tags not in the <a> tags. Having the distinguishing classes or data attributes in the <a> tag doesn't help in styling the parent <li> tag.
      Last edited by glennrocksvb; Mon 25 Mar '19, 7:22am.

      Flag Icon Postbit Insert GIPHY Impersonate User BETTER INITIALS AVATAR Better Name Card Quote Selected Text Bookmark Posts Post Footer Translate Stop Links in Posts +MORE!

      Comment

      • Carrfixr
        Senior Member
        • May 2017
        • 1364
        • 5.5.x

        #4
        Wayne is there a chance to have these reverted? or is it a done deal?

        Comment

        • Wayne Luke
          vBulletin Technical Support Lead
          • Aug 2000
          • 73976

          #5
          You would need to create a bug report and provide a use case on why they are necessary. Hiding things with CSS isn't really the best course of action.
          Translations provided by Google.

          Wayne Luke
          The Rabid Badger - a vBulletin Cloud demonstration site.
          vBulletin 5 API

          Comment

          • Wayne Luke
            vBulletin Technical Support Lead
            • Aug 2000
            • 73976

            #6
            Originally posted by Glenn Vergara

            The data-action and data-params attributes in the <a> tag had been there for a long time (might have been since 5.0.0). And besides, only those listed have the missing classes while the rest have them intact. And the classes were in the <li> tags not in the <a> tags. Having the distinguishing classes or data attributes in the <a> tag doesn't help in styling the parent <li> tag.
            If the classes were seen as unneeded and linked to obsolete code, they would have been removed. Each release has quite a bit of refactoring going on behind the scenes these days.
            Translations provided by Google.

            Wayne Luke
            The Rabid Badger - a vBulletin Cloud demonstration site.
            vBulletin 5 API

            Comment

            • glennrocksvb
              Former vBulletin Developer
              • Mar 2011
              • 4011
              • 5.7.X

              #7
              Originally posted by Wayne Luke
              You would need to create a bug report and provide a use case on why they are necessary. Hiding things with CSS isn't really the best course of action.
              These actions that don't have distinguishing CSS classes in the <li> container

              - "Select All" (moderation-select-all)
              - "Select None" (moderation-select-none)
              - "Invert Selection" (moderation-select-invert)
              - "Select Unapproved Posts" (moderation-select-unapproved)
              - "Select Deleted Posts" (moderation-select-deleted)
              - "Select Posts with Attachments" (moderation-select-attachments)

              are not controlled by permissions that you can configure in AdminCP (for good reason) because they only pertain to the act of user selection of posts in the UI - to quickly check/uncheck the checkboxes to select/deselect the posts to moderate. They don't perform any actual action on the posts that updates its state such as open, close, delete, etc.

              So the only way to hide them is via CSS. I'm not sure why Carrfixr wanted to hide them as I personally find them useful actions that help moderators to quickly find multiple posts to moderate.

              Flag Icon Postbit Insert GIPHY Impersonate User BETTER INITIALS AVATAR Better Name Card Quote Selected Text Bookmark Posts Post Footer Translate Stop Links in Posts +MORE!

              Comment

              • Carrfixr
                Senior Member
                • May 2017
                • 1364
                • 5.5.x

                #8
                This is why I need to hide it. The registered users see it, when allowing them to delete. IMO they should only see the edit delete at the bottom of the post, not the note pad and gear with moderator options. vbulletin fixed a bug that should not have been fixed

                https://www.vbulletin.com/forum/foru...-setting/page2

                When this got switched around on the latest update my note pad CSS was ineffective for those items mentioned in post #1
                Last edited by Carrfixr; Tue 26 Mar '19, 12:53pm.

                Comment

                Related Topics

                Collapse

                Working...