How to send bug we correct to be included in next release?

Collapse
X
 
  • Time
  • Show
Clear All
new posts
  • Igor Arkadia
    New Member
    • Apr 2015
    • 11
    • 5.1.x

    How to send bug we correct to be included in next release?

    hello,

    when we correct a bug, how to send you the correction to make that it's can be included in next release ? because everytime it's painfull to merge the source!
    can you create for vbulletin licenced user (or a selection of vbulletin licenced user) something like a shared developpement environement (like svn or git?)

    right now i thing it's one of the best idea to boost the developpement of vbulletin for correcting bug !

    exemple

    no possibility to edit guest's posts even if you're admin
    file \core\vb\api\node.php

    you dev forgot that in PHP empty-function returns true on "0" string and guest userID = 0

    original code:
    PHP Code:
    if (!is_array($node)
       OR empty(
    $node['nodeid']) OR empty($node['starter'])
       OR empty(
    $node['channelid']) OR empty($node['userid'])

       OR empty(
    $node['contenttypeid'])
      ) 

    fixed code:
    PHP Code:
    if (!is_array($node)
       OR empty(
    $node['nodeid']) OR empty($node['starter'])
       OR empty(
    $node['channelid'])
       OR (empty(
    $node['userid']) && ($node['userid'] != 0))
       OR empty(
    $node['contenttypeid'])
      ) 


    exemple of other bug


    post unapproved by the spam-filter posts still visible by everyone

    file \core\vb\library\content\text.php
    they are 3 places in the code where you check for approving and 3 places where you set that it's unapproved
    but 2 places have incomplete code like this:

    PHP Code:
    $data['approved'] = 0;
    $isSpam true
    fix to add additional row in these two places:

    PHP Code:
    $data['approved'] = 0;
    $data['showapproved'] = 0;
    $isSpam true
    without this "showapproved" they are still visible for everyone and everyone will see beautyful posts about vagina stimulators


    so can we help you in the developpement ?
  • Wayne Luke
    vBulletin Technical Support Lead
    • Aug 2000
    • 74132

    #2
    vBulletin isn't open source nor do we accept pull requests. However if you found a bug and think you might have a fix, you can enter it into the Issue Tracker.

    Translations provided by Google.

    Wayne Luke
    The Rabid Badger - a vBulletin Cloud demonstration site.
    vBulletin 5 API

    Comment

    widgetinstance 262 (Related Topics) skipped due to lack of content & hide_module_if_empty option.
    Working...