Apply patch 4 problems

[hurricane_sh]

I was running vB4.2.2 Patch level 1, I didn't apply patch 2 and 3 since they don't affect our forums. Can I skip them and apply patch 4 directly? I did this but got the following error when click "Advanced search" or a few other pages (not very important pages). This happened to all our vb 4 forums.

Warning: Declaration of vBForum_Item_SocialGroupMessage::getLoadQuery() should be compatible with that of vB_Model::getLoadQuery() in..../packages/vbforum/item/socialgroupmessage.php on line 0

[hurricane_sh]

Where can I find patch 2 and 3 so that I can reapply them? The patch 4 seems to rely on them.

[Mark.B]

There is only PL4, this contains everything from the earlier patches.

Regarding the error:
Add the following line to your /includes/config.php file, right under the <?php line:
define('SKIP_DS_ERRORS', true);

[hurricane_sh]

Mark, many thanks for your quick reply, it fixed the problem.


Do you have the info on how to fix the problem? That would be even better. I always prefer editing the code to fix the problem over suppressing the errors.

[Mark.B]

It's not an error, it's a warning. Warnings and notices were suppressed in all previous versions of vBulletin. In 4.2.2 we stopped suppressing them. The code I have given you restores the previous behaviour.

There is no fix, because there is nothing to fix. All the warning is, is telling you something might break in a future version of php, but won't break at the moment.

[hurricane_sh]

OK, I understand the situation. But there should be fix. I did fix all such problems on a 3.8.1 forum by changing the code (tons of small changes) to comply with new PHP standards. Thanks again, I will settle for now as only a few pages were affected.

[Mark.B]

OK, I understand the situation. But there should be fix. I did fix all such problems on a 3.8.1 forum by changing the code (tons of small changes) to comply with new PHP standards. Thanks again, I will settle for now as only a few pages were affected.

It isn't a problem and it doesn't require a fix. Warnings are not errors. Warnings and notices should not be displayed on a production server, so if you're server was correctly configured for a live environment you wouldn't know unless you checked the logs. Most common software suppresses these warnings.

I need to be absolutely clear on this for the benefit of others because too often people get their own ideas on this and rush in messing about with code. If you're a qualified php coder then feel free to rewrite the code so it is "notice and warning clean", if you're not then I strongly recommend leaving well alone because if you mess it up, our only support will be "restore from backup".

In short: Nothing is broken = leave well alone.

[Paul M]

Its fixed in 4.2.3, you can download that and look at the code if you wish (or just run it).

[hurricane_sh]

Thanks, Paul. Will try it.