[Forum] die 4 true filling my logs

[fingerstand]

After days of troubleshooting and trying to figure out what exactly is filling up my php error logs, I finally found this god forsaken incredibly vague error in packages/vbforum/attach/album.php

I updated the code to this just so I could verify that it is indeed spamming my error logs:

        {            error_log('packages/vbforum/attach/album.php:116  die 4 ' . var_export($this->attachmentinfo['albumstate'] == 'private'                    AND                !can_view_private_albums($this->attachmentinfo['userid']), true));            // echo clear.gif, not permissions error. This may only be needed for 'albumstate' == 'profile'            return 0;        } 

and it is the culprit.

can you guys give me some suggestions on what i can do to fix this error?

[Hartmut]

i don't see any problem with the original source code, what error message did you find in your php error logs?

[fingerstand]

here is the full error from my logs:

[12-Oct-2012 21:16:11 UTC] die 4 true

[Amaury]

here is the full error from my logs:

[12-Oct-2012 21:16:11 UTC] die 4 true

That seems kind of short to me. Is there anything else?

[Zachery]

How are you sure that line of code is what is causing the problem?

[fingerstand]

How are you sure that line of code is what is causing the problem?

hmm, apparently i'm not being clear enough between the two posts.

so, re: my first post in this thread. i edited line 116 in packages/vbforum/attach/album.php so that instead of

error_log('die 4 ' . var_export($this->attachmentinfo['albumstate'] == 'private' 

it said

error_log('packages/vbforum/attach/album.php:116  die 4 ' . var_export($this->attachmentinfo['albumstate'] == 'private' 

when i changed this line in that file, my error logs started looking like this:

[13-Oct-2012 13:15:36 UTC] die 4 true[13-Oct-2012 13:15:52 UTC] die 4 true
[13-Oct-2012 13:16:06 UTC] die 4 true
[13-Oct-2012 13:16:08 UTC] die 4 true
[13-Oct-2012 13:16:08 UTC] die 4 true
<---- The above being before I edited the album.php, the below being immediately after I edited the album.php, verifying that file and line are indeed what are filling my error logs ---->
[13-Oct-2012 13:16:11 UTC] packages/vbforum/attach/album.php:116  die 4 true
[13-Oct-2012 13:16:22 UTC] packages/vbforum/attach/album.php:116  die 4 true
[13-Oct-2012 13:16:34 UTC] packages/vbforum/attach/album.php:116  die 4 true
[13-Oct-2012 13:16:44 UTC] packages/vbforum/attach/album.php:116  die 4 true
[13-Oct-2012 13:17:01 UTC] packages/vbforum/attach/album.php:116  die 4 true
[13-Oct-2012 13:17:03 UTC] packages/vbforum/attach/album.php:116  die 4 true

so hopefully that makes some more sense to you and explains my troubleshooting process here.

- - - Updated - - -

That seems kind of short to me. Is there anything else?

man, tell me about it, that's why it took me so long to figure out where the error was coming from. not even so much as a line announcement or anything, just that super vague error. see above for my exact cut & paste from the php error logs.

[Hartmut]

Are you using lightspeed cache on your server?

[fingerstand]

Are you using lightspeed cache on your server?

nope, i don't even know what that is.

[Lynne]

nope, i don't even know what that is.

Go to your admincp and what shows up at the top where it says:

Server Type xxxx
Web Server xxxx
PHP xxxx

[Oracle simsim]

I know this thread is old

it seems that vBulletin programmer forgot to remove/comment those error_log lines in this file after finishing his/her tests

upload\packages\vbforum\attach\album.php

I suffered for months from this error

[ZeroHour]

Wow this error has been annoying me for ages, well diagnosed.
Like you said Oracle, it looks like left over debugging code as some of the Die lines are commented.

Basically all the error_log(); lines are debugging lines and not actually something that should be enabled in production code I suspect.

[Art Andrews]

I have been getting these errors for a long time and finally found this thread. I edited my file just as the OP did and sure enough all my "die 4 false" errors now have the additional text on them...

Unfortunately, I don't really understand the issue here or how to resolve it. Almost all of these errors for me come from the referer: google.com. While the OP's edit made it clear where the problem lies, it doesn't answer how to resolve it. How does the album.php file need to be edited to stop these errors from occurring?

Is this actual evidence of a failure or simply some type of debugging information?

[ZeroHour]

Is this actual evidence of a failure or simply some type of debugging information?

Debugging.

[Art Andrews]

ZeroHour, if this isn't truly showing an error, is there an easy way to comment it out so we don't get this error showing up in the server log?

[Art Andrews]

I wonder if 4.2.2 will address this.