Stylevar forumicon_size doesn't work in 4.1.10

Collapse
X
 
  • Time
  • Show
Clear All
new posts
  • rughis
    Senior Member
    • Oct 2010
    • 119
    • 4.1.x

    [Forum] Stylevar forumicon_size doesn't work in 4.1.10

    Hello guys

    I migrated to 4.1.10 but I have a problem with forumicon_size stylevar. It seems not to be possible yet to resize forum icons in forum home

    Did this style var change the name, or something else?

    Thank you for your support
  • rughis
    Senior Member
    • Oct 2010
    • 119
    • 4.1.x

    #2
    Confirmed bug



    I changed the state in "petition to reopen"

    Comment

    • Ramsesx
      Senior Member
      • Aug 2005
      • 3254
      • 3.8.x

      #3
      And I confirmed it and asked CvP to have a look at it.
      .......

      Comment

      • Paul M
        Former Lead Developer
        vB.Com & vB.Org
        • Sep 2004
        • 9886

        #4
        Originally posted by rughis
        Confirmed bug
        Its not a bug, its working as designed.

        Similarly to threadbit_iconsize, forumicon_size should control just the size of the space the icon can take (i.e. the stylevar should only be adjusted if using icons with a size different from the default icons), not the actual icon size.
        In other words, its to tell vB what size your icons are, not change the size of the icons themselves.
        Baby, I was born this way

        Comment

        • Ramsesx
          Senior Member
          • Aug 2005
          • 3254
          • 3.8.x

          #5
          So, in earlier versions it was not as designed or better said a bug? If yes, it was a nice bug.
          .......

          Comment

          • rughis
            Senior Member
            • Oct 2010
            • 119
            • 4.1.x

            #6
            Originally posted by Paul M
            Its not a bug, its working as designed.






            In other words, its to tell vB what size your icons are, not change the size of the icons themselves.
            What a pity! One useful functionality that we had until 4.1.9 and that we don't have in the new version of the product

            Originally posted by Ramsesx
            So, in earlier versions it was not as designed or better said a bug? If yes, it was a nice bug.
            lol
            Last edited by rughis; Sat 14 Jan '12, 5:42am.

            Comment

            • Sebastiano Vassellatti
              Former vBulletin QA
              • Aug 2008
              • 842
              • 5.5.x

              #7
              If you want to make it behave as it did before 4.1.10, you can just add this to your additional.css:
              HTML Code:
              .forumbit_nopost .forumrow .forumicon, .forumbit_post .foruminfo .forumicon {
              	width: {vb:stylevar forumicon_size};
              }

              Comment

              • rughis
                Senior Member
                • Oct 2010
                • 119
                • 4.1.x

                #8
                Thank you really much Darkshenron, I appreciated your support

                Comment

                • Ramsesx
                  Senior Member
                  • Aug 2005
                  • 3254
                  • 3.8.x

                  #9
                  You are the greatest, Sebastiano. Thanks.
                  .......

                  Comment

                  • Paul M
                    Former Lead Developer
                    vB.Com & vB.Org
                    • Sep 2004
                    • 9886

                    #10
                    Originally posted by Ramsesx
                    So, in earlier versions it was not as designed or better said a bug? If yes, it was a nice bug.
                    Yes, it was a bug, hence it was changed.

                    Its not the first bug Ive fixed that actually did things some people wanted to keep, but thats life.

                    (JFYI, It took a while for Seb to convince me it was a bug, but I do agree with him in the end).
                    Baby, I was born this way

                    Comment

                    • Ramsesx
                      Senior Member
                      • Aug 2005
                      • 3254
                      • 3.8.x

                      #11
                      Originally posted by Paul M
                      Yes, it was a bug, hence it was changed.

                      Its not the first bug Ive fixed that actually did things some people wanted to keep, but thats life.

                      (JFYI, It took a while for Seb to convince me it was a bug, but I do agree with him in the end).
                      Yes, it seems like bug fixing is sometimes a funny job
                      .......

                      Comment

                      • rughis
                        Senior Member
                        • Oct 2010
                        • 119
                        • 4.1.x

                        #12
                        Originally posted by Paul M
                        Yes, it was a bug, hence it was changed.

                        Its not the first bug Ive fixed that actually did things some people wanted to keep, but thats life.

                        (JFYI, It took a while for Seb to convince me it was a bug, but I do agree with him in the end).
                        Yesterday after the upgrade I had to resize manually 90 icons, and I had the forum home not properly formatted for a while.

                        I think that this is not the best approach for your customers.

                        It's not a bug but it's a bad change from my perspective.

                        Comment

                        • moemoney
                          Senior Member
                          • Mar 2011
                          • 114
                          • 6.X

                          #13
                          Originally posted by Darkshenron
                          If you want to make it behave as it did before 4.1.10, you can just add this to your additional.css:
                          HTML Code:
                          .forumbit_nopost .forumrow .forumicon, .forumbit_post .foruminfo .forumicon {
                              width: {vb:stylevar forumicon_size};
                          }
                          I just updated to 4.1.10 and my Forum Icons are off sized and cover text. How should I fix this? I don't have a lot of time to fix this and prefer not to upload new icons, if I use the above script will it effect anything else and where do I put it?

                          Thanks
                          Vote to:

                          Add Bookmark Feature to Save Favorite Posts / Issue VB6-322

                          Add a Posted Videos Album" Feature / Issue VB6-285

                          Comment

                          Related Topics

                          Collapse

                          Working...