The Suspect Files check has been in the vBulletin Adminc CP A LONG time. I made a recent change to the upgrade process that now executes the suspect files check prior to the beginning of the upgrade. You never had the "problems" on previous versions because the check wasn't executed during the upgrade in the past.
BUT
(note the big but) if you had gone into the Admin CP in one of these older versions and ran the Suspect Files check then you would have seen the SAME ERRORS LISTED assuming you uploaded your files using the same FTP client that is modifying the files.
Let me say it again. The errors that you see listed at the beginning of the upgrade are the same errors that you will see if you execute "Suspect Files" within the Admin CP. Instead of searching for "unexpected contents", try "suspect files". You will surely find MANY MANY posts about the output of this function and how to resolve it. This is a diagnostic tool to help ensure your files are at the correct version that you are running. We now show them to you before you upgrade to alert you that something may be fishy with your files.
The contents of your files do no match the contents of the files at the time they were put into the zip file. Your files are being modified between the time you unzip them and the time they end up on the server. That is on your end. The reality is that your files are probably just having the carriage returns changed which doesn't affect the running of your forum. So if you never ran "Suspect Files" before then you would have never known about this issue as it has no real world impact on your forum.
If you search for "unexpected contents" you will find several people who have been HELPED by this addition to the upgrade process. They have found files that they have not been updating and files that they only partially uploaded.
The rash of "unexpected contents" that you keep referring to as an indictment of the system's failure is related to one file that we have added a bypass on.
I do think that the wording of the error needs to be fleshed out more to cover various scenarios about why the files could be showing up when it is not the version mismatch error.
BUT
(note the big but) if you had gone into the Admin CP in one of these older versions and ran the Suspect Files check then you would have seen the SAME ERRORS LISTED assuming you uploaded your files using the same FTP client that is modifying the files.
Let me say it again. The errors that you see listed at the beginning of the upgrade are the same errors that you will see if you execute "Suspect Files" within the Admin CP. Instead of searching for "unexpected contents", try "suspect files". You will surely find MANY MANY posts about the output of this function and how to resolve it. This is a diagnostic tool to help ensure your files are at the correct version that you are running. We now show them to you before you upgrade to alert you that something may be fishy with your files.
The contents of your files do no match the contents of the files at the time they were put into the zip file. Your files are being modified between the time you unzip them and the time they end up on the server. That is on your end. The reality is that your files are probably just having the carriage returns changed which doesn't affect the running of your forum. So if you never ran "Suspect Files" before then you would have never known about this issue as it has no real world impact on your forum.
If you search for "unexpected contents" you will find several people who have been HELPED by this addition to the upgrade process. They have found files that they have not been updating and files that they only partially uploaded.
The rash of "unexpected contents" that you keep referring to as an indictment of the system's failure is related to one file that we have added a bypass on.
I do think that the wording of the error needs to be fleshed out more to cover various scenarios about why the files could be showing up when it is not the version mismatch error.
Comment