4.2.3 to 4.2.5 upgrade error

[fwulfers]

The site was running on php version 5.6. I first changed the version to 7.1 and then wanted to upgrade vB to 4.2.5. There was an error about half way and the upgrade was aborted. Any thoughts on how to fix this problem and complete the upgrade?

The site seems to be running fine after the upgrade errors but looked like it nly completed halfway.

Unexpected Text:

<?xml version="1.0" encoding="windows-1252"?>
<?xml version="1.0" encoding="windows-1252"?>
<error><![CDATA[Could not find phrase 'required_field_x_missing_or_invalid'.]]></error>

[Mark.B]

Try refreshing the page.

[fwulfers]

Tried that several times but the error keeps coming back every time.

[Wayne Luke]

If you run the upgrade under PHP 5.6, does it error out?

[In Omnibus]

Is this a GoDaddy shared server by any chance? They are notorious for timing out on Step 17.

[fwulfers]

Actually, the site was on php 5.4.

Same error when switching from 7.1 to 5.6. It is at this step:

Press the button below to run the Blog Upgrade step

When I set the site to use 5.4, install/upgrade.php errors out completely:
Parse error: syntax error, unexpected '*' in public_html/includes/functions.php on line 1576

[fwulfers]

Is this a GoDaddy shared server by any chance? They are notorious for timing out on Step 17.

It's on shared hosting at https://www.040hosting.eu/ . Has been very reliable though the last 6 years.

[Paul M]

Tried that several times but the error keeps coming back every time.

Unfortunately, this may be a bug in the blog installer (upgrade) code that wasnt spotted at the time.
I only have limited access to this at work, but it lookes like Step 18 has a couple of hard coded content type ids in a query.

I'm not sure what effect that will have but it wont be good, and given you are failing on step 18, its quite likely it might be the issue.

[Mark.B]

Unfortunately, this may be a bug in the blog installer (upgrade) code that wasnt spotted at the time.
I only have limited access to this at work, but it lookes like Step 18 has a couple of hard coded content type ids in a query.

I'm not sure what effect that will have but it wont be good, and given you are failing on step 18, its quite likely it might be the issue.

Is it this bit?

            SELECT bt.userid, bt.dateline, blogtextid, ipaddress, firstblogtextid
            FROM " . TABLE_PREFIX . "blog_text bt
            JOIN " . TABLE_PREFIX . "blog bl USING (blogid)
            LEFT JOIN " . TABLE_PREFIX . "ipdata ip ON (
                bt.ipaddress = ip.ipid AND bt.blogtextid  = ip.contentid
                AND bt.userid = ip.userid AND ip.contenttypeid IN ([B][COLOR=#FF0000]29,30[/COLOR][/B])
            )
            WHERE ipid IS NULL

[Paul M]

Yes.

Basically they should be the BlogEntry & BlogComment type ids.
If you look them up in your database you could just directly replace them.


However, that section needs updating ;

Replace this ;

$records = $this->db->query_read_slave("
    SELECT bt.userid, bt.dateline, blogtextid, ipaddress, firstblogtextid
    FROM " . TABLE_PREFIX . "blog_text bt
    JOIN " . TABLE_PREFIX . "blog bl USING (blogid)
    LEFT JOIN " . TABLE_PREFIX . "ipdata ip ON (
        bt.ipaddress = ip.ipid AND bt.blogtextid  = ip.contentid
        AND bt.userid = ip.userid AND ip.contenttypeid IN (29,30)
    )
    WHERE ipid IS NULL
");

With this ;

[COLOR=#0000CD]$entrytypeid = vB_Types::instance()->getContentTypeID('vBBlog_BlogEntry');
$commenttypeid = vB_Types::instance()->getContentTypeID('vBBlog_BlogComment');[/COLOR]

$records = $this->db->query_read_slave("
    SELECT bt.userid, bt.dateline, blogtextid, ipaddress, firstblogtextid
    FROM " . TABLE_PREFIX . "blog_text bt
    JOIN " . TABLE_PREFIX . "blog bl USING (blogid)
    LEFT JOIN " . TABLE_PREFIX . "ipdata ip ON (
        bt.ipaddress = ip.ipid AND bt.blogtextid  = ip.contentid
        AND bt.userid = ip.userid AND ip.contenttypeid IN ([COLOR=#0000CD]$entrytypeid,$commenttypeid[/COLOR])
    )
    WHERE ipid IS NULL
");

The changes are in Blue.

[Mark.B]

Many thanks Paul.

fwulfers you will need to make that edit. It's in /install/includes/class_upgrade_vbblog.php around line 1957.

If you are not comfortable making the edit, please raise a support ticket at www.vbulletin.com/go/techsupport, include a link to this thread and your ftp credentials, and we will make the edit for you.

[Mark.B]

Let me get some proper instructions up for this edit:

In file:
/install/includes/class_upgrade_vbblog.php

Find this block of code, around line 1957:

$records = $this->db->query_read_slave("
    SELECT bt.userid, bt.dateline, blogtextid, ipaddress, firstblogtextid
    FROM " . TABLE_PREFIX . "blog_text bt
    JOIN " . TABLE_PREFIX . "blog bl USING (blogid)
    LEFT JOIN " . TABLE_PREFIX . "ipdata ip ON (
        bt.ipaddress = ip.ipid AND bt.blogtextid  = ip.contentid
        AND bt.userid = ip.userid AND ip.contenttypeid IN (29,30)
)
WHERE ipid IS NULL
"); 

Replace with this:

$entrytypeid = vB_Types::instance()->getContentTypeID('vBBlog_BlogEntry');
$commenttypeid = vB_Types::instance()->getContentTypeID('vBBlog_BlogComment');

$records = $this->db->query_read_slave("
    SELECT bt.userid, bt.dateline, blogtextid, ipaddress, firstblogtextid
    FROM " . TABLE_PREFIX . "blog_text bt
    JOIN " . TABLE_PREFIX . "blog bl USING (blogid)
    LEFT JOIN " . TABLE_PREFIX . "ipdata ip ON (
        bt.ipaddress = ip.ipid AND bt.blogtextid  = ip.contentid
        AND bt.userid = ip.userid AND ip.contenttypeid IN ($entrytypeid,$commenttypeid)
    )
    WHERE ipid IS NULL
"); 

[fwulfers]

I changed the code as instructed and it now stops with the following message:

(posting a screenshot as it won't format correctly)

[Mark.B]

fwulfers Have you got these two lines of code in as well? They aren't in the original file and need to be in the edited one:

$entrytypeid = vB_Types::instance()->getContentTypeID('vBBlog_BlogEntry');
$commenttypeid = vB_Types::instance()->getContentTypeID('vBBlog_BlogComment'); 

So that whole block must look like this:

$entrytypeid = vB_Types::instance()->getContentTypeID('vBBlog_BlogEntry');
$commenttypeid = vB_Types::instance()->getContentTypeID('vBBlog_BlogComment');

$records = $this->db->query_read_slave("
    SELECT bt.userid, bt.dateline, blogtextid, ipaddress, firstblogtextid
    FROM " . TABLE_PREFIX . "blog_text bt
    JOIN " . TABLE_PREFIX . "blog bl USING (blogid)
    LEFT JOIN " . TABLE_PREFIX . "ipdata ip ON (
        bt.ipaddress = ip.ipid AND bt.blogtextid  = ip.contentid
        AND bt.userid = ip.userid AND ip.contenttypeid IN ($entrytypeid,$commenttypeid)
    )
    WHERE ipid IS NULL
"); 

[fwulfers]

Yes, I included all the code: