Naming referrals

[PeterNRG]

It would be cool to actually see which members are a result of user referral actions

So instead of just having a number at a users profile, it could look like this:

Referrals: 3 (John, James, Whoever)

[Freddie Bingham]

First add an index on the referrerid field in the user table.

Then this sort of code in the getinfo section of member.php would get you on your way:

$referrers = $DB_site->query("SELECT username FROM user WHERE referrerid = '$userinfo[userid]'");
while ($referrer = $DB_site->fetch_array($referrers)) {
  if ($referrerlist) {
    $referrerlist .= ", ";
  }
  $referrerlist .= $referrer[username];
} 

[PeterNRG]

Wouldn't this be cool to have it as a standard feature?!

[Freddie Bingham]

Perhaps linking the numbers of referrers to a window that listed the names as I have 120+ referrees on my forum.

[PeterNRG]

What are we waiting for? hehe.

Make this an official new feature, and release it as a hack for now.

[PeterNRG]

Originally posted by freddie
First add an index on the referrerid field in the user table.

I'm an inexperienced mySQL user, so help me out with this. How do I do it? I have phpMyAdmin installed, can it be done with that?

[Chen]

Yes.

Click on your forum's database name on the left side.
Click on Properties for table 'user'.
Find the 'referrerid' field, and click Index on its row.

And that's it.

[PeterNRG]

Originally posted by FireFly
Click on your forum's database name on the left side.
Click on Properties for table 'user'.
Find the 'referrerid' field, and click Index on its row.
And that's it.

That was too simple to be true . Should I take any precautions with future forum upgrades because of this indexing?

freddie
Then this sort of code in the getinfo section of member.php would get you on your way:

$referrerlist displays ALL members, instead of just the referrers.

[Chen]

Open member.php.
Find

eval("\$referrals = \"".gettemplate("getinfo_referrals")."\";"); 

and above it add

$referrers = $DB_site->query("SELECT username FROM user WHERE referrerid = '$userinfo[userid]'");
while ($referrer = $DB_site->fetch_array($referrers)) {
  if ($referralslist) {
    $referralslist .= ", ";
  }
  $referralslist .= $referrer[username];
}
$referrals .= " (";
$referrals .= "$referralslist";
$referrals .= ")"; 

And you're done.

If you added the index correctly (you can see a list of indexes for a table at its end), this will work (works for me - here).
I would've release this as a hack, but it's really Freddie's code, so I won't.

[Chen]

Just in case.

[PeterNRG]

Way to go FireFly!

I feel this thread should be moved and combined here: http://www.vbulletin.com/forum/showt...threadid=25016 since it's an exellent hack, and maybe my other requests can also be taken care of.

[PeterNRG]

Kier, thanks for your efforts, but now the total number disappeared.

[Chen]

I think you should remove

$referrals = ""; 

from the top of the code Kier gave.

But maybe he put that in in purpose, I dunno.

[Freddie Bingham]

Considering that $userinfo[userid] is being returned from the getuserinfo() function, there is no need to intval() it since naughty people can't insert their own values in to. Putting the iif function in only serves to raise the code complexity without gaining any processing time but it always looks cool to do it that way. I personally don't see why you are defining variables to nothing that are not used in queries (and therefore not a security risk) unless we now have a policy of defining all variables before usage which I wasn't aware of. We also haven't a policy of freeing db results when we are done unless I forgot to attend that meeting.

[dwh]

Originally posted by freddie
Considering that $userinfo[userid] is being returned from the getuserinfo() function, there is no need to intval() it since naughty people can't insert their own values in to. Putting the iif function in only serves to raise the code complexity without gaining any processing time but it always looks cool to do it that way. I personally don't see why you are defining variables to nothing that are not used in queries (and therefore not a security risk) unless we now have a policy of defining all variables before usage which I wasn't aware of. We also haven't a policy of freeing db results when we are done unless I forgot to attend that meeting.

I'm confused, who are you replying to?

And how do you free db results, sounds like a nice trick, what does it mean?