$vbulletin no longer global in the post_display_complete hook?

Collapse
X
 
  • Time
  • Show
Clear All
new posts
  • Boofo
    Senior Member
    • Apr 2002
    • 2033
    • 4.1.x

    [Forum] $vbulletin no longer global in the post_display_complete hook?

    Did something change in 4.0.4 that made $vbulletin no longer a global variable in the post_display_complete hook? I had to add it above a mod I have in that hook before it would recognize $vbulletin->options. It worked fine without it in 4.0.3.
    vBulletin - Sometimes, I'm just like, Wow, and then I'm like, Whoa, and then I'm like, Damn.

    vBulletin.org's ol' Moderator

    I have a lifetime terrorist hunting permit - #091101

    chmod a+x /bin/laden -- Allows anyone the permission to execute /bin/laden
  • Boofo
    Senior Member
    • Apr 2002
    • 2033
    • 4.1.x

    #2
    Am I the only one who noticed this?
    vBulletin - Sometimes, I'm just like, Wow, and then I'm like, Whoa, and then I'm like, Damn.

    vBulletin.org's ol' Moderator

    I have a lifetime terrorist hunting permit - #091101

    chmod a+x /bin/laden -- Allows anyone the permission to execute /bin/laden

    Comment

    • Removed-836727
      Banned by User Request
      • Apr 2006
      • 1274

      #3
      Then use $this->registry->options[..] ...

      global $vbulletin is imho unnecessary at the most part of the methods but it'sstill used (also from the vB developers..)

      Comment

      • Boofo
        Senior Member
        • Apr 2002
        • 2033
        • 4.1.x

        #4
        Originally posted by ragtek
        Then use $this->registry->options[..] ...

        global $vbulletin is imho unnecessary at the most part of the methods but it'sstill used (also from the vB developers..)
        That was not my point. My point was that it worked fine in 4.0.3 and they changed/screwed up something in 4.0.4 to make it stop working. Breaking mods is not a good way to go.
        vBulletin - Sometimes, I'm just like, Wow, and then I'm like, Whoa, and then I'm like, Damn.

        vBulletin.org's ol' Moderator

        I have a lifetime terrorist hunting permit - #091101

        chmod a+x /bin/laden -- Allows anyone the permission to execute /bin/laden

        Comment

        • FractalizeR
          Member
          • Oct 2005
          • 82
          • 3.8.x

          #5
          They are just showing disrespect to developers. It's ok, guys, continue making changes without any notifications for developers. We still love you all, don't we?

          Comment

          • Boofo
            Senior Member
            • Apr 2002
            • 2033
            • 4.1.x

            #6
            Originally posted by FractalizeR
            They are just showing disrespect to developers. It's ok, guys, continue making changes without any notifications for developers. We still love you all, don't we?
            If they keep adding 2 bugs for every one they fix, the love will be waning very quickly I'm afraid.
            vBulletin - Sometimes, I'm just like, Wow, and then I'm like, Whoa, and then I'm like, Damn.

            vBulletin.org's ol' Moderator

            I have a lifetime terrorist hunting permit - #091101

            chmod a+x /bin/laden -- Allows anyone the permission to execute /bin/laden

            Comment

            • vB Style
              Senior Member
              • Sep 2008
              • 629
              • 5.5.x

              #7
              I have also noticed it.

              Comment

              • Boofo
                Senior Member
                • Apr 2002
                • 2033
                • 4.1.x

                #8
                Originally posted by vB Style
                I have also noticed it.
                Thank you.
                vBulletin - Sometimes, I'm just like, Wow, and then I'm like, Whoa, and then I'm like, Damn.

                vBulletin.org's ol' Moderator

                I have a lifetime terrorist hunting permit - #091101

                chmod a+x /bin/laden -- Allows anyone the permission to execute /bin/laden

                Comment

                • Removed-836727
                  Banned by User Request
                  • Apr 2006
                  • 1274

                  #9
                  Originally posted by Boofo
                  That was not my point. My point was that it worked fine in 4.0.3 and they changed/screwed up something in 4.0.4 to make it stop working. Breaking mods is not a good way to go.
                  should they leave all the legacy code because of some mods??
                  c'mon then vB will never be refactored...

                  as i wrote before, they should deliver a nice list of changes (changehistory) then the 3rd party developers could fix there add-ons fast

                  Comment

                  • Boofo
                    Senior Member
                    • Apr 2002
                    • 2033
                    • 4.1.x

                    #10
                    Well, they need to make it backward compatible until such time they decide to let us know what they are changing so we can keep up with it somehow. If this is what their refactoring is going to be like, God help us all.
                    vBulletin - Sometimes, I'm just like, Wow, and then I'm like, Whoa, and then I'm like, Damn.

                    vBulletin.org's ol' Moderator

                    I have a lifetime terrorist hunting permit - #091101

                    chmod a+x /bin/laden -- Allows anyone the permission to execute /bin/laden

                    Comment

                    widgetinstance 262 (Related Topics) skipped due to lack of content & hide_module_if_empty option.
                    Working...