md5sums version header for use by "Suspect File Versions" diagnostic

[dfidler]

I'd like a standard header that module developers can use to make use of the file version check diagnostic. Right now, it will only check the 'version' of a set of files if one of the first 10 lines of the source contain the following string/pseudo regexp:

"|| # VBulletin[^0-9]* (\d.*) -"

Obviously, it doesn't make sense for module developers to include that string because they aren't vBulletin.

Could I please suggest that add something like the following regexp to the 'version' check logic:

"^[/\|\* ]* MD5 Version: *[^0-9]* (\d.*)\w*$"

This way, any module developer can add a string to their own header files that will take advantage of the version checking code.

From reading the code, I can see that creating an md5_sum_* file will work, but they won't be able to take advantage of the actual code verision check.

Cheers,
Dave.

[David Grove]

This would be really nice.

[Scott MacVicar]

If you add the md5sum to the file it then changes the md5sum of the file, you'd have to strip it before doing the check in the future which could cause confusion if you decide to use a command line tool.

[David Grove]

Some way of checking the actual version of an addon file, instead of just checking if the checksum is the same, would be nice.

[Zachery]

I know it used to check the version number, i think it still does.

[dfidler]

If you add the md5sum to the file it then changes the md5sum of the file, you'd have to strip it before doing the check in the future which could cause confusion if you decide to use a command line tool.

But the md5sum of the md5_sum file doesn't matter; just don't put it in there and it won't get picked up as a failure by the diags (at least they don't on my 3.7.3.1 install).

@Zachery - As for checking the version of the file it will do that, but per my original message, it will only do that for files that have a header that contain the text

|| # VBulletin ..... x.y.z -

The diags code strips out the x.y.z and compares that to the results of the line:

$md5_sum_versions['someproduct-name']

Which is why you set that variable at the bottom of the md5sum. And the version check really only exists so that the vB diags can say

"This file is from the wrong version you dinglewitz!" (I'm paraphrasing there).

Anyways, the code to implement this request is 2 lines of code so I'm hoping it's really easy to include (documentation, on the other hand, will take more effort)

Cheers,
Dave.

[dfidler]

Hmm... this is strange; I was sure that I'd already uploaded this but here is the shell script that I'm using to generate my md5_sums files now (attached).

Usage is pretty simple:

gen_vb_md5.sh <root directory of your uninstalled code> <output md5 file>

It uses $VERSION and $PRODUCT to fill in the version info. The attached one is defaults $PRODUCT to vbgallery for but that's easy enough to change. I was thinking of screwing around with getopt but decided against it for reasons of personal sanity.

Note: I've already filed Bugs or Enhancement requests with Photopost/vBGallery and vBA CMPS to have them include md5_sum files in future releases.

I hope they do it.

Cheers,
Dave.


[edit] Yes, I know the shell script is a dirty hack; but it was fast. [/edit]

[edit]2008-11-04 1200 GMT - updated the attachment; fixed a bug in it.[/edit]