Useless query when searching for posts Issue Tools
issueid=27575 Sat 11th Apr '09 1:23pm
New Member
Useless query when searching for posts

search.php, line 2619:

PHP Code:
        $dotthreads fetch_dot_threads_array($ids); 
This is a useless query if you search for posts and dotthreads is enabled.
The function queries for replys in threads, which have the same id as the posts the user searched.

You could change this line to
PHP Code:
if ($search['showposts'])
{
    
$dotthreads fetch_dot_threads_array($ids);

(When searching for posts, $ids contains the postids, not the threadids)

I hope you are able to understand it ;)

Regards Surviver
Issue Details
Project vBulletin
Category Searching
Status Fixed (Closed)
Priority 9
Affected Version 3.8.2
Fixed Version 3.8.3
Users able to reproduce bug 2
Users unable to reproduce bug 0
Assigned Users Mike Sullivan
Tags (none)

Thu 16th Apr '09 7:38am
Former vBulletin Developer
 
It should be "if (!$search['showposts'])" but otherwise you're right.
Reply
Reply