404.php phpBB threadid bug Issue Tools
issueid=23378 Tue 16th Oct '07 6:26am
vBulletin Team
404.php phpBB threadid bug

Code:
                $action = 'thread';
                if( preg_match("/&/", $_SERVER['REQUEST_URI']) )
                {
                    $old_id = intval(substr(substr($_SERVER['REQUEST_URI'], 2), 0,  strpos(substr($_SERVER['REQUEST_URI'], 2), '&')));
                    $sql = "SELECT threadid FROM {$tableprefix}thread WHERE importthreadid={$old_id}";
                }
This code (from line 135, /tools/404.php) to fetch the $old_id doesn't work, as the REQUEST_URI includes the filename.

Thus if this were the URL:
http://www.foo.com/forums/viewtopic....er=asc&start=0

it would return:
iewtopic.php?t=4371

This in turn would be intval()'d to 0.


I'd guess the same thing happens for post links.
Issue Details
Project ImpEx
Category Miss parsed content
Status Won't Fix
Priority 10 - Lowest
Affected Version 1.86
Fixed Version (none)
Users able to reproduce bug 0
Users unable to reproduce bug 0
Assigned Users Jerry
Tags (none)

Wed 14th Nov '07 4:22pm
ImpEx Developer
 
I'm thinking moving this to vb.org as it's not going to be supported officially as ImpEx is, it was released as an example for others to work on.
Reply
Reply