We've switched to a new bug tracking system!
Project Tools has been set to read-only. Please use the new tracker going forward.
bigger spacer before second reply button Issue Tools
issueid=22750 Fri 27th Jul '07 5:51am
Senior Member
bigger spacer before second reply button

This has been there for years, I noticed it long time ago. I decided to report it today.



It does look bad, doesn't it?
Issue Details
Project vBulletin
Category Styling
Status Fixed (Closed)
Priority 5 - Medium
Affected Version 3.6.8
Fixed Version 3.7.0 Beta 1
Users able to reproduce bug 1
Users unable to reproduce bug 0
Assigned Users Kier
Tags (none)

Thu 9th Aug '07 10:46am
Former Lead Developer, vBulletin
 
Fixed on the dev board on both showthread and usernote templates.

However, I would hardly class this as a medium priority bug - this should have been set as the lowest possible priority, as it has no effect on functionality and an almost invisible effect on layout.

Please use the priority control sensibly or we will restrict its use to developers only.
Reply
Thu 9th Aug '07 10:52am
Senior Member
 
Thanks for pointing this out.

I think I'll be able to select the appropriate priority next time. :)
Reply
This petition for a change to Unconfirmed was rejected
Fri 12th Oct '07 11:22am
Senior Member
 
I can see you made a fix here, you increased the spacer after the first button - that's not what I was expecting.

I was expecting a decrease of spacer before second reply button, which will be perfect for consistency with new thread buttons.

I belive there is some conditionals to check if it's the last post before going to another page.

You can use this conditionals, and bypass postbit_wrapper, and use standard spacer, and it should work perfectly.
This petition for a change to Confirmed was rejected
Sat 13th Oct '07 4:57pm
Senior Member
 
I also think that a decrease of spacer before second reply button is a best solution.
Tue 16th Oct '07 7:15am
Former Lead Developer, vBulletin
 
I have made a further change for 3.7. They all have a 3px margin now.
Reply
Tue 16th Oct '07 12:14pm
Senior Member
 
Just for my information, will 3.6.9 have the current fix, or will you leave them as is?
Reply
Wed 17th Oct '07 8:04am
Senior Member
 
By the way:
Status Closed (Fixed)
Fixed Version (none)
Reply
This petition for a change to Confirmed was rejected
Mon 31st Mar '08 1:42pm
Senior Member
 
I belive this bug haven't been fixed in this issue nor in this one: http://www.vbulletin.com/forum/proje...?issueid=23570 (nothing changed then before)

I think the fix to this will be by applying this change in postbit_wrapper template.


<!-- post #$post[postid] -->
<if condition="$show['spacer']">
$spacer_open
<div id="edit$post[postid]" style="padding:0px 0px <if condition="!$post['islastshown']">$stylevar[cellpadding]px<else />3px</if> 0px">
</if>
$postbit
<if condition="$show['spacer']">
</div>
$spacer_close
</if>
<!-- / post #$post[postid] -->
Mon 31st Mar '08 4:29pm
Senior Member
 
Can someone post which one's are the ones i have to change so that i can fix it manually?
Reply
Mon 31st Mar '08 4:42pm
Senior Member
 
I think mine is correct though you should wait a developer confirming that.
Reply
Mon 31st Mar '08 5:07pm
Former Senior Developer, vBulletin
 
As noted, this bug is fixed for 3.7. 3.6.9 only has a partial fix.
Reply
Mon 31st Mar '08 5:17pm
Senior Member
 
I don't see a fix for it here on these forums.
Reply
Mon 31st Mar '08 9:39pm
Senior Member
 
For the spaces between 'Reply' button and postbit, this is fixed. Look at the code:

Code:
<table cellpadding="0" cellspacing="0" border="0" width="100%" style="margin-bottom:3px">
<tr valign="top">
    
        <td class="smallfont"><a href="newreply.php?do=newreply&amp;noquote=1&amp;p=xxx" rel="nofollow"><img src="images/buttons/reply.gif" alt="Reply" border="0" /></a></td>
    
    
</tr>
</table>

// postbits....

<table cellpadding="0" cellspacing="0" border="0" width="100%" style="margin-top:-3px">
<tr valign="top">
    
        <td class="smallfont"><a href="newreply.php?do=newreply&amp;noquote=1&amp;p=xxx" rel="nofollow"><img src="images/buttons/reply.gif" alt="Reply" border="0" /></a></td>
    
    
</tr>

</table>
Look at the margin-bottom and margin-top for that.

For Project Tools, it have a margin of 6px instead of -3px, and this is not the place to discuss about PT.
Reply
This petition for a change to Confirmed was rejected
Thu 17th Apr '08 6:53am
Senior Member
 
I belive the fix was implemented here for a day or two then went back to the old look.
Thu 17th Apr '08 9:50am
Mez Mez is offline
Senior Member
 
Mazinger, I cannot confirm that this bug is in existance on vBulletin. The only place where the spacing for the "Post Reply" button is inconsistent is here, in Project tools. (and as such, a bug should be reported against project tools)

Other than that, It seems that everything is in order.

If you are still having issues, can you post screenshots etc to help us determine what the exact issue is?
Reply
Thu 17th Apr '08 1:50pm
Senior Member
 
Simply, the spacer before the second reply button (showthread) was reduced by the release candidate 1 or two, then the fix was cancelled (as it went back to classic one)
Reply
Reply