Unconfirmed Bug: vB2.x (affects 3.x upgrades) - Forums always ..

[Paul]

Hi,

I had thought I had previously reported this issue pre-2.3.0, although I cannot find the thread on these forums. I am just upgrading to the latest 2.3.3 and have noticed that the problem is still there. I had fixed this on 6/29/2003.

Forums are given a default styleset in vB2. While this may be a tiny issue with vB2, when upgrading to vB3 you'll run into issues as it will affect how forums are displayed and template information is ported over.

In admin/forum.php:


// Bug fix: Style id set by default, 2003-06-29, Paul
/*
makechoosercode("Custom style set for this forum","styleset","style",1);
*/
makechoosercode("Custom style set for this forum","styleset","style",-1,"No custom style");
// End bug fix: Style id set by default


Changes like the above will need to be made. There are multiple instances, but I won't bother posting them all.

Might I also recommend that the references to UBB being a "b**stard" be removed from the bbimport.php code?

Best wishes,
Paul

[Steve Machol]

Moved to vB2 Bugs forum for a Dev to look at.

[Scott MacVicar]

vB3 bug that should be addressed within the upgrade script.

$query[] = "UPDATE forum SET styleid = 0";
$explain[] = "Resetting styleids to default board style";

from upgrade1.php

[Freddie Bingham]

Moved to vB2 Bugs forum for a Dev to look at.
About this. We either need to stop moving uncomfirmed threads into the bugs forum or change the description of this forum to not mislead people into believing that every thread in here is a confirmed bug, as that is far from the case these days.

[Paul]

But I'm not asking for a forum specific style set in vb2. It is a vb2 bug as well, is it not? The code clearly assigns style set 1.

vB3 was processing it quite correctly.

[Steve Machol]

What do you suggest then? When these things sit in the Troubleshooting forums they are generally overlooked by the Devs. Paul indicated this was still a problem with 2.3.3. Therefore I felt it was worth having a Dev look at it. If it's not a Bug then perhaps you can say so and explain why.

In the future, I will change the title to 'Unconfirmed Bug'. But I do think it's important for someone to look at these.

[Freddie Bingham]

"Unconfirmed Bug" is acceptable.

[Scott MacVicar]

But I'm not asking for a forum specific style set in vb2. It is a vb2 bug as well, is it not? The code clearly assigns style set 1.

vB3 was processing it quite correctly.
Paul the default style in vB2 is style 1 though and vB2 should handle it correctly.

The problem was if the user had style 4 selected as his prefered style and forum X had the default style picked and wanted it to override the user style it wouldn't do so.

So i'm not quite sure what your saying the bug is?

[Paul]

Setting the style to -1 removed the issues I was experiencing. If this can be helpful to others, great.

This has nothing to do with vB3 other than I only first noticed it when upgrading to vB3 because of how it creates styles and how vB2 screwed up in the first place. This seems very clear to me.

I haven't tried upgrading to the newest version of vB3 because I can't download it yet. If it is still a problem in vB3-Cartoon, I throw up another one of these unconfirmed bug reports.