PDA

View Full Version : Allow quotes to be quoted



Andy
Sat 15th Nov '03, 7:44pm
The [ Quote] tag is not quotable.

For example if I put in a quote like this...


this is an example

if someone replies w/ quote my quote will be erased. Its not good to have part of the original message lost if your quoting a reply.

FASherman
Sat 15th Nov '03, 8:27pm
The [ Quote] tag is not quotable.

For example if I put in a quote like this...



if someone replies w/ quote my quote will be erased. Its not good to have part of the original message lost if your quoting a reply.
I don't see that as a bad thing. I would rather avoid wasting database space with N levels of quotes.

Andy
Sun 16th Nov '03, 2:31am
I'm not as concerned with disk space as I am with people being able to follow a reply.

The reply w/ quote feature is one of the most important functions in a forum sotware like vBulletin. Sometimes people will use the [QUOTE] tag in a reply many times. To have these quotes lost when it is quoted is a problem.

The problem lies with having more then one quote per post. The software doesn't know how to handle that.

Marco
Sun 16th Nov '03, 7:19am
Quote 1
Quote 2
Quote 3It can handle nested quotes just fine, just for some very odd reason they're stripped off when you use Reply w/Quote.

merk
Sun 16th Nov '03, 7:23am
It can handle nested quotes just fine, just for some very odd reason they're stripped off when you use Reply w/Quote.
They are stripped off using the regex_ bbcode functions.

I cant see why its really that big of a problem for general uses (sometimes its much better that they are stripped), but i can sometimes see a need for it. Though, having the "Topic Review" below the new post window, and being able to modify the post yourself adding quote tags, that its not a problem at all.

I would like to see an vBulletin Option to set the depth of quote tags that get stripped. Mike is probably the only one that could work out a über-regex-function that could do it! :)

cirisme
Sun 16th Nov '03, 11:01am
It strips it so that they don't get too nested. At least that's what happened in vb2. Let's find out:








Innermost quote
Edit: okay vb2 stopped parsing after about 2 or 3 layers. The new regexes must have fixed that :)

Andy
Sun 16th Nov '03, 3:53pm
Where can I locate the regex_ bbcode functions?

Mike Sullivan
Sun 16th Nov '03, 3:55pm
$pagetext = trim(strip_quotes($pagetext)); In newreply.php. Remove the call to strip_quotes there.

BenSjoberg
Sun 16th Nov '03, 4:21pm
vb2 stopped parsing after about 2 or 3 layers. The new regexes must have fixed that :)

It was three, check it out: http://forums.wdwinsider.net/showthread.php?s=&threadid=1254

Andy
Sun 16th Nov '03, 5:16pm
I think the best solution for nested quotes is to simply not allow them. If a user manually puts in a second quote tag, when they click on submit, if more then one quote tag is found, then an error message pops up and informs them that this is not allowed. Same thing for PM's. They are far too difficult to read with all the nested quotes. Trim the last quote like it is done in the thread posts.

Simplicity is the mother of invention.

merk
Sun 16th Nov '03, 6:25pm
How would you tell the difference between a quote that was already there, and one that was entered by the user?

Andy
Sun 16th Nov '03, 6:58pm
How would you tell the difference between a quote that was already there, and one that was entered by the user?

You don't. The software simply would not allow more then one quote per reply to be submitted. Its up to the user to erase the one they manually entered.

Andy
Mon 17th Nov '03, 1:00am
$pagetext = trim(strip_quotes($pagetext)); In newreply.php. Remove the call to strip_quotes there.

Hi Mike,

It would be nice to know where I could add that line in the PM script. That way the PM's would be the same as thread posts and you would only see the last reply quoted.

merk
Mon 17th Nov '03, 1:21am
You don't. The software simply would not allow more then one quote per reply to be submitted. Its up to the user to erase the one they manually entered.
I cant possibly see a reason to do this? :confused:

feldon23
Mon 17th Nov '03, 1:38am
That limitation would be extremely annoying. I assume such a thing would be optional?

Sometimes I wonder what kind of forums people are running that their users have to be babysat. :eek: :(

FASherman
Mon 17th Nov '03, 1:40am
I can't see any use for the whole idea of nesting quotes period. To follow the discussion? Hello... Thats what the threaded view is for.

Heck, think about it. Even if you picked an arbitrary limit of nesting five levels deep, for every "thread in a post" that reaches that level, you've stored the information in the database 6 times; Once in the original post and 5 more times in 5 levels of nested quotes.

The threaded view provides the capability you're looking for without code change and without the additional DB overhead.

Andy
Mon 17th Nov '03, 5:08am
I cant possibly see a reason to do this? :confused:

Because if a user manually puts in a a quote like this:


I manually used quote tags to create this

then if you were to reply to this post you will see the information in the quote will be trimmed. The information is incomplete. So if the user was not allowed to manually use the quote tag the problem would be eliminated.

Andy
Mon 17th Nov '03, 5:18am
I can't see any use for the whole idea of nesting quotes period. To follow the discussion? Hello... Thats what the threaded view is for.


I agree with you that nesting quotes more then one level becomes very difficult to read and that is why a manually entered quote gets trimmed. Here in lies the problem. A person manually enters a quote and now you cannot reply w/ quote to it without loosing the information inside that manually entered quote.

You mentioned using threaded views, I really dislike threaded views and will not use a forum that uses them.

Mike Sullivan
Mon 17th Nov '03, 12:04pm
Hi Mike,

It would be nice to know where I could add that line in the PM script. That way the PM's would be the same as thread posts and you would only see the last reply quoted.
I'm confused as what you want now seems to be the opposite of what you wanted before...

Simply add &stripquote=1 to your postbit template's reply button and PMs will behave like replies. Of course we had it that way and people complained so we switched it back to the old style.

Andy
Mon 17th Nov '03, 1:04pm
I'm confused as what you want now seems to be the opposite of what you wanted before...

Simply add &stripquote=1 to your postbit template's reply button and PMs will behave like replies. Of course we had it that way and people complained so we switched it back to the old style.

It is opposite of what I originally wanted, but I didn't consider PM's at that time.

Now that I have looked at the problem a little furthur I think it is best to only have one "Quote" per post. It becomes very difficult to read otherwise.

Back to changing the PM's to the way they were in previous versions of vBulletin. Where excatly do I add "&stripquote=1" in the postbit template?

Thank you for all your help Mike. :)

Mike Sullivan
Mon 17th Nov '03, 1:20pm
Back to changing the PM's to the way they were in previous versions of vBulletin. Where excatly do I add "&stripquote=1" in the postbit template? To the link to add a new reply; it's just a variable. That &stripquote=1 part will show up on showthread too, but it won't have an effect anywhere but on PMs.

Marco
Mon 17th Nov '03, 1:21pm
I think the best solution for nested quotes is to simply not allow them. If a user manually puts in a second quote tag, when they click on submit, if more then one quote tag is found, then an error message pops up and informs them that this is not allowed. Same thing for PM's. They are far too difficult to read with all the nested quotes. Trim the last quote like it is done in the thread posts.

Simplicity is the mother of invention.
That may be your opinion, but if something like this would ever be done I would prefer it be made optional. I think nested quotes are quite handy, and so do my users. :)

Andy
Mon 17th Nov '03, 1:28pm
To the link to add a new reply; it's just a variable. That &stripquote=1 part will show up on showthread too, but it won't have an effect anywhere but on PMs.

I'm sorry Mike, I have searched the postbit template and I just can't figure out where you mean. Could you describe excatly where to put it. Perhaps you could indicate put it under this line or something like that.

Thanks again.

Mike Sullivan
Mon 17th Nov '03, 1:52pm
I'm sorry Mike, I have searched the postbit template and I just can't figure out where you mean. Could you describe excatly where to put it. Perhaps you could indicate put it under this line or something like that.

Thanks again.

<if condition="$post[replylink]"><a href="$post[replylink]&stripquote=1"><img src="$stylevar[imgdir_button]/reply_small.gif" alt="Reply With Quote" border="0" width="55" height="17" /></a></if>
Add what's in red/bold to postbit.

Andy
Mon 17th Nov '03, 2:08pm
That worked perfect! I was getting really tired of manually deleteing previous quotes in PM's. Now PM's work like I like them.

Thank you for your time and detailed instructions Mike. I'm slowly learning html and php with your help. :)

jilly
Wed 10th Dec '03, 2:55am
DISABLING THE AUTOMATED QUOTING FEATURE?

How can I disable the automatcic quoting of each post in a reply?

jilly
Wed 10th Dec '03, 2:56am
I am not sure what they look like, and what the diferrences are....

Darth Cow
Wed 10th Dec '03, 3:41am
I am not sure what they look like, and what the diferrences are....
This is off-topic, but you can just click on the "Display Modes" button at the top of each thread and click on a mode to see what it looks like.