[fixed/design issue] vB2.x: Merging "nextnewest" and "nextoldest" threads.

[Paul]

Hi,

When merging threads, vBulletin 2.x will simply try to pull a postid or threadid from the submitted URL. However, two specific links (forumurl/showthread.php?thread=threadid&goto=nextnewest/nextoldest) will not properly identify the correct thread to be merged and instead use the threadid in the link itself (instead of the threadid referenced).

Since these links are relative, meaning as threads are deleted or merged the nextoldest/newest value will change, the merging utility should recognize this link and display an error that an invalid link was specified.

I have not tested this in vB3.

Best wishes,
Paul

[Paul]

For vB2.x only:

In postings.php, Find: // get other threadid

BELOW that line, INSERT the following:
// Bug fix: Wrong thread when merging nextoldest/newest threads : http://www.vbulletin.com/forum/showthread.php?p=532907#post532907
if (stristr($mergethreadurl,"goto=next")) {
// do invalid url
eval("standarderror(\"".gettemplate("error_mergebadurl")."\");");
exit;
}
// End bug fix: Wrong thread when merging nextoldest/newest threads

I still have not motivated myself to test vB3. My guess is that it contains the same issue.