Mods can't undelete threads nor delete them with reason, regardless of setting

[Stadler]

All of our mods have the 'Can Manage Threads' Permission in their forums, but they can't delete a thread with reason, using Admin Options -> Delete Thread / Posts. And they can't even undelete the threads or alter the reason.

However, they are able to delete a thread with reason by deleting the first post.

Is this a bug or did I miss anything?

[Mike Sullivan]

Check to see if they have Can Delete/Remove Posts permissions (not sure if that's the correct wording).

[Stadler]

Yes, Can Delete Posts has been set to yes

[Stadler]

mmh ... I think I got it:

can_moderate($threadinfo['forumid'], 'canremoveposts') is for physically removing of posts and it's being required there (using AND). Well, there are more issues for that, but I haven't check all of them.

[Mike Sullivan]

Where's 'there'? In postings.php it's being AND'ed against the negation which should have the correct behavior.

And what error are they getting? No permission?

[Stadler]

I was referring to the THREADADMIN Template. I thought I've mentioned this.

Well, they get the permissions, but the necessary fields won't be displayed.

I think, I've fixed it now. Shall I attach it here, so you can check the differences?

[Mike Sullivan]

I think, I've fixed it now. Shall I attach it here, so you can check the differences?Sure.

[Stadler]

OK, here it is :)

You should allow XML-Files to be attached here, so I don't need to zip them in order to attach them.

[Mike Sullivan]

The change is similar. Here's the version of the conditional that will be in beta 4:

<if condition="can_moderate($threadinfo['forumid'], 'candeleteposts') OR can_moderate($threadinfo['forumid'], 'canremoveposts')">
<tr valign="top">
<td class="alt2"><b>Deletion Type:</b></td>
<td class="alt2"><span class="smallfont">
<if condition="can_moderate($threadinfo['forumid'], 'candeleteposts')"><label for="rb_deletetype_1"><input type="radio" name="deletetype" value="1" id="rb_deletetype_1" checked="checked" />Leave &quot;Deleted&quot; Message</label> &nbsp;&nbsp;(<input type="checkbox" name="keepattachments" value="1" id="cb_keepattachments" /><label for="cb_keepattachments">Keep Attachments</label>)<br /></if>
<if condition="can_moderate($threadinfo['forumid'], 'canremoveposts')"><label for="rb_deletetype_2"><input type="radio" name="deletetype" value="2" id="rb_deletetype_2" />Physically Remove</label></if>
</span></td>
</tr>
<tr>
<td class="alt1"><b>Deletion Reason:</b></td>
<td class="alt1"><input type="text" name="deletereason" size="50" /></td>
</tr>
</if>

[Stadler]

mmh. Did you check
DELETE THREAD, DELETE POSTS and EDIT THREAD in that template? I've applied changes to all three of these files. Though I haven't tested the DELETE POSTS-Section.

[Stadler]

Uhm, did you?

Sorry for bumping ...

[Mike Sullivan]

Sorry -- I missed your last post. I've now checked all the templates for references to 'canremoveposts' and they seem correct.

[Stadler]

mmh ... thats one template ... I've meant, did you check them in THAT template, still referring to the THREADADMIN-template. But I think, you've meant that. If not: Sorry, for being not clear enough.

Well, I'll recheck, when Beta 4 is out. :)

[Mike Sullivan]

I checked that template and the rest of the templates. :)

Find in templates is a very helpful feature.