[Fixed] Small Bug w/ AIM screennames

[vBadvanced]

This small bug was pointed out by a friend of mine here (http://www.vbulletin.org/forum/showthread.php?s=&threadid=52011) on vb.org. It seems that whenever a user has an AIM username like "kill the duck", once you click on the option to send them an IM the IM window will only contain the name as "kill". A small fix I applied to my board and posted on vb.org seems to fix the problem though. If you look in member.php for:
$aim = htmlspecialchars( $aim );

And right above that add:
$aim=str_replace(' ',"+",$aim);

That seems to fix the problem. Of course the places that it displays the name it now shows something like "kill+the+duck", but it wouldn't be hard to change it slightly so both the name that displays and the name in the window looks right.
Anyways, just thought I'd point that out to one of the devs. ;)

[Steve Machol]

Can anyone confirm this? I don't use AIM myself.

[vBadvanced]

If you'll refer to the link to vB.org in the first post you'll see a few people have confirmed the bug, and that my rough fix works. ;)

[Steve Machol]

People at vb.org hack their forums. I'm hoping someone with an unhacked forum can confirm this.

[jibious]

steve, i use AIM. this is a problem. in vB's code, there is no addition for spaces in AIM screen names. it will just cut off the code at the first word of the username. AIM allows for formatting of the username, therefore, most people will add spaces in their screen names.

anyhow, you do need to add in the '+' for spaces. this has nothing to do with if someone has their board hacked or not - read AIM documentation.

http://ftp.newaol.com/aimgen/106729/WebAdvantageKit.pdf

AIM URL Formatting Guidelines
For the commands below, anything in brackets [] is optional. User entered information is shown
in bolded italics. Typically, as is shown in the examples, the screen name, chat room, etc.
information is placed after the equals sign in the command. The commands are NOT case
sensitive, but you cannot have spaces anywhere in the command. If you want to include a space
(for example, within a message), use “+” to separate the words. Chat rooms cannot include nonalphanumeric characters and cannot have a number for the first character of the name.

[jibious]

*bump*

wanna move it to the devs? atleast for vb3?

[Steve Machol]

Moved to Bugs for a Dev to confirm.

[Littlebit]

Kill the duck? lol ....errr sorry.

[Stadler]

I'd prefer the following fix, though, it's a bit more work. But it 'looks better' and uses Valid Links:

In /forum/member.php FIND $aim = htmlspecialchars( $aim );REPLACE IT WITH $aimname = htmlspecialchars( $aim );
$aim = urlencode( $aim );In /forum/admin/functions.php FIND if ($post[aim]!="") {ADD AFTER THAT: $userinfo[aim]=urlencode($userinfo[aim]);
Go to your Admin-CP -> Templates -> Modify -> Expand List -> aimmessage [Edit]

Then find<center>
<b>Send a message to <br>$aim</b></normalfont>and replace it with<center>
<b>Send a message to <br>$aimname</b></normalfont>

[jibious]

Kill the duck? lol ....errr sorry.

first thing that came to mind ;)

[Brad.loo]

Thanks for the fix Stadler, I made one myself some time ago (when I was using 2.2.2), it was the same method as plur's but yours is much better.

Honestly I thought this was fixed in the stock code long ago, guess I forgot to re-check it after so many upgrade.

[Scott MacVicar]

fixed now.