[Fixed] 2.3.0 -- Password not trim()'ed for white spaces, incorrect error sent

[Paul]

Moved into vb2.2.9 bugs and marked as fixed, however issues remain in 2.3.0. See http://www.vbulletin.com/forum/showthread.php?postid=435560#post435560

[Paul]

*ba-ump*

[Paul]

Text copied in the hopes that someone pays attention to this. :)

In 2.3.0, if a user forgets to submit a new password, vBulletin will display error_wrongpassword. This is misleading to the user. They should be informed that they forgot to enter a new password, not that their old password is incorrect.

Secondly, the input for $newpassword is not being trim()'ed for any spaces that may have been entered before or after the password. I think it's safe to say that in most cases, spaces prefixing or trailing the entered password are accidentally entered and not intended to be a part of the user's password. This probably classifies as a new bug, but was originally suggested as part of the fix in this thread to the original report.

Incidentally, $password is trim()'ed upon new user registration. $newpassword should follow the same rule.

Best wishes,
Paul

[Paul]

*bump*

[Steve Machol]

Moved to Bugs for a Dev to check.

[Scott MacVicar]

trimming done, i dont wish to add a new error message for this.

The thing is they have entered the wrong password for the new value, the value can't be empty.