[FIXED (in 2.3.0 final) ] sending PM to buddies who are invisible

[scotsmist]

as an admin, I can see everyone online, even those who are invisible.

in my user_cp, my buddy_list shows my invisible buddies as online (when they are actually online of course), but when I click on send PM to buddies, the invisible buddies don't now show up as online.

No biggie, not looking for a fix, just a heads up - is it just me, or is it like that for you too.

[nuno]

Tested and working fine here.

[scotsmist]

thanks

[Kier]

nuno - Do you mean that you have tested it and you can confirm the bug, or that you have tested it and can't reproduce the error?

[nuno]

Tested on vB 2.2.9 and i can't reproduce the error.

[Kier]

Thanks

[scotsmist]

I just checked this on 2 other sites, I am an admin on, and there both the same.

buddy is online, but when I select PM buddies (and the block with all my buddies appears, with tickboxes to select whom I wish to PM), the ones that are invisible, are saying offline.

I'm using vb2.2.9, no hacks on these sites.

Its no biggie, like I said, just wondering of it was just me.

Thanks.

[scotsmist]

its the private2.php file

here's a screenshot, FlyingScotsman, is online, but invisible, yet is showing as offline

[nuno]

its the private2.php file

here's a screenshot, FlyingScotsman, is online, but invisible, yet is showing as offline
hmmm
try this
edit private2.php and replace

if ($user[sessionuserid]!=0 && $user[lastactivity]>$datecut && !$user[invisible]) {

with

if ($user[sessionuserid]!=0 && $user[lastactivity]>$datecut && !$user[invisible] or $bbuserinfo['usergroupid'] == 6) {

Tell me if that fixes it.

[WetWired]

Aren't you missing some parenthesis on that last line?

[nuno]

Aren't you missing some parenthesis on that last line?
No.

Just for the record, i first tested this with two Administrators, both invisible, and i can't reproduce this error.
But if you test it with a non admin, then this is in fact a tiny bug.

PS: Be aware that this is not a official fix, use it at your own risk. Wait for a Dev to fix it.

[scotsmist]

hmmm
try this
edit private2.php and replace

if ($user[sessionuserid]!=0 && $user[lastactivity]>$datecut && !$user[invisible]) {

with

if ($user[sessionuserid]!=0 && $user[lastactivity]>$datecut && !$user[invisible] or $bbuserinfo['usergroupid'] == 6) {

Tell me if that fixes it.

Now all my buddies show as online, when I click, Send PM to buddies, even those who aren't :)

[scotsmist]

No.

Just for the record, i first tested this with two Administrators, both invisible, and i can't reproduce this error.
But if you test it with a non admin, then this is in fact a tiny bug.

PS: Be aware that this is not a official fix, use it at your own risk. Wait for a Dev to fix it.

Its not a problem thanks, as I know from other places, which of my buddies are online anyway (as I'm admin), I just happened to notice this, the other night, when I tried to send several of them the same message at the same time.
Thanks for your time :)

[nuno]

Its not a problem thanks, as I know from other places, which of my buddies are online anyway (as I'm admin), I just happened to notice this, the other night, when I tried to send several of them the same message at the same time.
Thanks for your time :)
Try this

if ($user[lastactivity] > $datecut and (!$user[invisible] or $bbuserinfo[usergroupid] == 6) and $user[lastvisit] != $user[lastactivity]) {


This is my last try. :p
Then again, be aware that this is not a official fix, use it at your own risk. Wait for a Dev to fix it.

[scotsmist]

yeah that worked :)

thanks for taking the time

[Kier]

This is a bug affecting a whole lot of the vB2 private messaging system.

I've now fixed it, and the fix will be included in the code in the members' area soon. I'll add to my announcement when it's available.