PDA

View Full Version : [not really a bug] Problem with [quote] and Quick Reply



Chen
Tue 21st Jan '03, 4:30am
Here's the thing, type this into the Quick Reply form below:

This is a quote
Then try posting.

Wayne Luke
Tue 21st Jan '03, 1:03pm
Interesting little bug there...

Kier
Tue 21st Jan '03, 1:41pm
Are you referring to this?

The message you have entered is too short. Please lengthen your message to at least 3 characters.

Wayne Luke
Tue 21st Jan '03, 1:42pm
That is what I was referring to. Especially since "This is a quote" is definately more than 3 characters.

Kier
Tue 21st Jan '03, 1:50pm
In the current system, characters within [quote] tags are not counted towards the postminchars value, and nor are bbcode tags, so Chen's post above (without the Then try posting. words would actually count as zero characters. This is designed to prevent users posting enormous quotes followed by 'LOL' or something like that.

I'll stick in an admin option to allow the admin to turn off this behaviour though.

vBR
Tue 21st Jan '03, 5:00pm
but quotes are counted in the max length so if you quote a really long post then you have little room left for your reply

Chen
Tue 21st Jan '03, 5:49pm
Originally posted by Kier
Are you referring to this?

The message you have entered is too short. Please lengthen your message to at least 3 characters. I'm talking about the JavaScript notice actually, when using Quick Reply:

Your message must be at least 3 characters long.
I don't see why it should filter [quotes] when using Quick Reply since it obviously has to a "true" quote and not just a repost of another post.

Kier
Tue 21st Jan '03, 6:13pm
Originally posted by vBR
but quotes are counted in the max length so if you quote a really long post then you have little room left for your reply Maximum chars checks against the total length of the message, including bbcode tags and stuff in [quote] tags.

Minimum chars checks against the length of your message, excluding any bbcode tags or text in [quote] tags.

Chen
Wed 22nd Jan '03, 9:35am
Originally posted by Chen
I'm talking about the JavaScript notice actually, when using Quick Reply:

I don't see why it should filter [quotes] when using Quick Reply since it obviously has to a "true" quote and not just a repost of another post. I still think this a bug, read the quoted post, but...

inetd
Wed 22nd Jan '03, 10:01am
Minimum chars checks against the length of your message, excluding any bbcode tags or text in [quote] tags. In my board I'm often post only quoted message. Without my comments. I'm consent with FireFly.

XYPHEN
Sat 25th Jan '03, 2:56pm
TEST

So whats the bug exactly? when you use CODE it gives a quote something in vb3.0?

vBR
Wed 29th Jan '03, 8:45am
Originally posted by Kier
Maximum chars checks against the total length of the message, including bbcode tags and stuff in [quote] tags.

Minimum chars checks against the length of your message, excluding any bbcode tags or text in [quote] tags. Counting quotes towards the maximum character count can cauce problems too. See: 64164

Kier
Wed 29th Jan '03, 9:31am
Postmaxchars serves a different purpose to postminchars.

Postminchars is designed to make sure that your users post meaningful messages rather than one-word answers to questions etc.

On the other hand, postmaxchars is more of a database management tool, to prevent the post table from becoming absolutely enormous...

See what I'm getting at?

Chen
Wed 29th Jan '03, 9:46am
I don't think you completely understand the problem... :) When using newreply.php, then yes, quotes should be stripped before checking the minimum characters. But when using quick reply there's absolutely no reason to do this since quotes can't be added there automatically by vBulletin, so why strip (what's meant to be) genuine content?

I'm not against stripping the quotes, I'm just against doing that on the quick reply.