PDA

View Full Version : [FIXED][3] interesting observation with version 2.2.9 and body tag


sifuhall
Fri 17th Jan '03, 2:41pm
Try this...

In the admin panel->styles

under page layout for the body tag enter

<body>


and nothing else.


save your changes and view the html in your forum.

The body tag is:

<body bgcolor="#666696" text="#000000" id="all" leftmargin="10" topmargin="10" marginwidth="10" marginheight="10" link="#000020" vlink="#000020" alink="#000020">
Steve Machol
Fri 17th Jan '03, 3:30pm
Confirmed. I'm sure there's a reason for this but we'll need a Developer to tell us what that is.
filburt1
Fri 17th Jan '03, 3:36pm
Originally posted by Steve Machol
Confirmed. I'm sure there's a reason for this but we'll need a Developer to tell us what that is. It's not a bug, <body> is a replacement.
Stadler
Fri 17th Jan '03, 3:38pm
Originally posted by Steve Machol
Confirmed. I'm sure there's a reason for this but we'll need a Developer to tell us what that is. Check the replacements ;)

[Edit:]Two minutes too slow :o:p
sifuhall
Fri 17th Jan '03, 3:38pm
Originally posted by filburt1
It's not a bug, <body> is a replacement. I don't quite think you are fully understanding this filburt1.

The body tag is being replaced, but not with what is in the replacement section.
Steve Machol
Fri 17th Jan '03, 3:39pm
Yes, but after making this change the replacement tag shows correctly, i.e., <body>, yet the HTML source shows what sifuhall posted.
sifuhall
Fri 17th Jan '03, 3:39pm
Originally posted by Stadler
Check the replacements ;)

[Edit:]Two minutes too slow :o:p Replacements are OK. I can post a screen shot if you like.
sifuhall
Fri 17th Jan '03, 3:40pm
Originally posted by Steve Machol
Yes, but after making this change the replacement tag shows correctly, i.e., <body>, yet the HTML source shows what sifuhall posted. Thanks Steve.

It appears I'm having trouble getting anyone other than you to understand the problem.
Stadler
Fri 17th Jan '03, 3:48pm
Originally posted by sifuhall
Thanks Steve.

It appears I'm having trouble getting anyone other than you to understand the problem. Sorry, my bad. I thought you're talking about the templates.

Well, you're right. It appears, that <body> is replaced with <body> in your Admin-CP, but not in the HTML-Source.
sifuhall
Fri 17th Jan '03, 3:53pm
Here's an interesting update. This only happens when the replacement tag is <body>.

If I include a dummy tag like <body id="forumbody"> it is replaced correctly.
Stadler
Fri 17th Jan '03, 4:41pm
This only happens, if you set up a replacement to be replaced with itself. Then its being replaced with the default replacement. This works with all replacements. e. g. try to replace {imagesfolder} with {imagesfolder} and it's being replaced with images.
sifuhall
Fri 17th Jan '03, 4:43pm
Originally posted by Stadler
This only happens, if you set up a replacement to be replaced with itself. Then its being replaced with the default replacement. This works with all replacements. e. g. try to replace {imagesfolder} with {imagesfolder} and it's being replaced with images. Interesting.

In my case I specified all of the body info in the css and did not want any information in the body tag itself.
Stadler
Fri 17th Jan '03, 5:00pm
I think I got it.

Check the function 'dovars' in admin/functions.php:

It fetches all replacements from your custom replacementset AND from the default.

So it always performs the custom replacements first and then the default replacements. e. g. it replaces <body> with <body> and then <body> with the default replacement, meaning, it's being replaced two times.
Chen
Sat 18th Jan '03, 2:57am
Originally posted by sifuhall
Interesting.

In my case I specified all of the body info in the css and did not want any information in the body tag itself. Enter " " (a space) in that box, and see what you get.
Kier
Fri 31st Jan '03, 8:59am
This was a problem with a double-replacement happening. It is now fixed and will be included in vBulletin 2.2.10
Kier
Fri 31st Jan '03, 9:00am
As a side note, as the replacements are not happening twice now, page display in vB2.2.10 should be marginally faster than 2.2.9 :)
DWZ
Fri 31st Jan '03, 10:10am
v2.2.10, sends a shiver down my spine...
Steve Machol
Fri 31st Jan '03, 12:19pm
Originally posted by DWZ
v2.2.10, sends a shiver down my spine... You really need a girlfriend! ;)