[FIXED][3] Edit Post and Indexing Words

[Logician]

Hey there,

* Post a new thread OR reply in any forum and use an uncommon word in it. Eg. logician
* If you search the word logician after you sent the post, this post is found successfully in searching. No problems upto now.
* Now edit this very post and replace your word with something else, or just delete the word from the post.
* Search the word again and surprisingly the search still finds this word, even if your word is not there anymore.

I confirmed this behaviour in both vb3.x (this post (http://www.vbulletin.com/forum/showthread.php?goto=postid&postid=398028)) and vb2.x (this post (http://www.vbulletin.org/forum/showthread.php?s=&postid=341627#post341627)). Both posts referred had once included word logician, do not include it now, but if you search the word, both posts are still returned.

It happens because the unindexpost command in the editpost.php is located incorrectly. This function should be called before the post is updated, however it's called after the update which makes it useless in its recent location. So changing its place in editpost.php, fixes the problem..

After the fix don't forget to update search index to correct minor problems in the old posts..

Regards,

[Steve Machol]

Moved to Bugs for a Developer to look at.

[Paul]

Originally posted by Logician
This function should be called before the post is updated, however it's called after the update which makes it useless in its recent location. So changing its place in editpost.php, fixes the problem..


Good work, Logician. As a temporary workaround, in editpost.php, find:unindexpost($postid);

Edit that line so it appears like this: /* unindexpost($postid); */

Find the following:$DB_site->query("UPDATE post SET title='".addslashes(htmlspecialchars($title))."',pagetext='".addslashes($message)."',allowsmilie='$allowsmilie',showsignature='$signa ture',iconid='$iconid'$editedbysql$attachmentsql WHERE postid='$postid'");

Insert ABOVE:unindexpost($postid);