[FIXED] Trying to save email/password with blank password, email

[Darth Cow]

When I don't enter a password, I get this error message:


You have entered an invalid username or password. Please press the back button, enter the correct details and try again. Don't forget that the password is case sensitive. Forgotten your password? Click here (http://www.vbulletin.com/forum/login.php?s=&do=lostpw)!

You have used out of 5 login attempts. After all 5 have been used, you will be unable to login for 15 minutes.

Except it doesn't say have many attempts out of 5 you've actually used, and you're still logged on (you just didn't enter a confirmation password) :p.

When I try to leave my email blank it also gives me an error, even though both the edit password and edit email fields are marked "optional".

[Darth Cow]

Here's an even wierder thing... an if conditional is showing up in the source code of that error page you get when you don't enter a password.


<if condition="!=''">You have used out of 5 login attempts. After all 5 have been used, you will be unable to login for 15 minutes.</if>

It showed up around the quote I entered above with if in capitals - <IF condition="!-''"> ... </IF> (I edited it out).

[Cary]

Confirmed.

[Chen]

Originally posted by Darth Cow
Here's an even wierder thing... an if conditional is showing up in the source code of that error page you get when you don't enter a password.



It showed up around the quote I entered above with if in capitals - <IF condition="!-''"> ... </IF> (I edited it out). People shouldn't be using <IF> but <if>, because <IF> isn't parsed. :)

[Darth Cow]

Originally posted by Chen
People shouldn't be using <IF> but <if>, because <IF> isn't parsed. :) It wasn't uppercase in the source code of the page itself (see the quoted code). Only when it got unknowingly to me pasted into the WYSIWYG and parsed, did the ifs become capital.

[Freddie Bingham]

Originally posted by Darth Cow
When I don't enter a password, I get this error message:



Except it doesn't say have many attempts out of 5 you've actually used, and you're still logged on (you just didn't enter a confirmation password) :p.

When I try to leave my email blank it also gives me an error, even though both the edit password and edit email fields are marked "optional". There are a few places in the system where you can login that don't refer to login.php. These places need to be updated to do that so that the strikes system works properly.

As for seeing the conditional, error messages are not stored as templates any more and hence do not support conditionals. It shouldn't be there.

[Darth Cow]

Thanks for your response, but the broken conditional is still there :).

[Freddie Bingham]

Originally posted by Darth Cow
Thanks for your response, but the broken conditional is still there :). I haven't removed it yet.

[Scott MacVicar]

Originally posted by Darth Cow
When I don't enter a password, I get this error message:



Except it doesn't say have many attempts out of 5 you've actually used, and you're still logged on (you just didn't enter a confirmation password) :p.

When I try to leave my email blank it also gives me an error, even though both the edit password and edit email fields are marked "optional". its because phrases aren't parsed for template conditionals.