[FIXED][3] Can't view subscribed threads from UserCP in 2.2.9

[tamarian]

In member2.php, I commented out this line


$perpage = intval($perpage);

in


$perpage = intval($perpage);
if (!isset($perpage) or $perpage>200) { //max of 200, per several users requests
$perpage=$maxthreads;
}


And subscribed threads are back. Need a cleaner solution though..

[Steve Machol]

Bug confirmed. Moving to Bugs forum.

[MUG]

Originally posted by tamarian
In member2.php, I commented out this line


$perpage = intval($perpage);

in


$perpage = intval($perpage);
if (!isset($perpage) or $perpage>200) { //max of 200, per several users requests
$perpage=$maxthreads;
}


And subscribed threads are back. Need a cleaner solution though.. After:
$perpage = intval($perpage);Add:
if($perpage==0) $perpage=15; //or whatever number you want

[Stadler]

Try the following Fix:

OPEN

member2.php

FIND
if (!isset($perpage) or $perpage>200) { //max of 200, per several users requestsREPLACE WITH
if (!$perpage or $perpage>200) { //max of 200, per several users requestsThat should fix it

[Paul]

Originally posted by Stadler
Try the following Fix:

OPEN

member2.php

FIND
if (!isset($perpage) or $perpage>200) { //max of 200, per several users requestsREPLACE WITH
if (!$perpage or $perpage>200) { //max of 200, per several users requestsThat should fix it This was a XSS bug fix from 2.2.8 wasn't it? :: searches ::...

[Scott MacVicar]

Originally posted by LoveShack
This was a XSS bug fix from 2.2.8 wasn't it? :: searches ::... indeed it was, the $pagenumber check should have been changed to incorporate a check for 0.

[Ian]

Originally posted by Stadler
Try the following Fix:

OPEN

member2.php

FIND
if (!isset($perpage) or $perpage>200) { //max of 200, per several users requestsREPLACE WITH
if (!$perpage or $perpage>200) { //max of 200, per several users requestsThat should fix itI tried it, it indeed does fix it.

[Scott MacVicar]

Originally posted by Ian
I tried it, it indeed does fix it. We will be going for


if ($perpage==0 or $perpage>200) {

[Chris M]

Originally posted by Scott MacVicar
We will be going for


if ($perpage==0 or $perpage>200) { So what is the Official Fix?

Satan

[Scott MacVicar]

Originally posted by hellsatan
So what is the Official Fix?

Satan what i posted is the official fix

[Erwin]

Originally posted by Scott MacVicar
what i posted is the official fix Just confirming - remove the intval line, and change ! to =0 - is that right?

[Chen]

Originally posted by Erwin
Just confirming - remove the intval line, and change ! to =0 - is that right? No, keep the intval() and just change it to $perpage == 0.

[DWZ]

augh! too confusing!

can somone post a "find this code in x.php" and "replace it with this code" type post...

[Chen]

Originally posted by DWZ
augh! too confusing!

can somone post a "find this code in x.php" and "replace it with this code" type post... Find this code in member2.php:

if (!isset($perpage) or $perpage>200) {
And replace it with:

if ($perpage == 0 or $perpage > 200) {

[CeleronXT]

Originally posted by Chen
Find this code in member2.php:

if (!isset($perpage) or $perpage>200) {
And replace it with:

if ($perpage == 0 or $perpage > 200) { Thanks for the fix.

Applied.

[DWZ]

great, thanks for that Chen :)

[Erwin]

Yeah, thanks. :)

[Chris M]

Thanks Chen:)

Satan

[Kohhal]

Muchos grassyass :D