[fixed] private forums showing up in forumjump on failed admincp/modcp login

[Matze0007]

Hiho =)

If someone trys to access the admin/mod cp using a valid admin/mod username but wrong password, all private forums which the admin/mod has access to will appear in the forumjump box on the wrong password page.

To fix this open admin/sessions.php and find:
eval("standarderror(\"".gettemplate("error_wrongpassword")."\");");

Above it add:
$bbuserinfo['usergroupid'] = 1;

[filburt1]

Confirmed, and interesting forums here :D

[filburt1]

One more problem: they generate 404 errors because they try to go to mod/forumdisplay.php.

[Mystics]

Thx @Matze0007 for the Info, bug is confirmed in my test forums.

But I would use this fix:

Open admin/sessions.php and find:eval("standarderror(\"".gettemplate("error_wrongpassword")."\");");and add above it:$useforumjump = 0;With this, the forumjump box doesn't show up at all, and therefore the 404-Bug is also 'fixed' ;)

(I don't think you ever will need the forumjump menu at this location!)

Mystics

[Scott MacVicar]

well you shouldnt be getting a forumjump full stop there, i'm adding

$useforumjump = 0;

above

eval("standarderror(\"".gettemplate("error_wrongpassword")."\");");

in sessions.php as there is no point of having it

[Scott MacVicar]

lol i forgot to push submit before i went out, I see mystics has already posted the fix.

I've commited this fix to cvs.

[Erwin]

Thanks for the fix. What an interesting bug! :)

[DWZ]

Thanks, worked great :)

[Chris M]

:)

Satan

[DWZ]

Originally posted by PPN
I've commited this fix to cvs. Just a thought - but shouldn't someone put [fixed] in the topic?

[Paul]

Originally posted by DWZ
Just a thought - but shouldn't someone put [fixed] in the topic?

Make it more interesting--put [fixed in vb4.1] in the topic ;) See how many people pee themselves ;)

[Scott MacVicar]

putting fixed in the title is just a reminder to a dev so they dont try and fix it twice :)

anyway done now