[fixed] Forums if OFF - still appears on showgroups

[Marco]

When a forums' status is set to INACTIVE, and you set a mod for it, it still shows up on showgroups.php as a forum modded by that moderator. Is that really designed behaviour? IMO, when a forum is OFF, it shouldn't show up anywhere... :)

[Wayne Luke]

As the administrator, you will always see the forum normally whether it was INACTIVE or not. This is by design.

[Marco]

Yes but it shows up for normal registered users as well.

[Marco]

*bump*

[Scott MacVicar]

open up showgroups.php


$users = $DB_site->query("
SELECT
$locationfieldselect forum.forumid, forum.title AS forumtitle,
user.username, user.userid, user.invisible, user.receivepm, user.lastactivity, user.lastvisit
FROM moderator
LEFT JOIN user ON (user.userid = moderator.userid)
LEFT JOIN forum ON (forum.forumid = moderator.forumid)
LEFT JOIN userfield ON (userfield.userid = user.userid)
ORDER BY user.username ASC, forum.displayorder ASC
");

becomes


$users = $DB_site->query("
SELECT
$locationfieldselect forum.forumid, forum.title AS forumtitle,
user.username, user.userid, user.invisible, user.receivepm, user.lastactivity, user.lastvisit
FROM moderator
LEFT JOIN user ON (user.userid = moderator.userid)
LEFT JOIN forum ON (forum.forumid = moderator.forumid)
LEFT JOIN userfield ON (userfield.userid = user.userid)
WHERE forum.active = 1
ORDER BY user.username ASC, forum.displayorder ASC
");

I'm sure this was intended behaviour though so I'll not move it to the bugs forum yet until i've checked.

[Freddie Bingham]

Originally posted by Scott MacVicar
I'm sure this was intended behaviour though so I'll not move it to the bugs forum yet until i've checked. No, it's not intended.

[Marco]

I hate to break it but this didn't fix it...