[fixed] 2.2.8 editing templates

[hypedave]

When I attempt to move 1 template to a new template set, the template does not move to the new template set at all.

[John]

Could you explain in a little more detail what you're trying to do please, I don't totally follow. Thanks!

[lordzypher]

I think he is having the same problem I am .. When I try to create new style sets, Replacements, or templates and use them they will not work.. What I have done personally is try to create a new style set useing the Admin Control Panel and clicking <Add Style>
then selecting a title (x-box) and create new replacement set and create new template set but when I click save and go back to look at the properties it shows both as default and if I make any changes to the style set (x-box) it changes the Default style, replacement and templates... Whats up?

[hypedave]

Originally posted by lordzypher
I think he is having the same problem I am .. When I try to create new style sets, Replacements, or templates and use them they will not work.. What I have done personally is try to create a new style set useing the Admin Control Panel and clicking <Add Style>
then selecting a title (x-box) and create new replacement set and create new template set but when I click save and go back to look at the properties it shows both as default and if I make any changes to the style set (x-box) it changes the Default style, replacement and templates... Whats up?

thankyou, someone has explained it, sorry if I have a problem sometimes explaining myself

[Mark0380]

Just testing out v2.2.8 and am encountering similar problems here.

Two things:

1) If I create a new style, then choose 'Create new replacement/template' sets respectively, the new style is created, but the sets are not, and the 'Default' sets are used instead.

2) If I then create the new replacement/template sets manually, and then try to set my new style to use them manually (under the 'Properties' page), the style immediately reverts back to using the 'Default' replacement/template sets after saving the changes.

(FYI - This is from a fresh install of the latest version of vB)

[Scott MacVicar]

has this happened with versions before 2.2.8 or has it just started happening?

[Mark0380]

Don't think so, Scott. I'm about to go back and try a fresh install of 2.2.7 just to see.

Did I pick a good day to start re-desiging my website, or what? :)

[Mark0380]

...and the answer is: no, the problem isn't there in v2.2.7.

[hypedave]

Originally posted by PPN
has this happened with versions before 2.2.8 or has it just started happening?

For me its just in 2.2.8, I did a fresh install of vb 2.2.8 RC rather than upgrade from 2.2.7. Since the templates on my vb 2.2.7 live board have been customized, I decided I would try to customize them on vb 2.2.8. so what I did was I imported my vb 2.2.7 template in, so I could move the 78 customized templates over to the default 2.2.8 template. but crap to make a long story short, I have attached a screen.


Default

Mindsights
birthday_greeting_email

When I select edit birthday_greeting_email im given the option to change the template name, Template set drop down box to move to another template set or edit the template itself. I choose to move it from the Mindsights template set to the Default template set. when I choose to move it to the default template set and click submit, it acts as if its moving it to the default template set, but when I go to the default template set its not there. hope you at least somewhat understood that .

thanks

[Scott MacVicar]

I just checked its a conflict with global.php as theres both using the same variable name to stop a possible security hole with the replacement set and template set ids.

I've updated it in CVS and use the file attached. I dont know when John will update the zip in the members area.

UPDATED AGAIN AT 23:33 BST on 25/09/02

[Da`Nacho]

I'm having similar problems as above, even after replacing style.php with the changed version posted by PPN.

Example:

I have 2 template sets, Candidforums Heat and Candidforums Shiver.

Upon editing a template in Shiver and saving it, the template is saved in the Heat template set and the Shiver templateset either reverts or doesn't change at all. Once during all this I've even had TWO of the same template show up in Heat. (I had 2 forumhomes!)

I've also noticed that when I go to 'Edit' on the Shiver template the name that pops up is Heat, and when viewing the source of the page it appears to be trying to edit templatesetid 3 (yes, thats Heat... but I want to edit Shiver which is 1 if I'm not mistaken)

So I'm pretty much stuck with the ability to edit only one template, and haphazzardly at that. Looking into the database, all appears to be in order. The style, templateset, and replacementset tables all have the appropriate pointers relating to each other.

:confused:

Is anyone else still having trouble or is it just moi?

[hypedave]

yep im still having the same problem

[small_jim_mine]

yep same here

template is copied to the default template and on the other its gone

so i have both on the default



if you delete this here from /admin/global.php

----

$style=$DB_site->query_first("SELECT templatesetid,replacementsetid,userselect FROM style WHERE styleid='".addslashes($styleid)."' or styleid=1 ORDER BY styleid DESC");
//get template set and replacement set details
$templatesetid=$style['templatesetid'];
$replacementsetid=$style['replacementsetid'];

----

and use the style.php from the 228RC.zip it will work until someone fixed that really

[DexterII]

When I try to delete a template set or replacement set it always keeps deleting my default set and not the set I choose. Even though it's specifying the template set in the variables it keeps deleting templeset 1

[Da`Nacho]

Originally posted by small_jim_mine
yep same here

template is copied to the default template and on the other its gone

so i have both on the default



if you delete this here from /admin/global.php

----

$style=$DB_site->query_first("SELECT templatesetid,replacementsetid,userselect FROM style WHERE styleid='".addslashes($styleid)."' or styleid=1 ORDER BY styleid DESC");
//get template set and replacement set details
$templatesetid=$style['templatesetid'];
$replacementsetid=$style['replacementsetid'];

----

and use the style.php from the 228RC.zip it will work until someone fixed that really


Thanks, that worked brilliantly! :)

[Scott MacVicar]

do not remove that code it is to prevent a security hole upload my attached style.php

[small_jim_mine]

yes really nice your updated style.php

but if you read after your last post there are several bugs leading to your modification


it adds templates to the default template and not to others you created, test it yourself even if you edit a template, this template will be moved to the default template

and you can't add it on custom templates

[Da`Nacho]

Originally posted by PPN
do not remove that code it is to prevent a security hole upload my attached style.php

READ: YOUR ATTACHED STYLE.PHP DOESN'T WORK!

I'd much rather workaround a potential security hole (that is quite obscure anyway) until the template problem can be fixed, rather than deal with losing BOTH of my styles due to a problem with the revised 2.2.8 code.

No offense intended...

[lordzypher]

All of the above.. I have observed every problem the members above are facing with no resolution thus far. I hope someone can get this fixed soon :rolleyes:

[Scott MacVicar]

yeah i know i was on the fone when i posted

and i've just realised its going to cause problems with replacements.php and template.php as well

Will look for another solution.

[Scott MacVicar]

There is a easier way to sort the SQL injection errors, i suggest just not working on your styles / templates or replacements till tommorow when the zip will get updated.

If your really desperate then remove the code from global.php

The fix will basically involve removing the code from global.php and then fixing all the possible errors in functions.php.

[hypedave]

when will the actual zip file be updated ?

[Scott MacVicar]

when john gets on in the morning as he's the only one who can do it.

[lordzypher]

No attachment specified. If you followed a valid link, please notify the webmaster

[TheSonic]

I also have the problems with the templates.

I just gone crazy - but then it's an bug, i am "happy" because i am not an idiot (for this time :D ) and my Database isn't crashed.

Hope thats fixed soon, for now i force the users to use one Template.

[lordzypher]

Can someone please re-attach the files ? I was unable to get them Thanks...

[hypedave]

I think the attached file was removed because its against vbulletins policy to post full files.

[Scott MacVicar]

john has updated the zip just upload

admin/global.php
admin/functions.php
admin/style.php
admin/template.php
admin/replacement.php

and it should all be working fine.

[Hellburn]

admin/style.php
admin/template.php
admin/replacement.php

this files a the same. I can only found changes at:

admin/global.php
admin/functions.php

its this right?


Greats
Hellburn

[Scott MacVicar]

yep thats the only real changes but i was mentioning the rest in case anyone decided to try and edit them.

[Hellburn]

Why i can not found changes between 2.2.7 and 2.2.8 at the session.php?

sessions.php; improved handling of aol users


thank you

[Yuber]

I was having the same problem with 2.2.8 RC. I could even edit any template for styles other than Default. But now with the final 2.2.8 version being releaed, I don't have that problem anymore.