[fixed] Dissapearing EMail button?

[MGSteve]

Hi, someone has just pointed out to me that my forum (2.27) lacks the email button!

When you view a thread, no users have an email button beneath their posts, nor do they in the members list?

This was there when I had 2.2.6, but I moved servers and changed to 2.27 at the same time, so I'm not sure what could have caused this!

Any ideas ppl? I did look through the options to see if there is an option I've turned off by mistake, but couldn't find any..

My forums are at http://forums.mg-rover.org

Cheers for any help.

[MGSteve]

no ideas as to why my email buttons have vanished then?

[Scott MacVicar]

The users could have turned 'Hide Email Address?' within the options in the user cp to yes and this will stop that from being displayed.

[MGSteve]

Yeah, but this is not the case.. Here's how you can replicate it.

Goto the whos-online page. Here people are listed, with an email button if they haven't unchecked the option. Choose someone who has an email button next to their name, click on their name to view their profile, then click on "search for all posts by this user" then click on the first post you find and hey presto - no email button on his or anyone else's posts.

See - its weird!

[Scott MacVicar]

In your admin options.

'User and registration options' -> 'Display email addresses' you have that set to yes?

[MGSteve]

Oh FFS! I had checked that and could have sworn it was on!

That's it, that was turned off - however, it has raised a question - should you be able to see the email button on the Online list if this was turned off (which it was).

Thanks and sorry for the (what turned out to be) daft question.

[freaky]

so this is not a bug right? just setup error? If it is not a bug maybe you guys should delete it :)

[MGSteve]

Originally posted by Fazle
so this is not a bug right? just setup error? If it is not a bug maybe you guys should delete it :)

Whilst true, the original post was a setup error, it did raise a question -



should you be able to see the email button on the Online list if the option is turned off in the setup.

[freaky]

Originally posted by MGSteve
Whilst true, the original post was a setup error, it did raise a question -

I see :)
I am anxiously waiting for a stable 2.x release since my 2.2.6 has crap load of hacks and I dont want to go through releases unless they are pretty stable :)

[Scott MacVicar]

its not a serious bug or has too many issues but yes we declared it a bug as its not doing what the admin intended.

in online.php

find


if ($enableemail) {

replace with


if ($enableemail and $displayemails) {

Note: this appears twice so replace it twice

[tubedogg]

Originally posted by Fazle
I see :)
I am anxiously waiting for a stable 2.x release since my 2.2.6 has crap load of hacks and I dont want to go through releases unless they are pretty stable :) 2.2.8 is stable...as was 2.2.7...

[freaky]

Originally posted by tubedogg
2.2.8 is stable...as was 2.2.7...
they were buggy stable, thats what I meant. I know bugs will always be there, I guess I am waiting for a final 2.x with a short bug list. 2.2.8 might be the one.

[tubedogg]

There will always be bugs in software. Anyone who tells you otherwise is lying.

[freaky]

Originally posted by Fazle
I know bugs will always be there.......

Yes I know and you guys do a good job taking care of them :)

[Stadler]

Hi,

the fix is incomplete. You forgot the following:

in online.php

find (usually Lines 40-42)


function show($userinfo) {
global $thread, $post, $forum, $event, $gotforum, $hideprivateforums, $bbuserinfo, $timeformat, $enableemail, $enablepms, $bbtitle, $usergroupdef, $numberguests;
switch($userinfo[activity]) {

replace with


function show($userinfo) {
global $thread, $post, $forum, $event, $gotforum, $hideprivateforums, $bbuserinfo, $timeformat, $enableemail, $displayemails, $enablepms, $bbtitle, $usergroupdef, $numberguests;
switch($userinfo[activity]) {Just added Lines 40+42, to make it clearer, where to apply the fix. The fix is the same. {Stadler}

[Chris M]

Thanks:)

Satan

[Paul]

Originally posted by PPN
its not a serious bug or has too many issues but yes we declared it a bug as its not doing what the admin intended.

in online.php

find
if ($enableemail) {

replace with
if ($enableemail and $displayemails) {

Note: this appears twice so replace it twice Note for those upgrading: This was not fixed in 2.2.9 final. The code is only partially modified and does not check if $enableemail is set. Apply Stadler's fix above.

Best wishes,
Paul

[Scott MacVicar]

Originally posted by LoveShack
Note for those upgrading: This was not fixed in 2.2.9 final. The code is only partially modified and does not check if $enableemail is set. Apply Stadler's fix above.

Best wishes,
Paul freddie changed this before final release on this logic


$enablemail is only used to determine if emailing is allowed, it does not control whether or not the email icon is displayed, only $displayemails and $usernifo[showemail] do that.