[fixed] Go To First Unread Post...Bug?

[Dark_Wizard]

On my board my users are complaining that when you are viewing a thread and click on the arrow (Go to first unread post) sometimes it works and other times it doesn't. Can anyone else verify this or have this problem? Thx!

[Steve Machol]

Offhand I'd say that any problem that is intermittent and cannot be reproduced faithfully is not a bug. More likely this is a problem with their browser or Internet connection.

[Dark_Wizard]

Steve, I have verified this with all of my users and even hade them change some settings in IE. You can try it on my board if you'd like to verify this. Even I get this as well and have it set to check for newer pages on every visit to the page in IE.

[Steve Machol]

But you also said the problem is intermittent, right? My point is that to call something a bug it needs to be reproducible and consistent.

I really don't know what to suggest when the problem is intermittent like this.

[kippesp]

Do these forums (here at www.vbulletin.com) have the various bug patches applied from the bugs forum?

[Steve Machol]

Originally posted by kippesp
Do these forums (here at www.vbulletin.com) have the various bug patches applied from the bugs forum? No. This forum is running the straight 2.2.7.

[kippesp]

I had this happening here. I thought it may have been related to the "Mark this Forum Read - 2.2.7 Bug" so not being able to duplicate it anymore thought the patch may be here.

Clicking the mark forum as read also didn't solve the problem last night. The view was still incorrect.

I noticed it on the "Mark this Forum Read - 2.2.7 Bug," which is a multi-page thread. Instead of going to the latest post, it simply went to the first page--the bottom of the first page. Since I was on a different computer, I can't see my history. Wonder if the postid was correct, but the page info was wrong.

Anyway, tried to duplicated it again but couldn't. BTW, I don't think the "place to test things out" forum should up post counts.

[Scott MacVicar]

Its to do with the cookie timeout setting, its based on your last visit.

If say you read post 5 in a thread and then go do something else and head back to the forum and see there is now 4 new posts you will still go to post 5 as the first unread post is based on your last visit to the forums and not indivual thread views as IE would have issues with the size of the cookies.

[Dark_Wizard]

Originally posted by PPN
Its to do with the cookie timeout setting, its based on your last visit.

If say you read post 5 in a thread and then go do something else and head back to the forum and see there is now 4 new posts you will still go to post 5 as the first unread post is based on your last visit to the forums and not indivual thread views as IE would have issues with the size of the cookies.

So your saying this is not a bug...hmmm....
btw...this is happening more frequently on my board now.

[kippesp]

I think I was confused because of the "[Fixed] Mark this Forum Read - 2.2.7 Bug" bug. I'd hit mark this forum read, get returned to the forum, and then think the down arrow "didn't work" when in actuality it was the marking that was (or is) buggy.

[Scott MacVicar]

Its not a bug its more of a design issue, you'd have to wait 15 minutes for your cookie to timeout and the columns would be updated, then when you went it would go to the next post. But you are browsing the board so its based on the time before wether you read the post or not.

No cookies are used at all for that feature.

[kippesp]

Originally posted by PPN
No cookies are used at all for that feature. Incorrect. Note in particular:
// check to see if forum has cookie set for last reading time...ie forum marked as read
if (($fview = get_bbarraycookie('forumview', $foruminfo['forumid'])) >$bbuserinfo['lastvisit']) {
$bbuserinfo['lastvisit']=$fview;
}
and then
} elseif ($thread[lastpost]>$bbuserinfo[lastvisit]) {
if (get_bbarraycookie('threadview', $thread['threadid']) < $thread['lastpost']) {
$thread[newoldhot]='new'.$thread[newoldhot];
}
eval("\$thread[gotonew] = \"".gettemplate('forumdisplay_gotonew')."\";");
}
Dark_Wizard, I would certainly recommend fixing the "[Fixed] Mark this Forum Read - 2.2.7 Bug" bug before going much further in this thread.

[Dark_Wizard]

Originally posted by kippesp
Incorrect. Note in particular:
// check to see if forum has cookie set for last reading time...ie forum marked as read
if (($fview = get_bbarraycookie('forumview', $foruminfo['forumid'])) >$bbuserinfo['lastvisit']) {
$bbuserinfo['lastvisit']=$fview;
}
and then
} elseif ($thread[lastpost]>$bbuserinfo[lastvisit]) {
if (get_bbarraycookie('threadview', $thread['threadid']) < $thread['lastpost']) {
$thread[newoldhot]='new'.$thread[newoldhot];
}
eval("\$thread[gotonew] = \"".gettemplate('forumdisplay_gotonew')."\";");
}
Dark_Wizard, I would certainly recommend fixing the "[Fixed] Mark this Forum Read - 2.2.7 Bug" bug before going much further in this thread.

I have applied that patch but the problem still exists. :(

[Scott MacVicar]

To fix your problems when clicking go to first new post on the forumdisplay page change the following

/showthread.php

find

if ($goto=="newpost") {
$threadid = verifyid("thread",$threadid);

below it add


if (($tview = get_bbarraycookie('threadview', $threadid)) > $bbuserinfo['lastvisit']) {
$bbuserinfo['lastvisit'] = $tview;
}

Unforunately you can't sort clicking go to first unread post on the showthread page as the threadview cookie is set as soon as you load the page, so if the same code was applied there it would always take you to the last post and not the first unread one.

[Paul]

PPN,

Is your last post the fix for this issue? I find it a bit confusing when so much code is in a thread ;)

Thanks,
Paul

[Scott MacVicar]

yes it is

[Paul]

Thanks PPN :D