[fixed] Mark this Forum Read - 2.2.7 Bug

[adrianchew]

Just upgraded to 2.2.7...

Mark this Forum Read

does not work right. It will make the forum read on the forum home display, but messages in the forum will not be marked as read, as they were previously.

[filburt1]

Verified on my 2.2.7 board

[adrianchew]

I tried looking into the forumdisplay.php code, it seems the way markread works for forums has changed, but someone forgot to check something else?

Tried clearing cookies and doing it - still no go. :(

[Tannerman]

As I mentioned in another thread, I'm also seeing this problem in two installations.

[Erwin]

Works fine on my site with 2.2.7

[MUG]

Originally posted by Erwin
Works fine on my site with 2.2.7 Ditto

[filburt1]

Make sure the person making the post and the person marking everything as read are two different users.

[adrianchew]

Actually don't read all messages in a forum here on this forum... and try marking it read - you'll soon see. ;)

[Tannerman]

Originally posted by adrianchew
Actually don't read all messages in a forum here on this forum... and try marking it read - you'll soon see. ;)

Correct. The bug is still there. Any official word on this from the Jelsoft folks? :)

[Steve Machol]

FWIW I haven't been able to duplicate this yet. I can't test it on these forums because I need to be able to easily view *all* new messages. I will try to test this when there are fewer new messages for me to go through.

[Erwin]

Goodness... you are absolutely correct. It is a BUG. I came back to look it up because my members are complaining about the same thing. I take back what I said in my previous post - this is a bug alright. When you click Mark Forum Read in a forum, the posts remain unread, although in the list of forums the forum is indeed marked read.

I am going home after work to check it out to make sure it's not a hack causing the problem, but this was working fine before the upgrade.

[filburt1]

My board is unhacked and has been since 2.2.6 when I rebuilt it and I get the same problem, so its unlikely a hack is the problem.

[Paul J]

It's working fine on my board.

[filburt1]

Are you sure you did this, Paul? It seems to work properly if you're the one that makes the post because it is marked read as soon as you post it.

Originally posted by filburt1
Make sure the person making the post and the person marking everything as read are two different users.

[Paul J]

Yeah, I believe so...there were a few threads that weren't posted by me with responses that I hadn't made. I left them as unread and then marked all forums as read and all the post indicators were marked as read when i returned to the board.

[Scott MacVicar]

Confirmed and fixed using the following

// check to see if forum has cookie set for last reading time...ie forum marked as read
if (($fview = get_bbarraycookie('forumview', $forum['forumid'])) >$bbuserinfo['lastvisit']) {
$bbuserinfo['lastvisit']=$fview;
}

change to

// check to see if forum has cookie set for last reading time...ie forum marked as read
if (($fview = get_bbarraycookie('forumview', $forumid)) >$bbuserinfo['lastvisit']) {
$bbuserinfo['lastvisit']=$fview;
}

A dev obviously copied some code from the makeforumbit for use outside it :)

[Erwin]

Thanks. :)

[DWZ]

Originally posted by PPN
Confirmed and fixed using the following

A dev obviously copied some code from the makeforumbit for use outside it :) ummmmm.... What file am I looking for that code in?

And is there a reason why the topic doesn't have [fixed] in it? :confused:

(sorry to sound like an idiot, just dont want to screw anything up :o)

[kippesp]

forumdisplay.php

It works fine on my forums. Fixed for me.

[DWZ]

Originally posted by kippesp
forumdisplay.php

It works fine on my forums. Fixed for me. found the code, thanks :)

[Freddie Bingham]

Actually someone was trying to move vb3 optimizations into vb2.

[vBadvanced]

Originally posted by Paul J
Yeah, I believe so...there were a few threads that weren't posted by me with responses that I hadn't made. I left them as unread and then marked all forums as read and all the post indicators were marked as read when i returned to the board.
Try marking just one forum read, not all. ;)

[Scott MacVicar]

Originally posted by DWZ
ummmmm.... What file am I looking for that code in?

And is there a reason why the topic doesn't have [fixed] in it? :confused:

(sorry to sound like an idiot, just dont want to screw anything up :o)

Fixed means it will be fixed for the next version and that a dev has updated the code in cvs. At the moment it hasn't but someone edited the thread to indicate fixed, I'll undo it incase a developer forgets.

[DWZ]

Originally posted by PPN
Fixed means it will be fixed for the next version and that a dev has updated the code in cvs. At the moment it hasn't but someone edited the thread to indicate fixed, I'll undo it incase a developer forgets. ahh, ok then, cool :)

[Steve Machol]

Originally posted by PPN
Fixed means it will be fixed for the next version and that a dev has updated the code in cvs. At the moment it hasn't but someone edited the thread to indicate fixed, I'll undo it incase a developer forgets. I edited it based on your previous message where you posted:

Confirmed and fixed using the following ;)

[Dark_Wizard]

I have another problem related to this. I tried to post a new thread here but it said I wasn't allowed. Anyway here is the issue and it is intermittent. When you are viewing a thread and click on the arrow (Go to first unread post) sometimes it works and other time it doesn't. Can anyone else verify this? Thx!

[Steve Machol]

Originally posted by Dark_Wizard
II tried to post a new thread here but it said I wasn't allowed. Look at the decscription for this forum:

Please use this forum to discuss any bugs/issues in the vBulletin 2. Post new threads in the troubleshooting forum and a moderator will move it to this forum when it is confirmed as a bug.

[Dark_Wizard]

DOH! Thanks Steve...my mind must have been in the mud.

[adrianchew]

Fixes mine too - thanks! :D

[vBadvanced]

I think there still may be a small bug with this... I applied the fix and it works to mark the forum read and remove the new post indicators, but then when I go to the index page and click on "View New Posts" there, all the posts from the forum I just marked read still show up as new.

[Paul J]

Marking posts read has always seemed a little buggy to me, sometimes after reading a thread and coming back into the board, the thread is till marked as unread.

It's something I've learned to simply accept.