View Full Version : Messages with code no longer break out
samtha25
Mon 5th Aug '02, 9:55pm
One of the most important reasons that I chose vBulletin for our forums when we were moving from UBB was that the posts were in stacked tables that allowed messages with PRE text in them (code) to go wide without making the entire thread wide. The new showthread puts all the posts in one table, making impossible for a single post to break wide. If this is the way the final will be, this is a very serious lost of functionality for us and any forums where much code is posted. I couldn't even think of upgrading, no matter what attractions the new version has.
Wayne Luke
Mon 5th Aug '02, 10:03pm
I wouldn't even think of looking at stuff like that. It has been said numerous times that the templates on the beta forum haven't even been changed for vBulletin 3.0 yet.
Maybe when it gets closer to actually being released, the cosmetic issues can be discussed. Until then treat it like the Alpha level code that it is.
samtha25
Mon 5th Aug '02, 10:10pm
Sorry, Wayne, but there's nothing "cosmetic" for us about having scroll back and forth trying to follow complicated explanations about programming. Are the templates so unfinished that showthread will be completely redone?
Wayne Luke
Mon 5th Aug '02, 10:13pm
Personally, I don't know how finished the templates are. They are so unfinished that you are using a cobbled together version of the vB2 templates just so they will work. The vB3 templates aren't even half done yet from previous reports.
Freddie Bingham
Mon 5th Aug '02, 10:40pm
Only Kier can comment on why showthread is in it's own table now.
Kier
Tue 6th Aug '02, 10:45am
Showthread is in its own single table now because for as many comments we had about how good the vB2 multiple-table style was, we had an equal number complaining about over-use of table tags (bla bla bla).
Therefore, as the single-table method is a lot faster to render on screen, vB3 will probably ship using the current method, but if there is enough demand for it, we will also ship an alternate template set that has the old-style system in place too.
samtha25
Tue 6th Aug '02, 7:53pm
Originally posted by Kier
Therefore, as the single-table method is a lot faster to render on screen ...
In general, many smaller tables render faster than one large table. vB's multiple nested tables and odd width settings are what makes it slower. although the default has never seemed especially slow to me. I stripped out at least one layer of nesting and got rid of the tables within the postbit cells and the pages load very fast.
vB3 will probably ship using the current method, but if there is enough demand for it, we will also ship an alternate template set that has the old-style system in place too.
I don't know how much demand I alone can make, but I'd like to have the alternative template or, at least, know that the templates will be able to be modified.
Let me throw in an idea here that our premier coder suggested during a discussion on what to do about really long sections of code. He thought it would be nice if text wrapped in the code codes would create a link that would open in another window. I thought this pretty farfetched until I saw how a post from an ignored poster is handled.
rylin
Tue 6th Aug '02, 11:13pm
I second the need for less tables (although, like we all know, with the template system, it's a breeze, really).
What I really like though, is this idea, and it wouldn't really be *that* hard to do (pass the entire code as a parameter to a popup window.. ugly solution, but it works ;) (something nicer might be actually parsing out the [code] text from the postid when eg. code.php is loaded.. just an idea :)))
Originally posted by samtha25
Let me throw in an idea here that our premier coder suggested during a long discussion on what to do about really long sections of code. He thought it would be nice if text wrapped in the code codes would create a link that would open in another window. I thought this pretty farfetched until I say how a post from an ignored poster is handled.
Hellburn
Wed 18th Jun '03, 6:23am
but if there is enough demand for it, we will also ship an alternate template set that has the old-style system in place too.
I want the alternate template set :D
Nemon
Wed 18th Jun '03, 3:11pm
One of the most important reasons that I chose vBulletin for our forums when we were moving from UBB was that the posts were in stacked tables that allowed messages with PRE text in them (code) to go wide without making the entire thread wide. The new showthread puts all the posts in one table, making impossible for a single post to break wide. If this is the way the final will be, this is a very serious lost of functionality for us and any forums where much code is posted. I couldn't even think of upgrading, no matter what attractions the new version has.
Well this is what i've done, and credit where credit due, i pinched the idea from woltlab.
In your style settings look in postbit_bbcode_code
Mine looks like this
<table width="100%" border="1" cellspacing="0" cellpadding="0" bordercolor="#777777" style="width: 100%; table-layout: fixed;">
<tr>
<td align="center"><b>#Begin Code#</b></td>
</tr>
<tr>
<td><div style="overflow: auto; height: 500px; width: 100%;"><pre>$code</pre></div></td>
</tr>
<tr>
<td align="center"><b>#End Code#<b></td>
</tr>
</table>
hope that helps. ;)
Chris M
Wed 18th Jun '03, 4:16pm
Well this is what i've done, and credit where credit due, i pinched the idea from woltlab.
In your style settings look in postbit_bbcode_code
Mine looks like this
<table width="100%" border="1" cellspacing="0" cellpadding="0" bordercolor="#777777" style="width: 100%; table-layout: fixed;">
<tr>
<td align="center"><b>#Begin Code#</b></td>
</tr>
<tr>
<td><div style="overflow: auto; height: 500px; width: 100%;"><pre>$code</pre></div></td>
</tr>
<tr>
<td align="center"><b>#End Code#<b></td>
</tr>
</table>
hope that helps. ;)
Missing "/" in <td align="center"><b>#End Code#<b></td>
Should be:<td align="center"><b>#End Code#</b></td>
:)
Satan
Martyjp
Wed 18th Jun '03, 5:04pm
In general, many smaller tables render faster than one large table. vB's multiple nested tables and odd width settings are what makes it slower. although the default has never seemed especially slow to me. I stripped out at least one layer of nesting and got rid of the tables within the postbit cells and the pages load very fast.
I don't know how much demand I alone can make, but I'd like to have the alternative template or, at least, know that the templates will be able to be modified.
Let me throw in an idea here that our premier coder suggested during a discussion on what to do about really long sections of code. He thought it would be nice if text wrapped in the code codes would create a link that would open in another window. I thought this pretty farfetched until I saw how a post from an ignored poster is handled.
Add a poll to this thread and get people to vote on it, I for one would like to see more tables than the current method which imo makes threads a lot harder to read
Chris M
Wed 18th Jun '03, 5:25pm
Add a poll to this thread and get people to vote on it, I for one would like to see more tables than the current method which imo makes threads a lot harder to read
I dont find it hard to read, but I really don't mind...
Satan
KeithMcL
Wed 18th Jun '03, 5:34pm
I don't mind reading it this way either. It's having to scroll to get to the edit / reply / reply w/quote options, etc that bother me about it.
Freddie Bingham
Wed 18th Jun '03, 5:35pm
I don't mind reading it this way either. It's having to scroll to get to the edit / reply / reply w/quote options, etc that bother me about it.
That is what makes the current implementation unacceptable.
Chris M
Wed 18th Jun '03, 5:41pm
Ok then;)
I never noticed that fact before - Strange isnt it;)
Satan
vBulletin® v3.8.0 Beta 4, Copyright ©2000-2008, Jelsoft Enterprises Ltd.