PDA

View Full Version : [fixed] Missing unhtmlspecialchars while sending email to moderators


Mystics
Mon 29th Jul '02, 2:10pm
Hi,

if you have activated to send out eMails to moderators or selected email addresses on a new thread or reply in a forum, the thread title doesn't get parsed through unhtmlspecialchars while sending out this eMails.

Example, instead of this text:
<TestUser> has just posted in the Test<>Forum forum of [...] under the title of thread&title.

you will get this text by eMail:
<TestUser> has just posted in the Test<>Forum forum of [...] under the title of thread&ampamp;title.

Mystics

Mystics
Mon 29th Jul '02, 2:29pm
I also don't understand this line in newreply.php (line 360):

$subject=$threadtitle;

$subject is not used anywhere, also $threadtitle is not used in the whole newreply.php

Instead of this line I think there should be written:
$threadinfo['title'] = unhtmlspecialchars($threadinfo['title']);

Mystics

Scott MacVicar
Mon 29th Jul '02, 6:04pm
Its a bit of code left over from vB1 as $subject was in the moderatoremail template then.

Doesnt need to be there.