[fixed] Hiding a thread gives error

[Raz Meister]

When I go into the Admin options of a thread and deselect the option to show the thread and then submit it - the forum tries to redirect back to the thread, but shows as being an invalid thread.

Its not exactly a bug, but more of an annoyance.

[Cary]

I cannot reduplicate this error... what exactly are you doing?

Admin Options --> Delete Thread / Posts?

[tubedogg]

Well, normally when you edit the admin options you are redirected back to the thread. If you make the thread not visible you probably shouldn't be...

So it's a minor bug.

[Scott MacVicar]

He means if you go to delete thread, then click the link under to delete selected posts but just delete the top one.

fix

open postings.php

change

eval("standardredirect(\"".gettemplate("redirect_deleteposts")."\",\"showthread.php?s=$session[sessionhash]&threadid=$threadid\");");

to

if($deletethread) {
eval("standardredirect(\"".gettemplate("redirect_deletethread")."\",\"forumdisplay.php?s=$session[sessionhash]&forumid=$threadinfo[forumid]\");");
} else {
eval("standardredirect(\"".gettemplate("redirect_deleteposts")."\",\"showthread.php?s=$session[sessionhash]&threadid=$threadid\");");
}

[tubedogg]

Originally posted by PPN
He means if you go to delete thread, then click the link under to delete selected posts but just delete the top one.Where does he mention deleting posts?

[Scott MacVicar]

The only way I could recreate it is

Going to admin options at the bottom and select delete thread, then clicking the link within "Click here to selectively delete posts within this thread."

If you delete the top post there it deletes the thread but tries to send you back to it.

Its the only problem like it I could find in postings.php and if its not then its another bug and If love to know what hiding a thread is :)

[tubedogg]

Admin Options > Edit Thread > Show Thread? > Yes/no

[Scott MacVicar]

In that case i found a seperate bug :)

Ive never seen that feature before :eek:

just replace
eval("standardredirect(\"".gettemplate("redirect_editthread")."\",\"showthread.php?s=$session[sessionhash]&threadid=$threadid\");");

with

if($visible) {
eval("standardredirect(\"".gettemplate("redirect_editthread")."\",\"showthread.php?s=$session[sessionhash]&threadid=$threadid\");");
} else {
eval("standardredirect(\"".gettemplate("redirect_editthread")."\",\"forumdisplay.php?s=$session[sessionhash]&forumid=$threadinfo[forumid]\");");
}

[Raz Meister]

Originally posted by PPN
Ive never seen that feature before :eek:Its a great feature, esp when people post something stupid/controversial. You can then hide it and view it offline then decide to delete it or put it back. :D