[fixed] "html trouble" with a moderated thread

[Alwaysmefirst]

Hi!

I know a message is moderated when someone starts a new thread, checks the box to add a poll to it, hits submit, and then abandons it without completing the poll.
Yesterday there was a message waiting for approval that contained "something' in the title. When I approved it, " became & q u o t ; (without space) so I had to edit the thread's title to fix it.
When I post using " in the title without checking the box to add a poll, there is no problem: http://www.vbulletin.com/forum/showthread.php?s=&postid=322986#post322986
It's not a problem for me as it is very rare (first time) :)
I am using vb 2.26 (and register_globals is off).

Olly

[Jake Bunce]

register_globals needs to be ON. i'm not sure if that's your problem though.

http://www.vbulletin.com/forum/showthread.php?s=&threadid=44820

[Alwaysmefirst]

Hi Jake,

I think vb 2.26 fixed the register_globals problem and works even when it is set to off (http://www.vbulletin.com/forum/showthread.php?s=&threadid=46938) but it is maybe related to that setting (?).
I had repair.php that did not work because it was set to off:
http://www.vbulletin.com/forum/showthread.php?s=&postid=315365#post315365

Olly

[Mike Sullivan]

I will have to look at it to confirm, but it's probably just getting double htmlspecialchars()'d. I'll move this into the bugs forum, so I remember to take a look at it when I can.

[Scott MacVicar]

Its already been passed though htmlspecialchars before being put into the post table, its then been put through again when using the makeinputcode function.

Open /mod/moderate.php and look for
makeinputcode("Thread:","title[$thread[threadid]]",$thread[title]);

change to

makeinputcode("Thread:","title[$thread[threadid]]",$thread[title],0);

[Floris]

Originally posted by Jakeman
register_globals needs to be ON. i'm not sure if that's your problem though.

http://www.vbulletin.com/forum/showthread.php?s=&threadid=44820 I thought 2.2.6 was meant to work with register_globals turned on AND off ?

[Alwaysmefirst]

Thanks for the fix!