[fixed] Division By Zero on showthread

[LeeS]

A user just reported this problem to me, and we've not been able to duplicate it since, but it is bothersome.

Warning: Division by zero in /home/virtual/site1/fst/var/www/html/admin/functions.php on line 46

line 46 in our case is:

$totalpages = ceil($results/$perpage);

from 'getpagenav'

What's this all about? :confused:

[eva2000]

what version of vB and php are you using ?

[LeeS]

4.0.6 (patched) & 2.2.5

[Steve Machol]

What you quoted above is not what's on line 46 of the default functions.php for 2.2.5. This is actually on line 26. You must have modified the file for some hack. Reupload the original file to fix this problem.

[LeeS]

Indeed I have, but it was to add my own function (just my simple ad rotator) and putting it in admin/functions.php was the easiest place to put it within reach of all forum pages. It's a completely isolated function and has no interaction with the section of code in question.

[eva2000]

Originally posted by LeeS
Indeed I have, but it was to add my own function (just my simple ad rotator) and putting it in admin/functions.php was the easiest place to put it within reach of all forum pages. It's a completely isolated function and has no interaction with the section of code in question. does removing your addition fix the problem ?

[Scott MacVicar]

If they add &perpage=0 to the url you will get that error, shouldn't there be some error checking to make sure people don't enter that?

Moving to bugs forum.

[LeeS]

Like I said it was a freak incident, we've not been able to replicate it, including the person who first got the error. It's possible (as said above) someone dropped in a malformed url as a link within a message.

Was just a curious incident that may or may not, have deeper roots. Thought it was worth reporting. :)

[Scott MacVicar]

Adding &perpage=-1 has intresting results as well. I'd have to say its most likely that they were given a malformed URL with a perpage=0 within it, and there is error checking to make sure they can't set their maxposts in options to 0 or -1 but no check if they passed it in the url.

[Mike Sullivan]

Simple fix.

if (!isset($perpage)) {

to:

$perpage = intval($perpage);
if ($perpage < 1) {

in showthread.php