[fixed] Email notifications are sent before some checks

[Streicher]

Possible bug?

If someone is posting a new post with an attachment with invalid file extension the email notification is send to all user who wants it, but the post is not posted, because of teh invalid file extension.

[Scott MacVicar]

This isn't a bug as such more of a design flaw.

The notification email is above the attachment check.

Easily fixed open /newreply.php

find


if ($visible) {
sendnotification ($threadinfo['threadid'], $bbuserinfo['userid'], 0);
}

move to below


indexpost($postid,0);

(line 264)

I also noticed now that you pointed it out that the double post check would also lead to two emails being sent even if it just redirects the user to the first one instead of creating two.

[Streicher]

Ok, than it is a design issue. mayber one of the developers can move this to the correct forum.

[eva2000]

moved :)