[Design Issue] private.php with Ignored Users

[Mystics]

Hi,

if you send a Private Message to a User, private.php is checking if the Receiver has a Full PM Box; the Number of his PMs is counted whith this function: $msgcount = $DB_site->query_first("SELECT COUNT(*) AS messages FROM privatemessage WHERE userid=$touserinfo[userid]");But I think, you should also check, if the receiver has any PMs from Users on his Ignore List (like it is done in index.php and in an other part of private.php).

So the code should be changed to: if (trim($touserinfo[ignorelist])!="") {
$ignoreusers="AND privatemessage.fromuserid<>".implode(" AND privatemessage.fromuserid<>",explode(" ",trim($touserinfo[ignorelist])));
} else {
$ignoreusers="";
}
$msgcount = $DB_site->query_first("SELECT COUNT(*) AS messages FROM privatemessage WHERE userid=$touserinfo[userid] $ignoreusers");Please confirm, if this solution is right.

Greetings,
Mystics

[Scott MacVicar]

The pm's are still in his inbox so it will still contribute towards his pm box limit.
On the index page its to show how many unread or new pm's he has and we don't want to include ignored users pm's in either of those totals.

Hopefully that was clear.

Scott

[Mystics]

Yes, I know this :)

But a little example:
$pmquota = 30
PMs of User XX = 30, including 5 PMs of ignored Users.
User XX knows/thinks that he still can save 5 more Private Messages, because he can see on the Forum Home: "You have a total of 25 PMs" (out of PMQuota=30).

But than another User wants to write him a PM and User XX gets an eMail: "Your PM Box is full".

And I think this will confuse most users :p
Because he can't see the 5 additional PMs of the Ignored Users and therefore he can't delete it.

And I also believe that most users doesn't know this fact (that PMs of Ignored Users are saved nevertheless).

So I think, PMs of Ignored Users should counted nowhere in the Board or everywhere.

Mystics

[Scott MacVicar]

He will be able to see the pm's once he goes into private.php, this is not a bug, its designed like that.

If a user has 6 people ignored and they each sent him 5 pm's and the quota is say 40, your suggesting that instead of only being allowed to have 10pm's they will be allowed to have 70 which is verging on double what they are allowed.

[Pogo]

PPN When I ignore a user I don't see PMs from him in my inbox. I just tested it here in this forum.
When I take him off the ignorelist the PM appears.

But why is a user allowed to spam my inbox and makes me unable to recieve other PMs in the worst case? I think this is some kind of misdesign. I can't be responsible for PMs I don't want to get. This is why I ignore a user.

[Scott MacVicar]

Ok just looked into this, when you ignore a user the pm's just simply disapear and they can continue to spam you and fill up your inbox and you wouldn't even notice.

Either we need to get a folder for ignored user pm's or stop them from sending us pm's.

[Mystics]

Can anybody please move this Thread to the Bug Forum for verification?

I think that this topic still is not 100% clear :)

Mystics

[eva2000]

thought i already moved this for verification ? :o

[Chen]

I don't think this is a bug, really. A user would be able to bypass the PM limit by adding his buddies to his ignore list, then remove them occacsionally to read the PM's, then put them back there. They will be able to easily flood vB with PM's.

[Fusion]

Originally posted by PPN
we need to stop them (ignored users) from sending us pm's. Hmm, I thought that was a natural result of being ignored? Or wouldn't you want them to be told they're being ignored?

[Pogo]

FireFly Then it would be good to show how many PMs from ignored users I have hidden in my inbox.
Plus an option to delete them without taking the ignored user off the list.

[Joshua Clinard]

I agree with Pogo. They should be blocked from sending you PM's in my opinion. Or there should be something allowing you to delete them without removing them from the ignore list.

[Fusion]

Originally posted by Joshua Clinard
I agree with Pogo. They should be blocked from sending you PM's in my opinion. Or there should be something allowing you to delete them without removing them from the ignore list. Dumping any and all PMs by ignorees into the Great Void (/dev/null) would be easiest by far.

Before you come back saying they need to be able to get in touch with you, well, that's not a right. If people behave so they are ignored, tough.

[Joshua Clinard]

Can this issue be fixed for 2.2.6?

[Chen]

Most likely it won't be.

[Thomas P]

Hmmm, I think the PMs of ignored users should be made visible (1) (e.g. "You have x PMs from Users you've chosen to ignore" - [show/hide] - [delete]) or (2) the ignored user should get a message: "The recipient has chosen to ignore your PMs. Please refrain from sending further messages" (blabla, every admin could change that to whatever he/she wants).

Otherwise this sounds rather confusing,
Just my €0.02, of course...
-Tom

[Joshua Clinard]

Your #1 is a very good idea, Thomas!

[CB_Tommy]

I agree to your first idea too, Thomas.

[Meirion]

1 sounds good, but thinking about the reasons for having an ignore list I think 2 would be more appropriate.

If you're getting harrased on the board by someone, and you want to ignore them that is exactly what you want to happen. haveing VB pop up specially worded messages actually drawing your attention to that fact that this looser is still sending you PMs defeats them being "ignored".

I mean that's tempting fate.. if it says you have received a PM from someone you're trying to ignore you just can't ignore it can you, the temptation is too great.

Be better just to give the ignored sender a really generic vague message like the one VB gives if you try to PM someone who has PMs disabled. Like "Sorry this user has specified not to receive private messages"

What do you reckon?

[Joshua Clinard]

I noticed that a lof of these threads are being updated with the word fixed. I hope that means that 2.2.7 is near. Please please fix this for the next version.

[Scott MacVicar]

As the topic indicates it is a design issue and not a bug.

[Joshua Clinard]

Does not mean that it can't, or shouldn't be fixed. And their have been a few suggested fixes in this thread that could possibly be explored. If they can't find a fix, I understand, but shouldn't you try to offer the best quality product that you can?

[Scott MacVicar]

Its not a bug as such, yes they could send pms until their hearts content but it wont contribute to the limit, so its not really a drastic problem.

Fixing it would involve a rewrite of the code, and most of the devs are working on vB3 so they wont be taking time out to work out a new way to deal with something which has been fixed for vB3.