View Full Version : [fixed] Highlight doesn't carry over...
DarkReaper
Fri 7th Dec '01, 8:46pm
http://dynamic3.gamespy.com/~serioussam/forums/showthread.php?s=&threadid=25&highlight=second+encounter
The highlight doesn't carry over to a new page when u click the page number.
tubedogg
Fri 7th Dec '01, 10:02pm
True, but I'm not sure it's a bug.
DarkReaper
Fri 7th Dec '01, 10:04pm
Well, shouldn't it? Why wouldn't it...if it highlights it on the first page, why not the rest? :)
Chen
Sat 8th Dec '01, 3:42am
I also think it should be carried. :)
Try this fix. In showthread.php, replace:
$pagenav = getpagenav($totalposts,"showthread.php?s=$session[sessionhash]&threadid=$threadid&perpage=$perpage");
with:
$pagenav = getpagenav($totalposts,"showthread.php?s=$session[sessionhash]&threadid=$threadid&perpage=$perpage&highlight=$highlight");
DarkReaper
Sat 8th Dec '01, 7:52am
That worked(of course:))
DarkReaper
Sat 8th Dec '01, 7:55am
Doh...no it didn't. It carries over when there's no highlight, and screws up smilies
http://dynamic3.gamespy.com/~serioussam/forums/showthread.php?s=&threadid=6644&perpage=15&highlight=&pagenumber=2
eva2000
Sat 8th Dec '01, 8:37am
it could be a bug.. it carries over for me on my 2.2.0 forum
Chen
Sat 8th Dec '01, 9:18am
In showthread.php find this:$pagenav = getpagenav($totalposts,"showthread.php?s=$session[sessionhash]&threadid=$threadid&perpage=$perpage");and replace with$pagenav = getpagenav($totalposts,"showthread.php?s=$session[sessionhash]&threadid=$threadid&perpage=$perpage".iif(isset($highlight), "&highlight=$highlight", ""));
And here's another bug, specifying an empty highlighting string screws up the smilies.
To fix it, in showthread.php replace:
// words to highlight from the search engine
if (isset($highlight)) {
with:
// words to highlight from the search engine
if (isset($highlight) and $highlight!='') {
vBulletin® v3.7.2, Copyright ©2000-2008, Jelsoft Enterprises Ltd.