View Full Version : [fixed] Activation codes don't seem to be working when sending them in email
Spark
Sun 4th Nov '01, 2:17pm
I turned off posting for members who have not confirmed their email addresses - and sent them all a mass message saying why.
In the mass message I cut and pasted the code provided for activation.
Now I've got close to one hundred emails stating that they are getting this information -
"We could not activate your account because this web address is not valid. Make sure that you have the entire address from the email, and that your email client has not split the address over several lines."
When clicking on the link in this message If you do not know your activation code, you can find it in the email that was sent to you when you first registered. To have it sent again, please click here: Send new email with activation code."
Needless to say this is not making my life any easier.
Kevin
GMTalk
Mon 5th Nov '01, 9:47am
After my ugrade i am getting these messages from my new users. i had this problem before, but was fixed. now i am getting it again.
Any suggestions?
evoir
Mon 5th Nov '01, 5:18pm
I'm having the same problem. I even changed the email adress (to mine) on one of the accounts that was having trouble. I sent myself the email from the "Email Activation Codes" button, and the link did not work.
Very odd. Is this a bug? Version 2.20
eva2000
Mon 5th Nov '01, 7:31pm
Spark/Kevin can you please enter your username on the form on this page http://www.vbulletin.com/members/forums.php - to do so you need your customer license info to access the form
Spark
Mon 5th Nov '01, 7:36pm
Ok, entered my details - please help ASAP.
evoir
Mon 5th Nov '01, 9:03pm
Is this a bug? Why would this be happening?
p.s. there has got to be a better way to keep folks who don't own licences from getting support. Eva2000 took the time to tell someone to put thier licence info in, rather than making a suggestion to fix this problem (it could be that Eva didn't have a suggestion, but it is frustrating nonetheless).
I wish there were no pirates. :) Aye, mate.
GMTalk
Mon 5th Nov '01, 9:06pm
well i guess i need to put in a support request. since there are so many that have pirated this software. would it not be easier that the members that are paying customers get a private area or something of the sort so that we can get the support quicker.
just a suggestion/
:rolleyes:
Spark
Mon 5th Nov '01, 9:24pm
No kidding.
GMTalk
Mon 5th Nov '01, 9:29pm
Dont get me wrong. i am not knocking this support. i have gotten quite a bit from the moderators and admins here. it is just a shame that it has to be this way.
eva2000
Mon 5th Nov '01, 9:50pm
Originally posted by GMTalk
well i guess i need to put in a support request. since there are so many that have pirated this software. would it not be easier that the members that are paying customers get a private area or something of the sort so that we can get the support quicker.
just a suggestion/
:rolleyes: there is a members support ticket area http://vbulletin.com/members/support.php
as to the activation problem i'm not a coder or developer so not sure :(
other than reverting your email activation templates to original, making sure all 2.2.0 php files were uploaded i'm not sure :(
Alwaysmefirst
Mon 5th Nov '01, 10:57pm
Originally posted by eva2000
there is a members support ticket area http://vbulletin.com/members/support.php
as to the activation problem i'm not a coder or developer so not sure :(
other than reverting your email activation templates to original, making sure all 2.2.0 php files were uploaded i'm not sure :(
It seems email_validated template has been forgotten to be updated for 2.2.0. as it still contains $password. This even on a new install (not a question of reverting templates to original).
I had troubles with 50 new members on my board because I didn't know about it. I thought they were making mistakes :)
http://www.vbulletin.com/forum/showthread.php?s=&postid=199187#post199187
Olly
evoir
Mon 5th Nov '01, 11:22pm
arg. Thanks for the fix. now, can someone tell me exactly what to change to fix this problem. It turns out that I resent actiivation codes to 90 people the other day, and it looks like non of them will work (based on this problem). Now, I'll have to resend, but I have probably already lost the new members to frustration....
template:
find:
replace with:
Thanks!
Evie
eva2000
Mon 5th Nov '01, 11:48pm
Originally posted by Alwaysmefirst
It seems email_validated template has been forgotten to be updated for 2.2.0. as it still contains $password. This even on a new install (not a question of reverting templates to original).
I had troubles with 50 new members on my board because I didn't know about it. I thought they were making mistakes :)
http://www.vbulletin.com/forum/showthread.php?s=&postid=199187#post199187
Olly strange my vB email_validated still works with $password
the email_lostpw template is the one for lost passwords???? it has the correct link in by default on my install??
Spark
Tue 6th Nov '01, 12:09am
So what's the fix?
scoopster
Tue 6th Nov '01, 11:32am
same exact problem on my board. Any one come up with a solution yet?
eva2000
Tue 6th Nov '01, 12:01pm
are these templates edited by any chance?
error_invalidactivateid
activate_requestemail
activateform
activate_requestemail
scoopster
Tue 6th Nov '01, 12:21pm
they are un-altered.
Black Tiger
Tue 6th Nov '01, 12:24pm
Same problem here.
Users got this invalid link notice, but luckely enough the accounts -are- activated.
I checked, and I can't remember ever changing the activate_requestemail template but it was indeed changed.
I now reverted to original and at the moment we're testing if failures still occur, or if the problem is over now, I'll report back soon.
Black Tiger
Tue 6th Nov '01, 12:31pm
Problem solved over here.
Reverted as stated above and no errors anymore.
No I think we can not use the "email users their password" option from the Admin CP anymore can we? Because they're encrypted.
Is there a solution for that too?
eva2000
Tue 6th Nov '01, 12:33pm
great Blacktiger which were changed btw?
error_invalidactivateid
activate_requestemail
activateform
activate_requestemail
eva2000
Tue 6th Nov '01, 12:37pm
Originally posted by Black Tiger
Problem solved over here.
Reverted as stated above and no errors anymore.
No I think we can not use the "email users their password" option from the Admin CP anymore can we? Because they're encrypted.
Is there a solution for that too? yes you need to include the url to the lost password form instead of the $password variable
Black Tiger
Tue 6th Nov '01, 12:38pm
The activate_requestemail was changed, that was the only one, could be I changed some text in the past in there but I don't remember doing that.
The others you mentioned were un-altered.
For the other thing, thanks I'll replace $password with the link, thanks!
eva2000
Tue 6th Nov '01, 12:40pm
okay thanks.. i think other members might have had this problem
evoir
Tue 6th Nov '01, 1:08pm
Activation codes still do NOT work.
I just reset my "email_activateaccount" template and resent to myself.
I could not activate my new account.
Seems like there are two problems, one is passwords and one is with activation codes
Can this be addressed ASAP?
sifuhall
Tue 6th Nov '01, 1:29pm
I am experiencing this problem as well. This is a major bug!!!
evoir
Tue 6th Nov '01, 2:18pm
I reset:
error_invalidactivateid
activate_requestemail
activateform
activate_requestemail
still experiencing the same problem.
Spark
Tue 6th Nov '01, 4:17pm
None of those were even modified on my board. Still not working.
Need a fix, folks.
Kevin
sifuhall
Tue 6th Nov '01, 5:55pm
When I got home I was bombarded by emails from people that cannot activate.
Here are a few examples. Some nice, some not so nice.
There seems to be some kind of trouble with your Activation services. Everytime I attemp to activate my account I get a message which reads:
We could not activate your account because the web address was not valid, even when I fill in the activation form with the activation code given to me in the email which was :
28797095
My activation code is not working for some reason.
I have tried repeatedly to activate my account and finally have given up in disgust. Until you can do an acceptable job running a web site I have decided not to waste my time with you
sifuhall
Tue 6th Nov '01, 6:13pm
I just went into MySQL and tried to find out why the activations weren't working.
I querried the user table to get the userids of some of the people having trouble and none of these userids are in the useractivation table!
For example, my most recent complaint was this (I received this email less than 15 minutes ago) :
There seems to be some kind of trouble with your Activation services. Everytime I attemp to activate my account I get a message which reads:
We could not activate your account because the web address was not valid, even when I fill in the activation form with the activation code given to me in the email which was :
28797095
For User name:
Shouting Tiger
I'm fairly certain I am doing it correct, but the bulliten keeps popping up.
I appreciate your attention to this matter, Thanks a bundle.
So in an attempt to track this down I did this:
mysql> select userid from user where username='Shouting Tiger';
+--------+
| userid |
+--------+
| 5761 |
+--------+
mysql> select * from useractivation;
+------------------+--------+------------+--------------+------+
| useractivationid | userid | dateline | activationid | type |
+------------------+--------+------------+--------------+------+
| 4 | 5743 | 1004859415 | 71024151 | 0 |
| 18 | 5750 | 1004968330 | 25438215 | 0 |
| 41 | 5771 | 1005078576 | 68440101 | 0 |
| 12 | 5748 | 1004919364 | 28015646 | 0 |
| 15 | 4838 | 1004944791 | 82333038 | 1 |
| 14 | 5450 | 1004930622 | 87181975 | 1 |
| 24 | 5754 | 1004996380 | 93918482 | 1 |
| 25 | 5756 | 1004996546 | 26272641 | 0 |
| 37 | 5767 | 1005058486 | 74896903 | 0 |
+------------------+--------+------------+--------------+------+
I hope this helps to resolve this quickly!
Black Tiger
Tue 6th Nov '01, 7:13pm
I hope so for you to guys. I can't give my board for example, since I installed 2.2.0, I implemented several hacks because of which a bug reported in the bugforum was already fixed because I also installed the starhack which replaced a faulty code.
So maybe the combination of resetting my activate_requestemail and the implemented hacks was the solution for my board.
Sorry.
Smoothie
Tue 6th Nov '01, 8:37pm
I have seen this happen on my board recently, just once. For some reason it doesn't happen to every member that registers. But to the member it happened to, it was exactly the same error.
Smoothie
evoir
Tue 6th Nov '01, 8:55pm
comon jelsoft... help us out.
I put in a service ticket with no response yet... and this thread is now three pages long. Please help us figure out what is going on here...
tubedogg
Wed 7th Nov '01, 2:05am
I have looked at the relevant code, and without any errors during registration, I don't see how the activationid's could not end up in the database.
Have any of you done any code hacking? I don't see any other possibility...the template is correct, the code in register.php is correct...
evoir
Wed 7th Nov '01, 2:35am
JamesUS posted the answer here (http://vbulletin.com/forum/showthread.php?s=&threadid=32661 ) :)
Thanks JAmesUS!
eva2000
Wed 7th Nov '01, 2:38am
Originally posted by evoir
JamesUS posted the answer here (http://vbulletin.com/forum/showthread.php?s=&threadid=32661 ) :)
Thanks JAmesUS! that thread's by kevin though? :)
evoir
Wed 7th Nov '01, 2:47am
ahh. wasn't thinking. Thanks Kevin! (JAmes had sent me an email pointing to that thread)
BUT
I think there will still be a problem. I was having trouble when sending the activation codes from the CP...neither of these emails adresses that template (email_activateaccount)
Also, I saw no change in email_lostpw. What was the change?
Havent tested it out yet...
tubedogg
Wed 7th Nov '01, 3:54am
The changes to email_lostpw are removing the username/password and instead putting in the wording about resetting your password.
I'll check on email_activateaccount.
tubedogg
Wed 7th Nov '01, 3:58am
email_activateaccount has not changed since the last version.
sifuhall
Wed 7th Nov '01, 9:50am
My problem is also on the activation side. The odd part is I tested it myself (signed up with a different email addy) and it worked for me, however I have so many users complaining I have to believe something is wrong.
Mika
Wed 7th Nov '01, 10:13am
Here is another user with that problem. I just got an email from a user "We could not activate your account because this web address is not valid...." I tried it myself with same results. If I tried it manually same problem. However in CP this user's User Group was set to Registered. So this is really annoying bug.
VB is 2.2.0
scoopster
Wed 7th Nov '01, 11:48am
I am being flooded with emails from users that can not activate their account. Is this bug being worked on? please help.
evoir
Wed 7th Nov '01, 12:16pm
When I email the activation code from the CP, it is wrong. email_activateaccount is the template which sends this email.
I have reset this template to it's original form. vB 2.20
(I just edited out my url, cause I realized I don't want it so public)
Spark
Wed 7th Nov '01, 5:47pm
Still not working after changing those two templates....
MarkB
Wed 7th Nov '01, 6:21pm
I changed the second template mentioned in that thread of Kevin's, and a test registration's activation link worked ok. Here's hoping it works for everyone else :o
:)
tubedogg
Wed 7th Nov '01, 10:49pm
Originally posted by Mika
[B]Here is another user with that problem. I just got an email from a user "We could not activate your account because this web address is not valid...." I tried it myself with same results. If I tried it manually same problem. However in CP this user's User Group was set to Registered. So this is really annoying bug.That's correct - if it says 'the web address is invalid' it means the activationid can't be found. If the user is in the registered group, they should not have an activationid, hence the error, hence that's correct.
Now how they got in the registered group is another issue.
OK, you all require email activation, right? And it stopped working (or at least only sometimes works) after the upgrade to 2.2, right? And you all are using the default email_activateaccount template?
Smoothie
Wed 7th Nov '01, 11:04pm
OK, you all require email activation, right? And it stopped working (or at least only sometimes works) after the upgrade to 2.2, right? And you all are using the default email_activateaccount template?
Yes to all of the above. The one user (as of now) that has had this problem was in the registered group.
Smoothie
evoir
Wed 7th Nov '01, 11:10pm
I answer yes to all your questions too, tubedogg
I don't have a problem about which user group, it seems to only be for folks in the "users awaiting email confirmation"
I have since turned off email confirmation, but I would rather have it on.
sifuhall
Thu 8th Nov '01, 8:11am
Originally posted by tubedoggOK, you all require email activation, right? And it stopped working (or at least only sometimes works) after the upgrade to 2.2, right? And you all are using the default email_activateaccount template?
Yes, and to further complicate matters it works for some (most?) users, but not others.
I have no hacks installed on my board.
Pete
Thu 8th Nov '01, 8:35am
Here's the question:
if it's working for you do you have any sticky threads?
if it's not do you have any sticky threads?
Pete
sifuhall
Thu 8th Nov '01, 4:31pm
I do have sticky threads.
My users seem to have trouble about 10% of the time.
SFishy
Fri 9th Nov '01, 3:32am
I'm having this problem too.
Not all members, but I'd agree about 10%.
They write to me and tell me their activation doesn't work... when I go to the admin cp and look at their account, they are already in the "registered" group.
Template email_activateaccout is reverted to original.
I did Kevin's changes (from a few replies back) to the other e-mail templates.
Thanks.
Pete
Fri 9th Nov '01, 3:57am
putting in the rec updates seemed to have worked for me as well.
Thanks guys....
Pete
Black Tiger
Fri 9th Nov '01, 7:50am
I thought my problem was over, but unfortunatelly it seems not to happen to all registering users but to some it is, and some it is not.
In my case I'm using the default email_activateaccount template.
I changed however email_validated and email_lostwp to suggestions given by Tubedogg and other moderators.
This had to do with replacing the $userpw with the link.
We're using sticky threads by the wya.
This is the email I got today:
===============================================
We could not activate your account because this web address is not
valid. Make sure that you have the entire address from the email, and
that your email client has not split the address over several lines.
Please try again with the full address from the email that you received.
If it still does not work, try filling in the activation form:
Activation form
If you do not know your activation code, you can find it in the email
that was sent to you when you first registered. To have it sent again,
please click here:
Send new email with activation code.
If all else fails, email the administrator, making sure that you include
your registered email address and username"
================================================== =====
"Because "all else fails" I am contacting you" wrote the registering user.
Spark
Fri 9th Nov '01, 8:40pm
Email confirmation is on, templates are default. Maybe there is a problem in the routines where activate codes are created.
evoir
Sat 10th Nov '01, 1:33am
What is going on? if we ignore it the problem will go away? Is anyone gonna help us on this?
JamesUS has asked for my url, but I have not heard back. I am a paid customer of your product. Clearly, something is going on here. It's more than me. I don't know what's wrong, but I would certainly like to see someone from vB take a bit of interest in this.
:(
tubedogg
Sat 10th Nov '01, 4:52am
Trust me, we are taking interest in this. The other night I spent a good while looking over the relevant code and I can't find anything wrong with it at all. The problem is we don't know what's going wrong, and hence we can't fix it.
evoir
Sat 10th Nov '01, 2:11pm
Thanks Tubedogg,
JamesUS just tried registering on my board, no problem. Where I see the problem, is when I send out the activation codes from the CP to user's awaiting email confirmation. So, I switched James's usergroup to "USers awaiting email confirmation, and sent him his activation codes again.
Let's see if it happens to him.
I jsut tested again, and It happened again to me using another username (Where I sent the activation codes to myself again, and it didn't work)
evoir
Sat 10th Nov '01, 6:18pm
Ok, just got an email back from JamesUS, and it seems he finally saw what I was talking about. He was able to confirm this on his developement board, and Jelsoft will be working on a solution to the problem. :)
Just keeping ya all up to date :)
John
Sat 10th Nov '01, 6:38pm
I am joining this conversation a bit late, so sorry if I repeat things already mentioned.
Can you try changing the following two lines in /admin/email.php
Line 130 to:
$DB_site->query("DELETE FROM useractivation WHERE userid='$user[userid]' AND type=0");
Line 137 to:
$DB_site->query("INSERT INTO useractivation VALUES (NULL,'$user[userid]','".time()."','$activate[activationid]',0)");
If this works, please let me know.
Thanks,
John
evoir
Sat 10th Nov '01, 8:05pm
Honestly, since JamesUS was able to reproduce the problem, I'd rather you all test it out by hacking the code yourselves. I don't want to go in and change things, until an answer is found.
I appreciate the offer of help.
Evie
sifuhall
Sat 10th Nov '01, 8:10pm
Looks like we are finally making some progress.
I, too, want to wait until this fix has been tested before I attempt it.
JamesUS
Sun 11th Nov '01, 3:39am
Edit: Just saw that this thread has another page and John has posted his solution here. Feel free to try this if you want to, but don't feel obliged :) This did work on my test boards.
I've just spent ages working this out for evoir in the support system, so I might as well share the solution here :)
When a user registers, the activation stuff works fine. But when you use the 'resend activation info' button in the CP to resend their info, the link doesn't work.
If that is the problem you are having, open register.php and find this:
if ($user[usergroupid]==3) { // only do it if the user is in the correct usergroup
Directly above it, insert this:
$user[activationid] = "";
Please bear in mind this solution is untested and unsupported. Please let me know whether it works or not.
evoir
Sun 11th Nov '01, 2:22pm
hmmm.
Two solutions. Can you pick which one to do, and let us know? I don't want to "fix" one thing, and create a problem elsewhere. One of you has a fix in email.php, the other in register.php
which one is right?
Joshua Clinard
Sun 11th Nov '01, 5:30pm
I had this problem to when I first started allowing registrations on my board. A lot of users were e-mailing me. Once yall find out this problem, can you fix it in the zip file, so we can upload the proper files, instead of editing the files? I am afraid I might break something, and I am new to PHP.
On second thought, you should actually change the files, and the version number to 2.2.1. And include any other fixes you have found in this release. That way, when new customers download this verison, they won't have to go searching the forums when they install new forums in the future.
evoir
Sun 11th Nov '01, 7:18pm
well, I went into register.php and added this line. I was unable to send out activation codes to myself, it just choked the system.
This is precicely why I don't want to go in and change the files myself. I hope to see a new version that fixes this problem asap.
I had to change my register.php back to it's orginal form.
Please make a fix for this.
Originally posted by JamesUS
open register.php and find this:
if ($user[usergroupid]==3) { // only do it if the user is in the correct usergroup
Directly above it, insert this:
$user[activationid] = "";
evoir
Sun 11th Nov '01, 7:21pm
Also, another place that the emailing registration codes doesn't work is the "self serve" page. register.php?s=&action=requestemail
It probably uses the same function or whatever. Please, let's get a tested and supported fix for this :)
wastegate
Sun 11th Nov '01, 10:54pm
Just thought I would add my board to the list.
I run http://www.performanceforums.com been running now for about 2 weeks with vbulletin 2.2.0 fresh install. Since day one I have been getting some users complain that there activation code is not working when they get the email. First I thought they might have been clicking on it twice because everytime I check the user out, their in there as registered. But this is happening to about 20% of people that try and register. Please help.
Spark
Sun 11th Nov '01, 11:27pm
So what's the deal? Are we going to see a new release soon, or is there a way to downgrade back to 2.0.3?
Kevin
JamesUS
Mon 12th Nov '01, 2:33am
Have you tried John's code change?
evoir
Mon 12th Nov '01, 12:17pm
the whole point is that we are looking for a supported fix. If this is really repeatable, put out a public fix that is supported. My board is live, I don't have a test board. I don't want to go in and change files, if I don't have to. In the meantime, I am loosing credibility day by day as this is left unfixed. I may try John's fix, but I am not happy about it.
Steve Machol
Mon 12th Nov '01, 12:22pm
evoir,
Since this problem is not happening with all vB 2.2.0's out there (it's not happening on mine for instance) then the only way the developers can 'fix' this is to try this out on boards that are having the problem. If you aren't willing to try this out to see if it works, then how exactly are they supposed to fix this? :confused:
evoir
Mon 12th Nov '01, 12:32pm
JamesUS was able to duplicate the problem. I tired the code he suggested, and it made the "email activation codes to user" get stuck...
And I just tried John's code change, and it didn't fix it. Although, I was able to email the activation codes to myself, the code just didn't work.
smachol, if you create a new member name for yourself, and change the status to "memebrs awaiting email confirmation" then try emailing the activation codes to yourself....the code your system sends to you is correct and correctly validates you?
This is the exact situation that makes this happen in. James was able to replicate the problem. Can anyone else replicate the problem? A show of hands, please?
Steve Machol
Mon 12th Nov '01, 12:56pm
Sorry evoir, I thought you had said you didn't test this out. When James asked if you had tried John's code, you stated '" don't want to go in and change files".
However I've done exactly what you suggested. I tested this out three ways: (1) before making any changes, (2) after making the changes to email.php as suggested by John, and (3) again after making the changes to register.php from James.
In each case the email validation code produced the 'We could not activate your account because this web address is not valid' error message.
Given this, I agree that the suggested fixes don't work.
Joshua Clinard
Mon 12th Nov '01, 12:59pm
I am willing to bet that there are more boards that this is happening too, but they may not be reporting the problem. They may be thinking that the users are not validating correctly. I saw one board that told it's members that if the validation link is invalid, it is most likely because they submitted it twice, and that is clearly not the case. Isn't there anyone who uses vBulletin that has a beta board set up? If not, this would be a good thing to do, to let people set up test boards, or to set up several test boards on vbulletin's server. That is similar to how ezboard did it, and that seemed to work pretty well.
Steve Machol
Mon 12th Nov '01, 1:04pm
Originally posted by Joshua Clinard
I am willing to bet that there are more boards that this is happening too ..... Well that was my assupmtion since I've gotten absolutely no complaints about this. However actually testing it out myself as evoir suggested showed that it was a problem on my board. Furthermore the suggested fixes do not fix the problem - at least not on my board. Obviously more work needs to be done to find the fix.
evoir
Mon 12th Nov '01, 1:13pm
Smachol,
I really didn't want to test things out on my live board, but I finally did, since I was getting a blank response until I did. So I did.
I think a better way to deal with problems like this is to first replicate it on other boards, get the developers to replicate it, and then let them test the hell out of it on thier test boards.
I think this was a communication error, because two days ago, I got JamesUS to be able to replciate the problem on his board.
So, now...we know it is a universal problem. Now, we need a universal fix. :D
evoir
Mon 12th Nov '01, 1:17pm
Also note: this problem won't appear for members normally registering, it is only for folks who use the self serve page for email authentication, or if you send them a reminder authentication email.
That's probably why not too many folks have found this problem, they have to be using these exact tools. :)
Just before we found this bug, I sent out about 75 reminders. arg. (which is now almost a week ago - making me look not so good)
CondorZ
Mon 12th Nov '01, 1:27pm
Originally posted by smachol
Obviously more work needs to be done to find the fix.
Yes I agree. We cannot send the acivation codes again until this is fixed. :eek:
Alwaysmefirst
Mon 12th Nov '01, 3:45pm
Originally posted by evoir
[B]Also note: this problem won't appear for members normally registering, it is only for folks who use the self serve page for email authentication, or if you send them a reminder authentication email.
I have exactly the same problem. I didn't modify the code because I am waiting for 2.2.1 version to fix this and don't want to have troubles when using the upgrade file.
Olly
Joshua Clinard
Tue 13th Nov '01, 12:42pm
When can we expect a fix on this. I am waiting for this fix before my board goes live. Can someone please give us an update. I am sure there are many others waiting to hear. Please release 2.2.1 with all the bug fixes that I have seen in this forum. I counted at least 16!
Steve Machol
Tue 13th Nov '01, 1:22pm
http://www.vbulletin.com/forums/showthread.php?s=&threadid=33202
John
Tue 13th Nov '01, 6:32pm
Fixed.
In admin/email.php:
Change line 130 to:
$DB_site->query("DELETE FROM useractivation WHERE userid='$user[userid]' AND type=0");
Change line 137 to:
$DB_site->query("INSERT INTO useractivation VALUES (NULL,'$user[userid]','".time()."','$activate[activationid]',0)");
In register.php:
Change line 602 to:
$DB_site->query("DELETE FROM useractivation WHERE userid='$user[userid]' AND type=0");
Change line 609 to:
$DB_site->query("INSERT INTO useractivation VALUES (NULL,'$user[userid]','".time()."','$user[activationid]',0)");
Steve Machol
Tue 13th Nov '01, 6:40pm
I applied the fix and it works. Good job John!
evoir
Tue 13th Nov '01, 8:16pm
I applied the fix and broke my board LOL! :D
really, I did. I'm assuming this fix will be a part of the new update, right? I'll wait for that. Thanks.
David Bott
Tue 13th Nov '01, 11:28pm
Hi...Also have this issue that I consider a real pain!
Anyway, would liek to try the above mentioned fix, but my line 130 does not look anything like that.
Can you please be so kind to post a change in REPLACE "text" WITH "text" format. Or post the files themselfs.
As mentioned...I do not see why I should replace echo "testing ... \n"; at line 130.
Please help.
Steve Machol
Tue 13th Nov '01, 11:44pm
It sounds like you're not running the default admin/email.php from 2.2.0. Reupload that file and line 130 will be exactly as John has shown.
bikeboy
Wed 14th Nov '01, 12:19am
I will be applying this fix tomorrow.
Thank you, we were a bit perplexed as to why a small percentage of users could not activate their accounts
David Bott
Wed 14th Nov '01, 11:27am
Thank you....Looking good thus far. And we get a lot of new members. :)
wastegate
Wed 14th Nov '01, 6:29pm
Yeah I've applied this fix and I havn't had anyone email me with problems thus far. Cheers.
Black Tiger
Wed 14th Nov '01, 6:47pm
In "register.php" in the part ### start activate ### there is also a line:
// delete activationid
$DB_site->query("DELETE FROM useractivation WHERE userid='$userinfo[userid]' AND type=0");
I presume we don't need to change $userinfo[userid] to $user[userid] in this line?
David Bott
Thu 15th Nov '01, 12:37pm
Hi...Sorry to report I am still getting some users saying the activation code did not work. When I look at their account, they indeed show up as REGISTERED. Not 100% fixed as of yet.
SFishy
Thu 15th Nov '01, 12:45pm
I applied this fix last night... I will have to keep you posted on whether it works or not... I haven't received any complaints from users yet, but that doesn't mean I won't... I'll have to give it a few days.
Hope this does it *fingers crossed*
John
Thu 15th Nov '01, 12:51pm
David,
If they are in the registered group, then their registration code will not work - it only works if they are in the 'waiting email confirmation' group.
John
David Bott
Thu 15th Nov '01, 12:55pm
John...True. But part of this bug is when a member registered it sometimes puts them into the REGISTERED group and not the WAITING group.
Thus all the members that send me messages in the past about it not working was indeed already in the REGISTERTED group even though they just registered.
Like the one I just received today that say he can't activate (signed up today). I looked, and he was already in REGISTERED status. Thus the failure.
Note...I would get about 8 a day like this. This is my second from when I applied the patch.
ethank
Fri 16th Nov '01, 9:50pm
I too had this problem with 2.2.0, users showing up in registered.
Ethan
David Bott
Fri 16th Nov '01, 11:30pm
Yes...4 more today!!! Please RE-LOOK INTO THIS before the final of the 2.2.1 replease!!!!!!
David Bott
Sat 17th Nov '01, 11:18am
Another 6 this AM. :(
John
Sat 17th Nov '01, 12:52pm
David,
I am not sure how this could be happening, and I have looked over the code several times. They will always go into the 'email verification' group no matter what. I don't think that is the issue at hand, unless you can prove otherwise.
So I think that the variable that is coming into play is the user - if they click on the link to activate their account, and the page doesn't load (or loads slowly), they might not see any effect and click on the link again. If the first request was sucessful, that would mean that they would be moved into the registered group sucessfully, but would not see this, and when they load the page a second time, they would see the error, because they would already be in the registered usergroup.
I think that is the only explanation for now, as I have looked over the code several times, and I cannot see how anything else could be happening.
John
Joshua Clinard
Sat 17th Nov '01, 2:26pm
Maybe you could add something in the e-mail that would tell users to ONLY click on it once, even if it loads slow, or appears not to work. I have seen several sites that say this on thier credit card processing forms, and that pretty much solves the problem. So maybe in the final release we can have that in the e-mail, or we could just add it ourselves, but I think it would be better if everyone got the benefit.
David Bott
Sat 17th Nov '01, 5:10pm
Thanks John...However I find it hard to believe all these people are doing the same thing. Each one reports they click the link and got the error. I look at the account and I find then already registered.
Suggesttion....Make the code look them up first or something and respond accordingly. Pondering.
clearchanel
Sat 17th Nov '01, 7:15pm
I have registered at least 6 times myself. Each time, I receive the activaction code, check the queue, I am not there, I check the new registrations, and there they are, already registered.
My problem is, I do not allow new registrations the same level of access as my other members. I have trolls who register, just to torment established members, so when they do register, they are manually placed in the junior member usergroup, and you be suprised how many never bother to post because they can't use private messages.
I can confirm this is also a problem in 2.2.1 as well
Can this have anything to do with cookies. I have my profile as admin, set not to automatically log me on, and do not browse board with cookies, yet I can not log out of the board in MSIE?
Thanks
freehtml
Thu 22nd Nov '01, 2:27am
I seems to have this problem too.........and 76 user till now...
Here are some of the complaints
"We could not activate your account because this web
address is not valid. Make sure that you have the
entire address from the email, and that your email
client has not split the address over several lines."
I think when they used the lost password features, the passsword is not shown also
David Bott
Thu 22nd Nov '01, 8:56am
Okey, at least another 14 from my last post.
Hello....Anyword? Bluer?
John
Thu 22nd Nov '01, 9:08am
David,
Could you email me with login (vBulletin/FTP) usernames and passwords so I can take a look at your forum? This bug is still perplexing me!
John
David Bott
Thu 22nd Nov '01, 9:26am
John...Happy to talk via via phone first and give info that way. Nothing personal, but I do not know you and it is just the network security part in me. (I am Director of IS for the local Police, Court Justice, Fire Dept, and Library. Thus a little weird when in comes to security. LOL)
Please e-mail me your phone number and I will be happy to call.
HAPPY TURKEY DAY.
clearchanel
Thu 22nd Nov '01, 9:55am
Originally posted by David Bott
Please e-mail me your phone number and I will be happy to call.
HAPPY TURKEY DAY.
I'm sorry, but I could not resist. Being very interested in a fix myself I keep close track of this thread. But.............
John lives in England.........
David Bott
Thu 22nd Nov '01, 10:18am
Did not know that. <Bonk>
Well then we do have an issue then don't we?
I am not the only one with this issue...as can be read above. Thus the issue is not with my server or code.
clearchanel
Thu 22nd Nov '01, 10:32am
There is a bug fix posted addressing many of the problems experienced with new registration and lost passwords. you need to fix two templates. You can find it here:
http://www.vbulletin.com/forum/showthread.php?s=&threadid=32661
David Bott
Thu 22nd Nov '01, 11:13am
clearchanel...Thank you...but if you read this thread, this has NOTHING to do with the fix you just listed.
Steve Machol
Thu 22nd Nov '01, 1:16pm
David,
Would you trust putting the login information into an official support ticket? If so, then go here:
http://www.vbulletin.com/members/support.php
clearchanel
Thu 22nd Nov '01, 1:23pm
Originally posted by David Bott
clearchanel...Thank you...but if you read this thread, this has NOTHING to do with the fix you just listed.
It sure does. I had the problem with the error message telling me the link was split. I copied and pasted the link from the email message, and received the same error. I edited the two templates I mention above, and no longer had the problem.
I was also receiving an error telling me the request for password was over 24 hours old, even thought, I myself requested the password less then five minutes ago, but that was another fix.
David Bott
Thu 22nd Nov '01, 4:33pm
smachol....Sorry to say I I feel no need to make a ticket for it for it has been proven by others and even a fix made that does not seem to fix the entire issue. Thus the developers know all about it and no ticket is needed.
clearchanel....THey have nothing to do with the registration process at all which is the issue at had. They are e-mail templates. The issue is...sometimes when a person registered they are put into REGISTERED status and not in the waiting area.
David Bott
Thu 22nd Nov '01, 4:36pm
Case in point....
"Hi,
I'm trying to register on the forum, and my account fails to activate. I've tried clicking on the links in the email I sent, copying the links into the browser address bar, and using the activation form on the website. Nothing works.
my email is korrell@vt.edu, user name is korrell, activation code I was sent is 77921235.
thanks,
Kim Orrell"
I look, they are already set as REGISTERED and the code in not in the waiting area.
Steve Machol
Thu 22nd Nov '01, 4:41pm
Originally posted by David Bott
smachol....Sorry to say I I feel no need to make a ticket for it for it has been proven by others and even a fix made that does not seem to fix the entire issue. Thus the developers know all about it and no ticket is needed. Sorry but no one is denying there's a problem. I just assumed you wanted John or someone at vBulletin to look at it and try to fix it. As John said this bug is perplexing him and to try and fix it he'll need access to your forums. It's your choice, of course, but if you don't want to provide that then all this does it make it much more difficult to do to fix the problem.
David Bott
Thu 22nd Nov '01, 4:54pm
"I just assumed you wanted John or someone at vBulletin to look at it and try to fix it. "
They have been. They know their is an issue. I would be happy to work with John on it, never said I would not. In any case, it is happening as reported but not just me or my server.
Steve Machol
Thu 22nd Nov '01, 5:06pm
And all I was offering was another option for you to provide John with the info he needs to help resolve and fix the problem.
sifuhall
Thu 22nd Nov '01, 5:41pm
Let's not forget there are many others of us that are also experieincing this problem . . .
Steve Machol
Thu 22nd Nov '01, 6:02pm
Who's forgetting? :confused: I was merely offering an alternative method for David to provide the information John was asking for so he could try to fix this problem.
tubedogg
Thu 22nd Nov '01, 10:46pm
Keep in mind that servers are not all the same, and although a bug may be occuring on some of them, it is not always reproducible on others which is why access to other servers like John asked for is invaluable in diagnosing the exact source of the problem sometimes.
David Bott
Thu 22nd Nov '01, 11:29pm
I can agree with some of that statement. But surely not in this case. The code puts the data in place, nothing else. The server does not say..."Hey, lets put this here in this table just for fun." Something is saying to put it their. Some combination. One person said he did it like 6 times, each time it put the data in the wrong table. This is the one to look at I would think.
I would think some of us see it more because are sites are maybe more active or have this thing turned on in the first place.
freehtml
Fri 23rd Nov '01, 12:40am
I had turn off the Email verification option as well as redownload version 2.2.1 again today...and don't know whether it will help or not.
John
Fri 23rd Nov '01, 4:42am
Please would someone who is having this problem get in touch with me by email so that I can discuss this with them and look at their server in detail.
Thanks,
John
Fusion
Fri 23rd Nov '01, 5:37am
John,
I waited and did the upgrade when you finally said it was out of beta, then went ahead and specifically tried to get the same problem. I'm happy to report that they work nicely.
powerforen.de
Sat 24th Nov '01, 1:16pm
Same Problem!
Please Help John
unixman
Sat 24th Nov '01, 10:10pm
I am having the same problem as David.
They send me a complaint e-mail, I pull up their account, and they are already registered. I created a test account, and it seemed to work for me, but it doesn't appear to work for everyone. Very strange.
Running 2.2.1 with only Tubedogg's stars hack ...
Cheers.
Scott
CoolaShacka
Sun 25th Nov '01, 3:15pm
I have also this Problem on my Board.
what do now?
:confused:
tamarian
Sun 25th Nov '01, 4:48pm
I think what happens is the first time they click the activation link, it does activate the account, but it redirects to the main forum page without the activation template being displayed.
In this case, the user clicks again, but it fails (since they are activated) and displays the invalid activation template.
For those who need a workaround, simply edit the error_invalid_activation template and add a note:
NOTE: This error will also occur if you click this link more than once. Your account may have already been activated. To make sure, try to post a message in our test forum, and enter your user name and password. If it works, you are now a new registered member. If you still have a problem, please continue reading for more details.
Or something like the above, and make it BOLD!! This has reduced the emails I get significantly.
David Bott
Sun 25th Nov '01, 4:56pm
tamarian...Very nice idea! I have added your text. (Just wish they would find this little bugger.)
I still think they should also do a quick look up in the user file and if the code is set at 3 ("Registered" I think) then tell them they are all set before the error message.
tamarian
Sun 25th Nov '01, 5:41pm
Originally posted by David Bott
I still think they should also do a quick look up in the user file and if the code is set at 3 ("Registered" I think) then tell them they are all set before the error message.
I think this is a very easy hack!
I went to the code to see where to put in this hack (if usergroup=3 eval template activation successful blabla...) But I found there's no such template!
The code in register.php does exactly what I described in the bug behaviour, it redirects to main forum index when successful without notice!!! You can only spot the thank you if you have a slow connection or slow browser.
} else {
// activate account
$DB_site->query("UPDATE user SET usergroupid=21 WHERE userid='$u'");
$username=$userinfo[username];
eval("standardredirect(\"".gettemplate("redirect_registerthanks")."\",\"index.php?s=$session[sessionhash]\");");
}
A quick fix, I think, would be to create a new template activattion_successful and write "you are now a registered member, click here to go back to the forums.." and reference the template in the code above without redirect and exit.
David Bott
Sun 25th Nov '01, 5:49pm
Tamarian....I think you are on to something. Maybe this is the answer.
Not sure, but I also thought there were reports from others in this thead that it actually put the new member into registered status right when they registered and they were never even in waiting status. But I could not confirm that so I feel you may be on to something.
As mentioned...a quick lookup to see their status might be in order.
tamarian
Sun 25th Nov '01, 6:04pm
Originally posted by David Bott
Not sure, but I also thought there were reports from others in this thead that it actually put the new member into registered status right when they registered
Not in my case. I just registered as a test user and I get put into "user awaiting". I think otheres thought so, because when the user complains, they find they are "registered", simply because of the error the user reports.
I just did a comparison between register.php from 2.0.3 and 2.2.1 and one significant change is that 2.2.1 deletes the activation code when the user first clicks the link. Now when they click a second time, they never get the error template that says "already activated".
I'll test again by commenting out the activate deletion code and see what happens. But would be nice if one of the developers could confirm this or if I'm way off the track here. :)
Good thing today is a Sunday and low-traffic. I can usually test things on my test server except for functions requiring email, so I'll have to test on the real forum, and hope for the best.
John
Sun 25th Nov '01, 6:46pm
From this post (http://www.vbulletin.com/forum/showthread.php?postid=206742#post206742):
So I think that the variable that is coming into play is the user - if they click on the link to activate their account, and the page doesn't load (or loads slowly), they might not see any effect and click on the link again. If the first request was sucessful, that would mean that they would be moved into the registered group sucessfully, but would not see this, and when they load the page a second time, they would see the error, because they would already be in the registered usergroup.
:rolleyes:
I am still looking into this, but I think that it what the issue is.
John
tamarian
Sun 25th Nov '01, 7:00pm
Originally posted by John
:rolleyes:
I am still looking into this, but I think that it what the issue is.
John
Not true, at least not in my case.
Try to generate a case where the user would get the template "Already registered...." The user never gets it, unless you comment out the delete query for activation code.
The problem isn't slow browsing, more like fast browsing, the use has to spot the message in the redirect code when activation is successful, if they don't spot it, they try again and get "wrong code" because their activation record is deleted.
I did the following and it fixed it
Find in register.php:
$DB_site->query("DELETE FROM useractivation WHERE userid='$userinfo[userid]' AND type=0");
Replace with:
// $DB_site->query("DELETE FROM useractivation WHERE userid='$userinfo[userid]' AND type=0");
I'd prefer to remove the redirect and replace with a template, but the above is less work.
unixman
Sun 25th Nov '01, 9:19pm
This is a great idea, but it isn't the final answer on this one. The bottom line is, that this started when I installed 2.2.1 - I have over 5,000 members, and have never received a complaint from a new user regarding this issue until then ... :(
Black Tiger
Mon 26th Nov '01, 8:35am
Well.... In my case I've 2.2.1 running, and still have both problems.
1.) New users get the "registered" status without validation, but the "user title" in the users account which after validation gets set to "registered user" says now "waiting" and nothing else.
So there definitaly is something wrong with this process.
2.) Users who forgot their password use the link "forgot password", they get a link per email which they should visit to reset their password, this looks like:
To reset your password, please visit the following page:
http://www.satellitefun.org/bbs/member.php?a=pwd&u=3053&i=43209480
The "u" and "i" is a little editted by me.
But when clicking the original link, one get's to the login screen of the board, not to a "reset password" page.
I'm slowly getting enough of this bug it's costing me users.
Is it possible to downgrade to 2.03? I'm thinking about that.
sifuhall
Mon 26th Nov '01, 8:54am
I thought about downgrading as well (I'm losing people too), but I don't think that will be possible as the passwords are now an md5 hash.
SFishy
Mon 26th Nov '01, 9:36am
I just wanted to chime in and say that I upgraded to 2.2.1 hoping it would fix this bug and it didn't. I am still getting users who tell me the activation link "doesn't work" -- and when I look them up, they are already registered.
Seems to me the best thing to do is put the activation code back the way it was in 2.0.3. I think a lot of us would agree it was working fine right up until 2.2.x
And I agree with the sentiment of some others who thought of downgrading, but of course that's not an option after running a few weeks on 2.2.x because of one-way encryption.
Please get this fixed.
ToraTora!
Mon 26th Nov '01, 11:23am
thank God i am not the only one that this is happening to.
Reason being, is that last night i changed my password as part of my bi-weekly past regiment of habits, and guess what? I forgot it today. Needless to say, i was confronted with the screen I will now choose to name, the screen of death 2, in which it asked me for my email address, so it could send me the information needed to resolve the situation.
Well, I get the email, and in there is the link, that should take me to the log in screen, to overide my old password, and let me gain the new password i enter, but guess what>? It wouldnt let me.
I was directed to the log in screen, where time and time again, i tried to enter, however, recieved a continous "nopermission" template that in time, i am going to completely burn as a direct result of this bs.
So, as a admin of my board, as I sat blankly, thinking of a quick solution to this problem, I thought "hey, i can go into my phpadmin, and find it ....ah...no, i cant...its encrypted...."
of course, i could of edited the user table, with my name in it, but that would be morally wrong wouldnt it...?
All i have to say, is thank god i set up another person as a administrator, because he had to go into the control panel, and litteraly enter in a new password for me, so i could log into my own ****ing board.
Nice huh? how is this going to resolve any situations, about admin not knowing user passwords, when you have to go into the password field anyways, and enter in their new password?
Just imagine the guy who have a numberous amount of members, who change thier passwords, and than get the same thing i did for a message....
Im so pissed rite now i cant even describe it.
Whatever the reasons for this encryption, it does not match to the overall frusteration of setting us back a month in development, and future opening date.
If there is anybody that would care to take a crack at a possible explanation, please, by all means, let me know, because i cannot expect my users to go through this, when it is almost common practice on our board to change passwords every month.
powerforen.de
Mon 26th Nov '01, 12:27pm
Here the Fix
template: standardredirect
change
<meta http-equiv="Refresh" content="1; URL=$url">
to
<meta http-equiv="Refresh" content="10; URL=$url">
and the problem is fixed !!!
Thanks Afterburner ;-)
tamarian
Mon 26th Nov '01, 12:44pm
Originally posted by powerforen.de
and the problem is fixed !!!
But, I think, this will slow all redirects, like post reply, edit profile, new thread, etc.
ToraTora!
Mon 26th Nov '01, 2:45pm
actually, it does slow the redirects down, and the worst case, is when a person recieves a pm, On occasion, it gives errors, due in part it is trying to refresh, while there is a pm message, which is basically executing two java scripts at one time.
I have pretty much decided that if there is no true quick fix to this, im going back to the $password variable that i took out in both template changes, and leaving it at that.
ToraTora!
Mon 26th Nov '01, 3:05pm
well, the $password variable is no longer available, or functional. Nice...real nice.
ToraTora!
Mon 26th Nov '01, 3:06pm
might add, the refresh hack above, does nothing to help the overall 'forgot password' or 'validate password' either.
Joshua Clinard
Mon 26th Nov '01, 3:25pm
It's been a while since any developers have participated in this thread.
tamarian
Mon 26th Nov '01, 3:26pm
Originally posted by ToraTora!
might add, the refresh hack above, does nothing to help the overall 'forgot password' or 'validate password' either.
I think we're mixing bugs here :)
The activation code for new registrants is one problem (thread title), the other problems discussed may not be related and might actually be another bug?
I've only had the activation problem (fixed by commenting out the deletion line).
The various behaviours exhibited here may be due to different registration/email/passowrd options chosen.
ToraTora!
Mon 26th Nov '01, 3:38pm
Originally posted by sifuhall
I thought about downgrading as well (I'm losing people too), but I don't think that will be possible as the passwords are now an md5 hash.
there is a script that takes md5 out, but truthfully im not all that interested in taking it out now.
Simply put, we cannot open yet due to this little problem, because of the moderate new users, and the email problem that is totally pissing me off.
John
Tue 27th Nov '01, 9:19am
To fix this issue, please edit register.php, line 571:
Change it to:
eval("standarderror(\"".gettemplate("error_activatedthanks")."\");");
And then add a template called error_activatedthanks:
$username, you have now successfully activated your account. Please click <a href="index.php?s=$session[sessionhash]">here</a> to return to the main index.
Also, move this code:
$user=$DB_site->query_first("SELECT activationid FROM useractivation WHERE userid='$userinfo[userid]' AND type=0");
if ($i!=$user[activationid]) {
// send email again
eval("standarderror(\"".gettemplate("error_invalidactivateid")."\");");
exit;
}
// delete activationid
$DB_site->query("DELETE FROM useractivation WHERE userid='$userinfo[userid]' AND type=0");
To below this line:
if ($userinfo[usergroupid]==3) {
So you will finally get (lines 543-574):
if ($a=="act") {
// do activate account
$u = intval($u);
$userinfo=verifyid("user",$u,1,1);
if ($userinfo[usergroupid]==3) {
$user=$DB_site->query_first("SELECT activationid FROM useractivation WHERE userid='$userinfo[userid]' AND type=0");
if ($i!=$user[activationid]) {
// send email again
eval("standarderror(\"".gettemplate("error_invalidactivateid")."\");");
exit;
}
// delete activationid
$DB_site->query("DELETE FROM useractivation WHERE userid='$userinfo[userid]' AND type=0");
if ($userinfo[coppauser] or ($moderatenewmembers and !$bbuserinfo['posts'])) {
// put user in moderated group
$DB_site->query("UPDATE user SET usergroupid=4 WHERE userid='$u'");
eval("standarderror(\"".gettemplate("error_moderateuser")."\");");
} else {
// activate account
$DB_site->query("UPDATE user SET usergroupid=2 WHERE userid='$u'");
$username=$userinfo[username];
eval("standarderror(\"".gettemplate("error_activatedthanks")."\");");
}
} else {
That should then solve the issues people have been having with people clicking on the links too many times.
Attached is the register.php file with the bug fixes in, if you prefer.
John
sifuhall
Tue 27th Nov '01, 10:48am
I'll implement right away.
Thanks a million!
SFishy
Tue 27th Nov '01, 11:24am
I've applied the bug fix -- *fingers crossed* that it works :)
JJR512
Tue 27th Nov '01, 1:45pm
John, the attached register.php does not reflect the changes you specified.
linuxman25
Tue 27th Nov '01, 5:53pm
I have the same exact problem that Axel is having. It's a linux box.
Problem does NOT exist on win32 box. wassup?
linuxman25
Tue 27th Nov '01, 6:14pm
downloaded the register.php, uploaded it, made the new template, still same exact error as Axel......this is wacked!
Freddie Bingham
Tue 27th Nov '01, 6:36pm
Try his attachment again, I replaced it with what is in CVS so if that doesn't work than his fix doesn't work (perhaps) ;)
SneakyDave
Tue 27th Nov '01, 6:38pm
I made the fixes by hand and they seemed to work for me. I only added the new template to the Default template set, because new users shouldn't be able to change from the Default when registering. Thanks
linuxman25
Tue 27th Nov '01, 9:32pm
Your telling me that this new register.php and adding that new template fixes this problem below? well, it didn't work for me::
1) I logged out from the forum to delete the cookies
2) On the login page, I clicked on the FORGOTTEN PASSWORD link
3) A mail has been sent to me (you can find the generated mail attached)
4) I clicked on the link provided in the mail
5) I have been redirected to the LOGIN page
6) If I press the LOGIN button it tells me WRONG PASSWORD
7) If I enter my OLD password it works, and vB tells me: "Your password has now been reset and emailed to you. Please check your email to find your new password. To change your password, please use this form.".
8) The email arrived me correctly (have attached it to this one)
It resets my password ONLY after I have clicked on that link in the mail AND after I've logged in with my old password. Obviously, if I really forgot my password I couldn't login so I couldn't reset my password.
So the problem appears to be that after clicking that URL the forum wants you to LOGIN, but in that phase the user DOESN'T KNOW his password anymore (he forgot it). It shouldn't ask you to login, but it should reset the pw immediately, I suppose.
tamarian
Tue 27th Nov '01, 10:59pm
FYI, even the one from CVS doesn't reflect the changes posted by John. You might as well just do the edits.
I think folks who have problems with resetting passwords, should pay attention to a previous post from John regarding global.php. These are two different bugs. The fix posted here was in regards to activation for newly registered members, it has nothing to do with passwords. If you update global.php and still have a problem, it maybe better to create a new thread so developers can look at it.
To make things more interesting, I now have a new problem :) When a user updates their email, it is automatically accepted, they never go into "user awaiting" status, even when my options require email confirmation.
tubedogg
Tue 27th Nov '01, 11:10pm
Originally posted by tamarian
To make things more interesting, I now have a new problem :) When a user updates their email, it is automatically accepted, they never go into "user awaiting" status, even when my options require email confirmation.Are they in the 'registered' group (groupid 3) to start with?
tamarian
Tue 27th Nov '01, 11:30pm
Originally posted by tubedogg
Are they in the 'registered' group (groupid 3) to start with?
All groups, including myself as admin, and my test user, newly registered (id = 21). They simply get assigned whatever user group they were.
Note that my forum is heavily hacked. I just wanted to check if those of us who had the activation problem, also experienced this?
tubedogg
Tue 27th Nov '01, 11:39pm
I'm not sure if you mean the user has a userid of 21 or if the groupid is 21 - I'm speaking of the groupid which by default for registered members is 2 (not 3, sorry).
If they are not in the registered group, groupid 2, or groupid 3 (Users Awaiting Email Confirmation) they will not be moved from their current group when they change their email address.
ToraTora!
Tue 27th Nov '01, 11:43pm
Originally posted by tamarian
FYI, even the one from CVS doesn't reflect the changes posted by John. You might as well just do the edits.
I think folks who have problems with resetting passwords, should pay attention to a previous post from John regarding global.php. These are two different bugs. The fix posted here was in regards to activation for newly registered members, it has nothing to do with passwords. If you update global.php and still have a problem, it maybe better to create a new thread so developers can look at it.
To make things more interesting, I now have a new problem :) When a user updates their email, it is automatically accepted, they never go into "user awaiting" status, even when my options require email confirmation.
listen, im not getting on your case about this, but how many times do you think most of us have read those posts, and changed things...i mean, there is a problem, and these situations are somewhat connected.
Now, most of my problems are exactly identical to linuxman25 troubles, rite to the "T" actually. This is obviously something that should be addressed, because there are going to be times that people will forget thier passwords, and than what?
I myself fell victom to this problem, and if i wouldnt of had another admin setup, I can tell you my tone in this thread would be quite a bit different. Changing a password in the usertable, in phpmyadmin, does absolutely nothing as I found out the second time I tried "fixing" this problem, and once again had to contact my other "Admin" so he could add a password to let me in my own forums.
By far, combining these problems together, are beneficial, rather than keep everything sepearted, when in reality, they are almost based off the same format, of users and passwords.
tubedogg
Tue 27th Nov '01, 11:46pm
The problems are only linked syntaxically in that the URLs both use i and u in them...other than that they are in two separate files and never interact with each other. Please see this thread (http://vbulletin.com/forum/showthread.php?s=&threadid=34286) for discussions on the lostpw problem.
ToraTora!
Wed 28th Nov '01, 12:04am
tube, the link you provided, is the same thread we are in rite now.
ToraTora!
Wed 28th Nov '01, 12:05am
nevermind, you got it...:)
tamarian
Wed 28th Nov '01, 12:28am
[QUOTE]Originally posted by ToraTora!
listen, im not getting on your case about this, but how many times do you think most of us have read those posts, and changed things...i mean, there is a problem, and these situations are somewhat connected.[/QUOTE
Tora, that's o.k. you can get on my case as much as you like :) When there's a bug, it's just frustrating. However, it is extremely beneficial to the developers to seperate each manifistation of the problem. It helps narrow down the cause(es).
Kevein, I think in your split of the thread you may have lost our tangent discussion about changing email, not requiring activation?? As I said in a possibly lost post :) My forum is heavily hacked, so it might just be my problem. But it would be helpful if some one could confirm that chanhing email addresses works when email confirmation is required (i.e. members are moved to "user awaiting email activation" until they confirm by email the new address).
ToraTora!
Thu 29th Nov '01, 6:13am
one thing that has not been adressed i do not think, is if a administrator has the unregistered/not logged in usergroup confronted with the log in screen everytime they vistit the site, or log out.
They need the password, to than get inside the forums, and i think this is where some of the problems are coming in.
I may have missed something, but when a person has the board, set for moderate users, and you have to send them the email, the $password variable, does really no good...now, should a person add the new password link in there instead, or how should one create a template, to allow the user some sort of way, to log into your site, if they have received the confirmation email from the administratior, stating their account has been accepted, and activated?
clearchanel
Thu 29th Nov '01, 6:26am
Originally posted by tamarian
[QUOTE]Originally posted by ToraTora!
[B]
. But it would be helpful if some one could confirm that chanhing email addresses works when email confirmation is required (i.e. members are moved to "user awaiting email activation" until they confirm by email the new address).
I am comfirming it does not work. Once you are registered, you are welcome to change your email address at will. There is no comformation of any kind. There is also little if any any ip logging in the control panel, It's a hit or miss situation, if you need to find a members IP address, you'd be better off searching for a post and checking it there..... How can I back out of 2.2.1????? I like the old 2.0.0 working system much better.......
Fusion
Thu 29th Nov '01, 6:29am
Originally posted by tamarian
Kevein, I think in your split of the thread you may have lost our tangent discussion about changing email, not requiring activation?? As I said in a possibly lost post :) My forum is heavily hacked, so it might just be my problem. But it would be helpful if some one could confirm that chanhing email addresses works when email confirmation is required (i.e. members are moved to "user awaiting email activation" until they confirm by email the new address). [/B]
If you need a re-validation when changing addresses, won't that require another flag separate from what usergroup the person is in, to indicate it's really a registered member, and not a new member?
ToraTora!
Thu 29th Nov '01, 6:58am
and yes, that last thread looks and reads like a third grade essay, but im half asleep here...:)
Fusion
Thu 29th Nov '01, 7:02am
Originally posted by ToraTora!
and yes, that last thread looks and reads like a third grade essay, but im half asleep here...:) 3rd grade? You flatter yourself. :D
ToraTora!
Thu 29th Nov '01, 7:25am
Originally posted by Fusion
3rd grade? You flatter yourself. :D
thread....what thread??? :D lol...i got it figured out...need more sleep, or more caffeine....lol...
ToraTora!
Thu 29th Nov '01, 7:33am
Basically, I uploaded the admin/email.php file from 2.2.1, as well as the register.php file that was provided in here, and have no problems what-so-ever in my 2.2.0 board.
Great work once again, from the VB staff.
evoir
Thu 29th Nov '01, 1:26pm
I changed my register.php file to John's new file, I added the new template. I logged out and created a new membername.
I got sent an email to confirm my membership, When I clicked on the link in the email, I got the new template, and clicked the link to go to the forums home page, and the main forum page welcomed the admin username, not the new username. very weird....
Just realized, I had logged out in IE, but when I clicked the link to activate the account, it opened Netscape, which I musta still been logged in. But, I would think the system should know that I registered under a new username and should recognize the new user. :confused:
evoir
Thu 29th Nov '01, 1:38pm
Honestly, I liked it before the passwords were encrypted.
I used to occassionally login as a user, when they were having trouble, and make sure that what they explained they were seeing was really the problem. Or, they were saying they couldn't login, but I would test it and see. Can't do that easily anymore.
I liked being able to send the user their password via an email (and not an email that gave them a link that they had to click and then a new password would be emailed to them, which gave them directions on how to change their password. whew!) 5 steps instead of 1 or 2
[btw, I just went through thiose steps to reset my password, and the system keeps telling me I have the wrong password :( ]
What about a different way of thinking about this: what about only encrypting the admin passwords, not everyones?
evoir
Thu 29th Nov '01, 1:43pm
ok, another thought about the password. The reason it keeps telling me I ahve the wrong password, is that the link that is sent does NOT correspond to a specific username, and if you are already logged in (or someone else is logged in via that computer) it does not recognize the new user via the link.
I was still logged in via the admin username, but the system sent me an email on how to change my password for a different username. (same as before, logged out via IE, but clicked link and it opened Netscape). I would think it would be important to attach a username to the link, to make sure that this confusion doesn't happen to newbies.
I want the old system back :(
Joshua Clinard
Thu 29th Nov '01, 5:25pm
Can we start a seperate thread for the following bug, that has been confirmed by David and others:
When a user registers, he/she is put into the registered users group, instead of the awiating e-mail confirmation group
Thanks
tamarian
Thu 29th Nov '01, 5:38pm
Originally posted by clearchanel
I am comfirming it does not work. Once you are registered, you are welcome to change your email address at will. There is no comformation of any kind.
Thanks for the confirmation, I thought it was just my board.
Mods, could we split this into another separate thread as a bug "Change email accepted without confirmation"??
John
Thu 29th Nov '01, 6:51pm
I think that the bug that this thread originally set out to fix has been solved. Please start other threads for other bugs.
Thanks,
John
vBulletin® v3.7.3, Copyright ©2000-2008, Jelsoft Enterprises Ltd.