[fixed] showgroups.php error...again...

[JJR512]

On my show forum leaders page, and even on the one here, there is a problem with the tables of the Show Forum Leaders page. In the last table, for the Moderators, in the Location column, only the PM link shows up. You can tell there is an extra empty column there. The location is missing.

Sorry the thread subject says email link, my fault.

[JJR512]

I have one other little complaint about the Show Forum Leaders page. You may recall that prior to 2.2.1, I posted that the group title Super Moderator was hard-coded into the code, so if I had a different name for that group, it didn't show up there. John mentioned that it would be fixed, and it is fixed...except for one little detail. For the groups that I have a custom name, there is no 's' at the end of the title, to indicate it's plural... For example, for my Administrator group, it says "JJR512.com Bulletin Board Administrators," but for my Super Moderator group, it says "JJR512.com Bulletin Board Assistant Administrator". Is there some way the script could be modified to apend that pluralizing 's' on the end of custom-named groups?

[Fusion]

Better yet, and I realize this might add a slight overhead... Make it append the plural form if there's more than one person in that group.

[tubedogg]

The problem with auto-appending an 's' is sometimes the group may already have an s...or maybe it shouldn't have an s...etc.

[JJR512]

What about the main issue here?

[tubedogg]

Did you get rid of the location field at some point in the past and then re-add it?

[JJR512]

Not unless whoever runs the vBulletin Community Forum (this forum) did the exact same thing: http://www.vbulletin.com/forum/showgroups.php?s=

[tubedogg]

It's a bug.

The fix is in showgroups.php line 159. Find
$fieldselect
and change it to
$locationfieldselect

[Fusion]

Originally posted by tubedogg
The problem with auto-appending an 's' is sometimes the group may already have an s...or maybe it shouldn't have an s...etc. So add a check for that and do the smart thing when it checks out, anyhow, 'twas just an idea.

[John]

Attached is a script that fixes the above two errors.

The fix for the location field is included above.

The fix for the 's' issue is too long to post.

John

[tubedogg]

Just posting this in case anyone else gets confused like I was at first. :D

The file he attached is a new version of showgroups.php with the two bugs fixed in it. Just upload it to your server, overwriting the current showgroups.php file that is there now.

[rebby]

this fix must not have been put into 2.2.1? i noticed the location thing after my upgrade and found this thread when i went to post about the bug (i did end up finding it before reading this ;) )

[tubedogg]

This bug fix was released after 2.2.1 was released; you can fix it on your installation by downloading the file in John's post and uploading it to your forums.

[Ikram]

Originally posted by tubedogg
It's a bug.

The fix is in showgroups.php line 159. Find
$fieldselect
and change it to
$locationfieldselect

Can someone pls attach showgroups.php after the big fix as I cant find $fieldselect - not having 'textpad' doesnt help either! :(

[tubedogg]

Look 4 posts above this one. :)

[Ikram]

Thanks Tube dog

I should learn to read the threads properly! :o

[tubedogg]

np :)

[Bedhead]

I have tried everything including the attachment here, but still get this error:
Fatal error: Maximum execution time of 30 seconds exceeded in D:\Inetpub\users\dssheadquarters\forum\admin\funct ions.php3 on line 587

Fatal error: Maximum execution time of 30 seconds exceeded in D:\Inetpub\users\dssheadquarters\forum\admin\funct ions.php3 on line 2263

Can anyone help, please.

[Bedhead]

^^^UP^^^

[tubedogg]

Is this when you are trying to view online.php? Try disabling IP resolving (under Admin CP > vBulletin Options > Who's Online > Resolve IPs).

[Bedhead]

No.

This is what I get when I try to access forum leaders.

Any ideas?

[John]

What hacks are you running? My version of functions.php does not even have a line 2263!

John

[Bedhead]

I am running:

The passord hack for 2.2.1,
Contract/Expand Posts for 2.2.1,
Show post numbers for 2.2.1,
Who's Online for 2.2.1,
Statistics for 2.2.1.

Any ideas?

[Fusion]

Bedhead, hacked installations are unsupported. John&Co. can't be expected to support any and all possible variations of installed hacks.