PDA

View Full Version : [fixed] Found little bug in style.php from version 2.2.0


Black Tiger
Fri 2nd Nov '01, 1:42pm
Found a little bug.

File /admin/style.php

line: 212 (if I counted correctly)

There are some line's with the word "style" in it, one of those words has a typo and says "stlye".

So only a typo bug.:)

Chen
Fri 2nd Nov '01, 1:49pm
Yup, line 210 for me. :)

Kaizen
Fri 2nd Nov '01, 1:49pm
Originally posted by Black Tiger
line: 212 (if I counted correctly)


you didn't. Did you ?

Count every line. I dont have time to do that?

CoolaShacka
Fri 2nd Nov '01, 1:57pm
Originally posted by Kaizen
you didn't. Did you ?
Count every line. I dont have time to do that? they are some proffesional editors out there.
some like Editpad (http://www.editpadpro.com/editpadlite.html)

eva2000
Fri 2nd Nov '01, 1:58pm
just do a ctrl-f in the file for stlye

holev
Fri 2nd Nov '01, 2:18pm
lol :D
counting lines = BAD

Kaizen
Fri 2nd Nov '01, 2:18pm
Originally posted by CoolaShacka
they are some proffesional editors out there.
some like Editpad (http://www.editpadpro.com/editpadlite.html)

I know.

But the post said he counted.

Black Tiger
Fri 2nd Nov '01, 2:27pm
Come-on guys, I normally don't count lines and I normally don't do programming or such things, so I don't need any editors with linecounting.

In fact, when changing things I use the search function which is even quicker.
Now the error message said line 212, and that's not much so whithin 20 secs I had counted the 212 lines, but the type stood a lit lower so I thought I had miscounted that's why I wrote the "if I'm not mistaken".

I thought you guys where smart enough to just search for stlye in stead of taking a line editor and seeing when the line passes.:)
And searching is smarter because there could be more "stlye" typo's in there and you could have found them if there were. :D

Black Tiger
Sun 4th Nov '01, 4:04pm
I presume this one can get also the status [fixed]?

MiF
Sun 11th Nov '01, 6:58am
Hmm, the actual line is:

$path = "$tmppath/$stlyefile_name";

I don't think fixing the typo affects anything, unless I am mistaken. $stlyefile_name will resolve to an empty string as $stylefile_name would.

$stlyefile_name should be changed to {$stylefile}_name or $stylefile. I don't know what is the intent of the code so I don't know which is right.

MiF
Sun 11th Nov '01, 8:16am
It just occured to me that $stylefile_name is probably posted variable. Ignore my comments in previous post if it's so.