[fixed] Online Users Display

[Marc Smith]

In my 'Online Users' display, I'm now seeing this:

Marc Unknown Location: /Forums/forumdisplay.php?&forumid=23

Instead of it resolving like this:

Marc The Cayman Cove Forums Main Index

Any ideas where I've gone wrong? The upgrade appeared to go smooth. No errors at all. 2.0.3 to 2.2.0, FreeBSD on Apache (virtual server, not virtual host)

http://elsmar.com/Forums/

[chrispadfield]

there appears to be a bug with whos online that we are working on.

[Deyth]

How and where will you announce the resolution to this bug? I want to make sure I don't miss it.

[Freddie Bingham]

I have found that it because your forums directory contains one or more capital letters. I will give you a fix shortly..

[Deyth]

Alright, though in my case I get a blank screen. Is it still the same bug?

http://www.the-combine.net/vbulletin

[Marc Smith]

Not for me. I get a screen - though it sometims takes a minute. For me it's the issue of the display not showing the user activity in a 'resolved' format.

That is to say, instead of seeing something like:

Marc The Cayman Cove Forums Main Index

I see:

Marc Unknown Location: /Forums/forumdisplay.php?&forumid=23

[Freddie Bingham]

Hmm oddly I see such a letter in your url

Marc Unknown Location: /Forums/forumdisplay.php?&forumid=23


If it takes awhile to display then you need to go into the Admin CP and set the option "Resolve IP's addresses on Who's Online" to NO

[Freddie Bingham]

You only need to do this if you have this problem otherwise your Who's Online is and will continue to work as designed.

TO FIX THIS "BUG":

Open online.php

find on line 328:$filename = strtok($loc, '?');change to$filename = strtolower(strtok($loc, '?'));

[Marc Smith]

Nope - not the IP field - it's the Location field. If you want to see what it looks like, go to http://elsmar.com/gif/online-php.gif I'm afraid to link it here as an 'image' because I did a screen capture and it may be kinda big - about 900 x 600 pixels.

I gotta get a shower and make a client meeting in a bit over an hour so I;'ll be gone for a bit - but I'll be back. Hope to figure this one out. I really liked that feature and this kils it for me.I reset the whosonline template, changed the template header and footer back to what I wanted, and the whole schebang.

I is mystified so far... :rolleyes:

[Freddie Bingham]

I have explained the problem and given you the fix so there is nothing else to do if you insisit on debating with me about it instead of implementing what I said to do.

[Marc Smith]

Originally posted by freddie

If it takes awhile to display then you need to go into the Admin CP and set the option "Resolve IP's addresses on Who's Online" to NOYeah. I understand the reason. The load time factor is no big deal. That's one of the joys of log file analysis. Watching it try to resolve IPs that aren't already in it's database.

I have to run. Client meeting. Will try the

line 328:
$filename*=*strtok($loc,*'?');
change to
$filename*=*strtolower(strtok($loc,*'?'));

when I get back.

Thanks!!!

[Freddie Bingham]

What happens is you get an odd user with an ip address that either takes too long or never resolves resulting in a white page.

[Marc Smith]

In my online.php file on line 329 I found:

$filename = strtok($loc, '?');


and changed it to:

$filename = strtolower(strtok($loc, '?'));

Per your directions.

Then, trying http://elsmar.com/Forums/online.php , I got the following notice on my screen:

Parse error: parse error in /usr/local/etc/httpd/htdocs/Forums/online.php on line 329

So - I changed it back to:

$filename = strtok($loc, '?');

[Marc Smith]

Originally posted by freddie

Hmm oddly I see such a letter in your url

Marc Unknown Location: /Forums/forumdisplay.php?&forumid=23
Yes - I did use a capital F in the name. I never saw anything restricting the name to lower case when I installed and have had no problems before now.

[Freddie Bingham]

There is no restriction, I was just explaining that because of that, you would have been affected by this bug.

[Marc Smith]

OK - I appreciate your looking into this.

I will also add my accolades. I have put the board through most of it's basic paces and people have been using it all day. So far, the only real glitch for me so far is this one. Well - I did have one user who 'registered' yesterday but didn't respond to the confirmation e-mail I require until today and had problems. I won't go into details as I don't think there's a problem. I have 'test' registered today and everything went as it is supposed to.

> I have explained the problem and given you the fix so
> there is nothing else to do if you insisit on debating
> with me about it instead of implementing what I said to
> do.

I'm not sure if you were addressing me, but if so...

If I have seemed 'pushy' or anything in my posts in this thread, I do apologise. I think once we were writing/posting at almost the same time and there was some confusion with Deyth's post and 'white page' problem.

I quite well understand bringing out an upgrade is quite a strain and everyone is begging at your pant legs crying for help with their problems. Please don't think for a minute I don't appreciate the software, your quick help when I have needed help, and the over all professionalism of everyone involved.

[Marc Smith]

I noticed you marked this 'fixed'. I'm not sure what you mean by this, but I downloaded the zip again a minute ago - I read in another thread the online.php file had been 'fixed' and is in the 'latest' zip file. It didn't change my problem of Location. I did replace it with the online.php file from 2.0.3 and it functions OK (no jump menu or such, but no more 'Unknown Location' followed by a long url for every user location).

[Freddie Bingham]

Fixed means I know what caused it. That doesn't indicate that you can download the archive and find the "fixed" file in it but you can certainly apply the fix that I listed.

[Marc Smith]

If you mean this fix:

line 329:
$filename*=*strtok($loc,*'?');
change to
$filename*=*strtolower(strtok($loc,*'?'));

That didn't work for me.

[Freddie Bingham]

It worked for the test system that was exhibiting the exact same problems you list. If you wish to send me FTP details to your server I can look at your case.

[JJR512]

There are no capital letters in any of my paths. I have tried the fix mentioned above. I am still having this problem.

[Marc Smith]

Originally posted by freddie

It worked for the test system that was exhibiting the exact same problems you list. If you wish to send me FTP details to your server I can look at your case.I just e-mailed you (through the board here) all the info including server access, admin access to the boards and access to phpMyAdmin. Let me know if you need anything else.

Thanks from an old guy who's not even in the software field who is just trying his best to keep up with technology.

[Maverick1236]

Applied the fix and still have this:

Unknown Location: /upload/forumdisplay.php?&forumid=97

[Freddie Bingham]

I fixed marc's problem by logging in and applying the exact fix that I listed above.

Maverick and JJR512 send ftp login info and an admin account to freddie@vbulletin.com and I will see what your problems are.

[Maverick1236]

my error

tx FREDDIE!!!

[Freddie Bingham]

If you have ANY problems with Who's Online just use the version from 2.0.3 for now.

If your forums are accessible in multiple ways, i.e. www.vbulletin.com/forums/index.php and forums.vbulletin.com/inex.php and you have users actively coming in from both ways than you will see unknown locations. The 2.0.3 version will work fine for you and my attempt to make it easier for you to add support for non-vb pages that include global.php backfires because of this so back to the 2.0.3 version we go.

[floleb7]

with 2.0.3 version there is highlight ?

[Freddie Bingham]

No.

[Marc Smith]

I want to thank Freddie for the help and personal attention.

Yesterday I did try the edit (cited earlier in this thread) on the file with BBEdit on my server directly - I can only guess a cache issue came into play because when I tried the function again, it didn't change anything. Which is why I said the fix didn't work for me.

I am humbled and embarassed. Jeezzz. I must be loosing it when I can't change one line of code in a file correctly. :(

Again, Thank You Freddie! I apologise for being a nuisance and a dunce.

[Prezident]

Another thing I noticed is that it doesn't seem to be a problem for all users. I have a test ID that I logged on to my forums with and it looked OK. Also asked one of my SuperMods if he was having the problem and he said that he wasn't.

I do indeed have 2 different URL paths available to reach my forums, and tried editing the line 329 code, but that did not work either.

I will just use the v2.0.3 online.php for now, until you get it fixed for this latest version.

Thanks for the help.

[tpearl5]

I'm having the same prob. Freddie, I tried your code swap, and didn't work. Just gonna upload the 2.0.3 version for now.

[Freddie Bingham]

You will have to use the 2.0.3 version until 2.2.1 is release next week.

[express]

You will have to use the 2.0.3 version until 2.2.1 is release next week.

What will be the changes be in this upgrade. This is starting to sound like BS, the same thing happened with the 2.0.3 upgrade everyone upgraded then had to do it all over again becuase of I beieve a fix for sessions.php. Now we all upgrade some of which like mind was very difficult to do and took numerous hours to complete, now less then 2 weeks later I hear there is another upgrade possible.
This is BS,Why not just come out with file with the changes in it and not the entire upgrade.
VBulletin needs to rethink their upgrades or insure that bugs are worked out before they release it. We as members and owners of vbulletin pay for a stable product so why are we finding bugs when the a new upgrade for the product comes out, why is this not found and corrected before the release? By this not being done this is costing customers alot of manhours to upgrade and then upgrade again less then 2 weeks later. This is ridiculous.