[fixed] Unregistered showing up again after preview.

[s.molinari]

Hello Again Dev Team!

Is there an award for the most Bugs squashed?:D

Here is another. (I guess I'm starting to get a bit bolder!:D)

Scenario: (as pointed out by theFlow)

An unregistered user (guest) wishes to post an answer or a thread in a forum open to guests and types in a name in "Your user name". When he previews the post his name is changed back to "Unregistered".

Fix:

In the template 'username_loggedout' I believe the fields for user name and password are named incorrectly. Instead of being name="username" and name="password" they should be name="loginusername" and name="loginpassword".

I believe there would probably be a problem logging in through the form too because of this bug. But I haven't tested.

Scott

[Chen]

Hehe, you did it (http://www.vbulletin.com/forum/showthread.php?s=&threadid=26312).

[Chen]

But now there's another problem - when you edit that post the username is reverted back to "Unregistered".
And another - you can't login when posting (i.e you are logged out, and enter your login info, and post).

[s.molinari]

Originally posted by FireFly
But now there's another problem - when you edit that post the username is reverted back to "Unregistered".

It's not a problem, that will stay that way because the user WAS unregistered. So if he wants the same name then he'll have to reenter it or even if he'd like, change it.


And another - you can't login when posting (i.e you are logged out, and enter your login info, and post).

I tried that after posting this thread because I did want to know if it works or not and it worked for me. After typing in my post, using my user name and password I was logged in again. And my post had me as the poster.

Scott

[theflow]

Originally posted by s.molinari
It's not a problem, that will stay that way because the user WAS unregistered. So if he wants the same name then he'll have to reenter it or even if he'd like, change it.

If I understand correctly (because I have not seen this in action yet), Firefly was suggesting that your solution (bug fix) would somehow interfere with an Unregistered user's ability to edit his already posted message? This continues to confuse me. In the Admin CP, I see a whole list of permission options for Unregistered Users, such as:

* view members info (including other's profiles)
* use 'email to friend' feature
* modify profile (which makes no sense, since an Unregistered user cannot have a profile)
* Rate
* post attachments
* edit own posts
* delete own posts
* move own threads to other forums
* delete own threads by deleting the first post
* use Private Messaging (how is this possible without being registered?)
* edit other's Public events on Calendar
* Is Super Moderator
* Can access control panel

Are these all really valid options? (If not, why are they there?) For instance, I have presumed, perhaps wrongly, that it is impossible and in fact BAD for an unregistered user to edit his own message. How is he authenticated? how would system know it's (unregistered) SillyName101 (who posted the original message) vs some troll SillyName101 trying to subvert the original poster's meaning & intent? (a cookie, perhaps?...) So I have presumed it was not even possible for an Unregsitered user to edit his/her own message -- for good reason.

Thus, addressing Scott's reply above, I have no problem with idea that an Unreg user cannot edit his message once posted.

Fireflysaid : And another - you can't login when posting (i.e you are logged out, and enter your login info, and post).

Scott replied: I tried that after posting this thread because I did want to know if it works or not and it worked for me. After typing in my post, using my user name and password I was logged in again. And my post had me as the poster.
This is more critical to me. Firefly is aware that the functionality I wanted, and which he provided me via hack, was ability to log-out anywhere, then redirect to the page you were last on. This includes a Reply screen or Start New Thread screen. Thus, if I am logged in and Reply or Start new thread, then choose to hit "logout" at either location, I am logged out, then return to this screen where I can do one of several things:

(1) I can now post as an Unregistered user by entering a screenname & ignoring password

(2) or I can enter another Registered name and password right here, compose my message, SUBMIT, and the post not only gets the correct RegisteredName2 applied as author, but it also logs me in as RegisteredName2 in the process. This is exactly the behavior I want.

However, just to complete the scenario: If I am logged in, hit reply (or new thread), amd redirected to reply screen, enter RegisteredName2, compose message, and PREVIEW vs Submit, my Screenname also gets stripped out of the Preview, and if I submit, it posts with a blank name, titled as Guest (I have changed that to "Unregistered"). (I understand v 2.0.3 fixes the issu of allowing no screen name in a submit action; I have not yet upgraded.)

Conclusion:
Scott, if the bug fix you mention enables me to still accomplish (1) and (2) above, and also fixes the screenname lost upon Preview action, then this is awesome!

[s.molinari]

It does.:)

What firefly meant was when the guest wants to change his post he gets 'Unregistered' back into the 'Your user name:' field. But the proper thing would be to set the forum options for guests so that if they do post as a guest they cannot edit the post. The reason being is, every guest could edit any post written by another guest and I don't believe you would want that.

That is the trade off. Post as a guest no editing. But the name will follow....even after previewing.;)

Scott

[theflow]

Originally posted by s.molinari
It does.:)

What firefly meant was when the guest wants to change his post he gets 'Unregistered' back into the 'Your user name:' field. But the proper thing would be to set the forum options for guests so that if they do post as a guest they cannot edit the post. The reason being is, every guest could edit any post written by another guest and I don't believe you would want that.

That is the trade off. Post as a guest no editing. But the name will follow....even after previewing.;)
Scott

That is just spectacular. Thank you. But can you clarify? Just for understanding, if, in the Admin CP, under users & permissions, for Unregistered Users, I selected "can edit own posts" -- this is actually possible? Again, what does own posts mean? There is no authentication, correct? ... And, following this logic trail, how would an Unregistered user be able to use Private Messaging? Unless this simply means, he could SEND a message to someone else, but can't receive?

For me to understand the logic of the Preview/Unregistered situation, I need to understand first if it is truly possible for all of that functionality supposedly avail to Unreg users from the Admin CP. ... But at end of the day, if your fix does everything I need, that is so cool. Thank you.

[s.molinari]

It will solve some of your problems but not all. (like returning to where you where after logging out.)

Let me see if I can clarify some of the illogical logic in the permissions you can give an unregistered user. First of all, the permissions are a given. By that I mean, it is just a "standard" list. All permissions are the same for all usergroups. If you added a new user group, the same list of options would appear. Now let's look at some of the options which may be illogical for an unregistered guest. Let's say you give the unregistered guest total freedom(all options on) then:

1. He still cannot access the user CP. A login is a must to get to the user cp. :)

2. He can send PMs but cannot recieve them. If you'll notice all guest posts do not have the PM link under their posts. This also means that the other PM options really do not count/aren't necessary.

3. He could edit his own posts and for that matter every other guest's. So it would be wise to keep this off for guests. Unless you want a free for all! :D

Those are the only illogical points I can think of. If you have more questions I'll be glad to answer them.

Hope I could help.

Scott

[theflow]

Originally posted by s.molinari
It will solve some of your problems but not all. (like returning to where you where after logging out.)

Scott, then unfortunately for me, it's a no-can-do. If I cannot get the Preview/dropping screen name functionality fixed, I would rather live with that. But for my site, the auto-redirect is an absolute must-have. So, are you saying that if I want to keep the auto-redirect hack which firefly did for me, then I cannot (or should not) make the changes you posted atop this thread?

If so, then can you envision a way to, in a separate hack, accomplish my desire to not have Previw strip out the Screen name? We can email about this and continue that discussion :)

As for the explanation of "givens" and logic, thank you, that's what I have been waiting for. Though I must say, I think given all of the other great inteligence built into vB, it is misguided to include as permission options those things which are not possible to achieve. Seems like they could and should implement some kind of if/then consruct, such that if you are editing the permissions for Unregistered users, only functions that are even possible should show up in that list.

[Chen]

Richard, it's perfectly safe to do what Scott said, it will not harm the logout-return function.

[theflow]

Originally posted by FireFly
Richard, it's perfectly safe to do what Scott said, it will not harm the logout-return function.

Then what does he mean by "It will solve some of your problems but not all. (like returning to where you where after logging out.)"

ha-hah, asking firefly what Scott means... oh this is amusing sometimes...

[Chen]

I assume he didn't know this was already solved, so he said that using his suggestion will not solve this.
But we're gonna have to wait. :)

[s.molinari]

No no. I forgot that that problem was already solved. I was refering to ALL your probs in general. If you have a hack from FireFly then my fix shouldn't bother it. So you should be good to go.

Scott

[theflow]

Originally posted by s.molinari
No no. I forgot that that problem was already solved. I was refering to ALL your probs in general.

If you're referring to ALL my probs in general, you will have to get a subpoena to get my therapy records disclosed, heh-heh... :) One such problem should be obvious to all who have interacted with me on vB: my verbosity. Maybe you can design a chip implant for me so it can be set to "terse" vs "verbose".

Anyway, thanks again for the find. Will the vB developers actually acknowledge it as a bug and fix it? (I don't know how this particular forum works.)

[Chen]

Awesome, now I'm also a mind reader! ;)

[s.molinari]

Uh, just wanted to ask the dev team to look at this again.

Thanx,

Scott

[Mike Sullivan]

Fixed.