[fixed] "Moving" a thread to the same forum it's in

[bira]

Problem:

whether by mistake or because someone else beat you to it, a moderator or admin is able to move thread to the same forum it is already in. This can cause situations like having a redirect to a thread both in the same forum.

Fix:

I added the following to postings.php:


// check to see if this thread is being moved to the same forum it's already in
$checkforum=$DB_site->query_first("SELECT forumid FROM thread WHERE threadid='$threadid'");
if ($checkforum[forumid]==$forumid) {
eval("standarderror(\"".gettemplate("error_movesameforum")."\");");
exit;
}


And then created a new template error_movesameforum which includes the warning "You are trying to move a thread to the same forum it's already in. Perhaps someone beat you to it?"


Anyway, just thought I'd share (not sure this is the right forum, but I decided to post it here because I don't think an admin/mod should be able to move a thread to the same forum it's in, and therefore it's sort of a bug :))

[JamesUS]

I guess this constitues a 'bug' of some sort so I'll move it to the bugs forum for you :)