PDA

View Full Version : Template error reports


John
Mon 4th Jun '01, 7:16pm
Please use this thread only to report any errors with the 2.0.1 templates, such as invalid table widths, bizarre table stretching in Netscape, code inconsistencies (such as <b>hello</B> ) etc.

Kier will keep a close eye on this thread and make any modifications that need to be made.

Reports about default templates from versions earlier than 2.0.1, or about customized templates will be ignored or moved out of this thread.

John

irc
Wed 6th Jun '01, 1:50am
Look for the following line in the template:

<td bgcolor="{secondaltcolor}"><normalfont>$subject</normalfont</td>

Note that the /normalfont tag doesn't have a closing bracket on it.

Wee! Do I win a prize?

tubedogg
Wed 6th Jun '01, 1:53am
No but I will merge this with the Template error thread. :)

Streicher
Fri 8th Jun '01, 6:06pm
I have recognized that the hyperlinks are underlined very different. First I don't know why, but i found it.
Please look at the attached images to see what i mean.

To correct this you have to edit several templates. For example to remove the space in the hyperlinks in that image:

Edit forumdisplay_forumbit_level2_post

Change

<td bgcolor="#F1F1F1" align="left"><a href="forumdisplay.php?s=$session[sessionhash]&forumid=$forum[forumid]"><normalfont><b>$forum[title]</b></normalfont></a><br>
<smallfont>$forum[description]</smallfont></td>

To

<td bgcolor="#F1F1F1" align="left"><a href="forumdisplay.php?s=$session[sessionhash]&forumid=$forum[forumid]"><normalfont><b>$forum[title]</b></normalfont></a>
<br><smallfont>$forum[description]</smallfont></td>

It is the position of the <br>-Tag. It must be in the same line of the hyperlink.

Tested with IE 5.5 on vB 2.0.1

BTW: The vB loose the Path to an attached file if you click on "Preview Reply"

Wayne Luke
Fri 8th Jun '01, 6:35pm
Forms embedded in tables should be:

<form ....><table>

Not
<table><tr><form ....>

The latter breaks tables in Internet Explorer 6.0 and is not valid HTML structuring according to the HTML 4.01 Transitional DTD which is the default that vBulletin ships with.

Some other invalid structures used in the templates such as:
<font....><p></p></font>

or

<p><br><hr><br></p>.

Use of Deprecated tags should be lowered or eliminated... Non-standard tags shouldn't be used in the distributed styleset.

The CSS that you are using as ID's LTLINK and THTCOLOR should be classified as Classes since an ID should only be used once per page whereas Classes can be used multiple times.

For more information check here:
http://validator.w3.org/check?uri=http%3A%2F%2F161.58.84.213%2Fforum%2Find ex.php&doctype=Inline

evoir
Fri 8th Jun '01, 8:04pm
OK, I'll give this a try, but I'll also put a picture up to explain.

A few vB pages appear odd on our site. We use a very limited space of 600 pixels wide, and in a fe pages (not necc. a comprehensive list) the content table breaks out of our header/footer table.

postreply (the Topic Preview bursts out of table)
editpost (the Topic Preview bursts out of table)
standarderror (I changed these to fix them)
standardredirect (I changed these to fix them)

Most all the other pages are fine.

here is a picture:

CoolaShacka
Fri 8th Jun '01, 9:18pm
the error foundeda by irc appear in

calendar_getinfo and in calendar_daybits too

CoolaShacka
Fri 8th Jun '01, 9:50pm
One more question:
What does the NOBR tag in forumhome_loggedinusers mean?
It seems to be not HTML 4.01

tubedogg
Fri 8th Jun '01, 11:33pm
Originally posted by evoir
A few vB pages appear odd on our site. We use a very limited space of 600 pixels wide, and in a fe pages (not necc. a comprehensive list) the content table breaks out of our header/footer table.This is intended. You will also find it on showthread pages with exceptionally wide posts, and a couple others I belive. It is so the whole page is not pushed out, rather just the particular post that is too wide or what-have-you.

Freddie Bingham
Fri 8th Jun '01, 11:37pm
evoir if you put a table around your forum than you will need to edit those templates to remove some opening and closing table tags. There have been several threads about it in the past few weeks.

Kier
Sat 9th Jun '01, 6:46am
Originally posted by wluke
Forms embedded in tables should be:

<form ....><table>

Not
<table><tr><form ....>

The latter breaks tables in Internet Explorer 6.0 and is not valid HTML structuring according to the HTML 4.01 Transitional DTD which is the default that vBulletin ships with.

I would hope that <table><tr><form> does not exist anywhere in the templates... however, <table><form><tr> is widely used, as it is an effective way to add an 'invisible' <form> tag (<form><table><tr>.......</tr></table></form> produces an extra linebreak)

The CSS that you are using as ID's LTLINK and THTCOLOR should be classified as Classes since an ID should only be used once per page whereas Classes can be used multiple times.

These definitions are 'legacy' vBulletin code... my forum no longer uses them, and nor will 2.1, which will be far more reliant on CSS than basic HTML markup.

Mas*Mind
Sun 10th Jun '01, 4:31pm
When you've set the borderoutline to 0, the My vB Home Edit Profile Edit Options Change Password Edit Buddy List Edit Ignore List Private Messaging table in the usercp is still bordered.

Kier
Mon 11th Jun '01, 11:27am
Yes, this is by design. It's a fairly simple change to the usercpnav template if you want to change it.

Wayne Luke
Mon 18th Jun '01, 10:32pm
Originally posted by Kier


I would hope that <table><tr><form> does not exist anywhere in the templates... however, <table><form><tr> is widely used, as it is an effective way to add an 'invisible' <form> tag (<form><table><tr>.......</tr></table></form> produces an extra linebreak)


It may be widely used but it is still invalid nesting according to the HTML 4.01 transitional DTD. And it would downright kill a page if put up to a XHTML DTD.

Oh well... I have edited the Templates to be HTML 4.01 compatible anyway. I don't have any problems with extra line breaks that appear because I know that the page can be rendered in any browser.

dwh
Sat 23rd Jun '01, 1:56pm
forumhome_birthdaybit is missing an </b>

aaronx88
Mon 2nd Jul '01, 11:20am
Hope this might help.

registeradult template is missing a </tr> tag.

<option value="+12">(GMT +12:00 hours) Auckland, Wellington, Fiji, Kamchatka</option>
</select></smallfont></td></tr>

tubedogg
Tue 3rd Jul '01, 2:09am
Template: subscribe_threads
Problem: The first table tag<table cellpadding="(tableouterborderwidth)" cellspacing="0" border="0" bgcolor="(tablebordercolor)" (tableouterextra) width="100%" align="center">has width="100%" instead of width="(contenttablewidth)".

Templates: email_activateaccount & email_activateaccount_change
Problem: Contains $contactaddress instead of $webmasteraddress, meaning the line
"If you are still having problems signing up please contact a member of our support staff at"
has no address at the end.

Template: error_edittimelimit
Problem: administrator is misspelled admisitrator.

dwh
Tue 3rd Jul '01, 2:36am
Nice catch, but on my template Originally posted by tubedogg
Template: subscribe_threads
Problem: The first table tag<table cellpadding="(tableouterborderwidth)" cellspacing="0" border="0" bgcolor="(tablebordercolor)" (tableouterextra) width="100%" align="center">has width="100%" instead of width="(contenttablewidth)".


This one does have contenttablewidth, at least for the first table, the second table has 100%, is this wrong?

tubedogg
Tue 3rd Jul '01, 2:47am
That's weird. I hadn't edited that part of the template, and it had width="100%", and I even clicked "View Original" to see if I had changed it and forgotten about it.

I just checked again now - my default template has width="100%". I'm gonna check the vbulletin.style file.

In my vbulletin.style (stock from 2.0.1), line 4402 has<table cellpadding="(tableouterborderwidth)" cellspacing="0" border="0" bgcolor="(tablebordercolor)" (tableouterextra) width="100%" align="center"><tr><td>Did I somehow get a screwed up zip file? I'm going to try downloading again.

Edit: I downloaded another zip from the member's area, and the vbulletin.style file's line 4402 is the same as in my copy, with width="100%" instead of the correct (contenttablewidth).

dwh
Tue 3rd Jul '01, 11:49am
Really weird, I'll check the .style file too tomorrow, too busy today, but I'll let you know.

dwh
Fri 6th Jul '01, 9:28pm
You did not select a option to vote for. Please press back to return to the poll and choose a option before voting.

should be "an option" twice.

Mike Sullivan
Mon 9th Jul '01, 12:23am
Fixed all of these I could find. There were a couple I had problems with:

forumhome_birthdaybit -- there's no bold tag whatsoever.
subscribe_(no)threads -- couldn't do the edit there as it effected other pages; had to edit "subscribe" instead.

Pilot
Thu 12th Jul '01, 5:22pm
Typo:

Sorry! The administrator has specifier that you can only do one search every 60 seconds.



Where should I correct this?

Mike Sullivan
Thu 12th Jul '01, 7:09pm
error_searchfloodcheck

Mike Sullivan
Wed 18th Jul '01, 12:47pm
I'm too lazy to merge in, so... http://www.vbulletin.com/forum/showthread.php?s=&threadid=23041