Floris
Thu 8th Jun '06, 7:44am
license_agreement.html
Doesn't have copyright in the footer, does that mean we can 100% copy it for use on other commercial products? .. My suggestion is to include a copyright below everything.
------------------------------------------------------------------
vb3_readme.html & vb3_readme.txt
Copyright in footer is 2005, should be 2006 now.
and
"Please note that the format for config.php in vBulletin 3.5.x is different from previous versions of vBulletin"
This has to be 3.6.x for 3.6 .zip
------------------------------------------------------------------
vb3_readme.txt
If you just double click this in Windows XP to open it in notepad it becomes unreadable.
------------------------------------------------------------------
searchshell.php
Does this file work on 3.6?
and
When the file is run does it check if it uses the vBulletin search (continue) or the FULLTEXT search type (why run it? halt)?
------------------------------------------------------------------
tools.php
Cookie Prefix says it is set to bb (set in includes/config.inc.php)
Isn't it config.php?
------------------------------------------------------------------
install_language_en.php
$upgradecore_phrases['apc_too_old'] contains 3.5, should be 3.6
(same goes for vbulletin-language.xml >> <phrase name="apc_too_old" date="0" username="" version=""> by the way)
$install_phrases['welcome'] contains 3.5, I think we want to welcome people to 3.6 ;)
------------------------------------------------------------------
vbulletin-adminhelp.xml
has occurance of 3.5
------------------------------------------------------------------
upgrade_language_en.php
$upgradecore_phrases['vb3_upgrade_system'] has occurance of 3.5
$upgradecore_phrases['apc_too_old'] has occurance of 3.5
------------------------------------------------------------------
and probably a few in vbulletin-style.xml
That's it for now ;)
Doesn't have copyright in the footer, does that mean we can 100% copy it for use on other commercial products? .. My suggestion is to include a copyright below everything.
------------------------------------------------------------------
vb3_readme.html & vb3_readme.txt
Copyright in footer is 2005, should be 2006 now.
and
"Please note that the format for config.php in vBulletin 3.5.x is different from previous versions of vBulletin"
This has to be 3.6.x for 3.6 .zip
------------------------------------------------------------------
vb3_readme.txt
If you just double click this in Windows XP to open it in notepad it becomes unreadable.
------------------------------------------------------------------
searchshell.php
Does this file work on 3.6?
and
When the file is run does it check if it uses the vBulletin search (continue) or the FULLTEXT search type (why run it? halt)?
------------------------------------------------------------------
tools.php
Cookie Prefix says it is set to bb (set in includes/config.inc.php)
Isn't it config.php?
------------------------------------------------------------------
install_language_en.php
$upgradecore_phrases['apc_too_old'] contains 3.5, should be 3.6
(same goes for vbulletin-language.xml >> <phrase name="apc_too_old" date="0" username="" version=""> by the way)
$install_phrases['welcome'] contains 3.5, I think we want to welcome people to 3.6 ;)
------------------------------------------------------------------
vbulletin-adminhelp.xml
has occurance of 3.5
------------------------------------------------------------------
upgrade_language_en.php
$upgradecore_phrases['vb3_upgrade_system'] has occurance of 3.5
$upgradecore_phrases['apc_too_old'] has occurance of 3.5
------------------------------------------------------------------
and probably a few in vbulletin-style.xml
That's it for now ;)